mirror of
https://github.com/actualbudget/actual.git
synced 2026-07-16 07:04:23 -05:00
[GH-ISSUE #2644] [Bug]: Transaction Edit menu shortcuts have poor contrast in dark mode (and lesser so in midnight) #26843
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/actual#26843
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Teprifer on GitHub (Apr 20, 2024).
Original GitHub issue: https://github.com/actualbudget/actual/issues/2644
Verified issue does not already exist?
What happened?
Referring to the short cut letters on the right side of the transaction edit menu.
If the shortcut for Show wasn't F they could be done away with entirely by underlining their respective short cut letter in the action name itself.
Light for comparison:
Dark (very poor contrast):
Midnight (poor contrast):
Generally, I think the size of these could be improved which would aid, but improving contrast should help with discoverability enough.
Where are you hosting Actual?
Docker
What browsers are you seeing the problem on?
Firefox, Chrome
Operating System
Windows 11
@sierikov commented on GitHub (Apr 25, 2024):
With current colors, it is nearly impossible to make the color contrast and accent at the same time. The boundary for acceptable contrast ratios lies in the zone left from the white lines on the provided image. Any area to the right of these lines is deemed "unreadable."
To achieve the desired contrast ratio we must:
I have experimented with the colors and forms of the menu. The results please see below:
Modified subsection header:
Please let me know what you think
@Teprifer commented on GitHub (Apr 25, 2024):
@sierikov Were you thinking of #2638 ?
This is a bug report for the same menu, but specifically the shortcut letters on the right side, not the menu headers themselves.
It was reading the other one which reminded me I hadn't created a bug report for this issue.