github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 15:12:35 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #1517] [MERGED] ♻️ extract rules components to individual files + TS #18154

New Issue
Closed
opened 2026-04-14 20:36:06 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-14 20:36:06 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/1517
Author: @MatissJanis
Created: 8/12/2023
Status: ✅ Merged
Merged: 8/17/2023
Merged by: @MatissJanis

Base: master ← Head: matiss/extract-rules

📝 Commits (5)

  • 2ce39ce ♻️ extract rules components to individual files + TS
  • bf992d7 Release notes
  • a74858f Revert a small change
  • b55a117 Feedback: port to React CSSProperties
  • 4827fbd Merge branch 'master' into matiss/extract-rules

📊 Changes

19 files changed (+656 additions, -482 deletions)

View changed files

📝 packages/desktop-client/src/components/ManageRules.js (+7 -474)
📝 packages/desktop-client/src/components/common/Button.tsx (+2 -2)
📝 packages/desktop-client/src/components/filters/FiltersMenu.js (+1 -1)
➕ packages/desktop-client/src/components/rules/ActionExpression.tsx (+64 -0)
➕ packages/desktop-client/src/components/rules/ConditionExpression.tsx (+57 -0)
➕ packages/desktop-client/src/components/rules/RuleRow.tsx (+130 -0)
➕ packages/desktop-client/src/components/rules/RulesHeader.tsx (+22 -0)
➕ packages/desktop-client/src/components/rules/RulesList.tsx (+47 -0)
➕ packages/desktop-client/src/components/rules/ScheduleValue.tsx (+32 -0)
➕ packages/desktop-client/src/components/rules/SchedulesQuery.tsx (+4 -0)
➕ packages/desktop-client/src/components/rules/SimpleTable.tsx (+69 -0)
➕ packages/desktop-client/src/components/rules/Value.tsx (+185 -0)
📝 packages/desktop-client/src/components/table.tsx (+1 -1)
📝 packages/loot-core/src/client/query-hooks.tsx (+1 -1)
📝 packages/loot-core/src/shared/rules.ts (+1 -1)
📝 packages/loot-core/src/shared/schedules.ts (+8 -0)
📝 packages/loot-core/src/types/models/index.d.ts (+1 -0)
📝 packages/loot-core/src/types/models/rule.d.ts (+18 -2)
➕ upcoming-release-notes/1517.md (+6 -0)

📄 Description

Extracted the rules components into individual files. Also converted the components to support typescript.

There are no functional changes in this PR. For the most part it is just copy+paste into individual files. With the additional of TS interfaces.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/1517 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 8/12/2023 **Status:** ✅ Merged **Merged:** 8/17/2023 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/extract-rules` --- ### 📝 Commits (5) - [`2ce39ce`](https://github.com/actualbudget/actual/commit/2ce39cec089bc82501cedad8c66dd9aaec1f3c06) :recycle: extract rules components to individual files + TS - [`bf992d7`](https://github.com/actualbudget/actual/commit/bf992d77121abf899dc8deff451842a2b0cd9a6b) Release notes - [`a74858f`](https://github.com/actualbudget/actual/commit/a74858f7668a3577aa8ac51145e53fe61ac1654f) Revert a small change - [`b55a117`](https://github.com/actualbudget/actual/commit/b55a117447bbcdba0daf765e3993b0135daab872) Feedback: port to React CSSProperties - [`4827fbd`](https://github.com/actualbudget/actual/commit/4827fbdae9c2ccf904b4b5c988dc52ba6fadd573) Merge branch 'master' into matiss/extract-rules ### 📊 Changes **19 files changed** (+656 additions, -482 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/ManageRules.js` (+7 -474) 📝 `packages/desktop-client/src/components/common/Button.tsx` (+2 -2) 📝 `packages/desktop-client/src/components/filters/FiltersMenu.js` (+1 -1) ➕ `packages/desktop-client/src/components/rules/ActionExpression.tsx` (+64 -0) ➕ `packages/desktop-client/src/components/rules/ConditionExpression.tsx` (+57 -0) ➕ `packages/desktop-client/src/components/rules/RuleRow.tsx` (+130 -0) ➕ `packages/desktop-client/src/components/rules/RulesHeader.tsx` (+22 -0) ➕ `packages/desktop-client/src/components/rules/RulesList.tsx` (+47 -0) ➕ `packages/desktop-client/src/components/rules/ScheduleValue.tsx` (+32 -0) ➕ `packages/desktop-client/src/components/rules/SchedulesQuery.tsx` (+4 -0) ➕ `packages/desktop-client/src/components/rules/SimpleTable.tsx` (+69 -0) ➕ `packages/desktop-client/src/components/rules/Value.tsx` (+185 -0) 📝 `packages/desktop-client/src/components/table.tsx` (+1 -1) 📝 `packages/loot-core/src/client/query-hooks.tsx` (+1 -1) 📝 `packages/loot-core/src/shared/rules.ts` (+1 -1) 📝 `packages/loot-core/src/shared/schedules.ts` (+8 -0) 📝 `packages/loot-core/src/types/models/index.d.ts` (+1 -0) 📝 `packages/loot-core/src/types/models/rule.d.ts` (+18 -2) ➕ `upcoming-release-notes/1517.md` (+6 -0) </details> ### 📄 Description Extracted the rules components into individual files. Also converted the components to support typescript. **There are no functional changes in this PR.** For the most part it is just copy+paste into individual files. With the additional of TS interfaces. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-14 20:36:06 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#18154
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?