github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-07-16 07:04:23 -05:00
Code Issues 3.0k Packages Projects Releases 58 Wiki Activity

[PR #6491] [MERGED] Fix crash when switching filter operators between single and multi-value modes #125989

New Issue
Closed
opened 2026-06-14 05:00:28 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-06-14 05:00:28 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/6491
Author: @Copilot
Created: 12/26/2025
Status: ✅ Merged
Merged: 12/30/2025
Merged by: @MatissJanis

Base: master ← Head: copilot/fix-app-crash-report-field

📝 Commits (10+)

  • 2c62874 Initial plan
  • 6de1813 Fix crash when switching filter from 'is' to 'one of'
  • 6d15128 Add type assertions to fix TypeScript errors
  • a4290ab Keep first element when switching from 'one of' to 'is', use strict comparison
  • d012730 Add release notes for PR #6491
  • d591448 Fix crash due to filter value conversion issue
  • 4a40085 Address PR feedback: remove notes test, preserve single values between operators
  • 67f8be5 Update value handling in updateFilterReducer
  • 229d628 Refactor value assignment for single-value operators
  • 16aaa6e Refactor value assignment logic in updateFilterReducer

📊 Changes

3 files changed (+173 additions, -3 deletions)

View changed files

➕ packages/desktop-client/src/components/filters/updateFilterReducer.test.ts (+151 -0)
📝 packages/desktop-client/src/components/filters/updateFilterReducer.ts (+16 -3)
➕ upcoming-release-notes/6491.md (+6 -0)

📄 Description

Plan to Fix Filter Crash Issue

  • Explore repository structure and understand the issue
  • Identify the root cause: When switching from "is" to "one of", the value is not converted from a single value to an array
  • Create a test to verify the fix
  • Fix the updateFilterReducer.ts to convert single values to arrays when switching to "oneOf" or "notOneOf" operators
  • Verify the fix works correctly (tests passing)
  • Run full test suite to ensure no regressions (all web tests pass)
  • Run type checking and linting (both pass)
  • Handle switching from 'one of' to 'is' by keeping first element
  • Use strict comparison operators (===)
  • Code review completed with no issues
  • Address PR feedback: remove notes test, improve single-value preservation

Fix Summary:

This PR fixes a crash that occurred when editing report filters by changing operators between single-value and multi-value types.

Changes Made:

  1. Bidirectional conversion support:
    • Switching TO "oneOf"/"notOneOf": Converts single values to arrays, null/undefined to empty arrays
    • Switching FROM "oneOf"/"notOneOf": Keeps the first element if array has values, otherwise null
    • Single values are preserved when switching between single-value operators (e.g., 'is' to 'contains')
  2. Code quality: Uses strict comparison operators (===) throughout
  3. Comprehensive testing: 9 unit tests covering all conversion scenarios

Testing: All tests pass, type checking and linting pass, no regressions detected.

Original prompt

This section details on the original issue you should resolve

<issue_title>[Bug]: App crashes when editing report field from "is" (with value) to "one of"</issue_title>
<issue_description>### Verified issue does not already exist?

  • I have searched and found no existing issue

What happened?

I've noticed Actual consistently crashes when editing a report filter when moving from is to one of and the is field is set to a value. Haven't tested all the combinations, but guessing other changes can trigger a similar problem. Example screenshots below.

TypeError: l.map is not a function at Lot...
Image Image

How can we reproduce the issue?

How can we reproduce the issue?

Go to a report filter of type account, category, or notes (interestingly, payee does not have this bug), and set a value under is or is not and then change to one of or not one of. (I have not tested all the combinations, but these ones for sure cause the crash.)

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome, Other, Firefox

Operating System

Windows 10</issue_description>

Comments on the Issue (you are @copilot in this section)

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Summary by CodeRabbit

  • Bug Fixes
    • Improved filter operator switching to intelligently preserve and convert filter values based on the selected operator type. When switching between single-value operators (is, contains) and multi-value operators (oneOf), values are now properly handled rather than unexpectedly cleared, with better support for edge cases.

✏️ Tip: You can customize this high-level summary in your review settings.

Note

Fixes filter operator switching by normalizing value between single- and multi-select modes to prevent crashes.

  • Updates updateFilterReducer to:
    • When switching to single-value ops (is, isNot, contains, etc.), convert arrays to first element or null if empty
    • When switching to multi-value ops (oneOf, notOneOf), convert single values to arrays and null/undefined to []
  • Adds unit tests (updateFilterReducer.test.ts) covering bidirectional conversions and edge cases (empty arrays, nulls, preservation between single-value ops)
  • Adds release note entry documenting the bugfix

Written by Cursor Bugbot for commit fe0bf2cf9d. This will update automatically on new commits. Configure here.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/6491 **Author:** [@Copilot](https://github.com/apps/copilot-swe-agent) **Created:** 12/26/2025 **Status:** ✅ Merged **Merged:** 12/30/2025 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `copilot/fix-app-crash-report-field` --- ### 📝 Commits (10+) - [`2c62874`](https://github.com/actualbudget/actual/commit/2c62874ad22decee04db18fccf917202cc3a6bc6) Initial plan - [`6de1813`](https://github.com/actualbudget/actual/commit/6de1813c421f8ca8552b8e31d234d4430ced8fa4) Fix crash when switching filter from 'is' to 'one of' - [`6d15128`](https://github.com/actualbudget/actual/commit/6d15128186fc4836d68c7d418e0b571d07a5c5c1) Add type assertions to fix TypeScript errors - [`a4290ab`](https://github.com/actualbudget/actual/commit/a4290ab5519474b35f8766f16333b6a823e7b695) Keep first element when switching from 'one of' to 'is', use strict comparison - [`d012730`](https://github.com/actualbudget/actual/commit/d0127306a4ed561196f91520ad769c33cf447a00) Add release notes for PR #6491 - [`d591448`](https://github.com/actualbudget/actual/commit/d591448770bd63f5d55adf796debbf32784b73ee) Fix crash due to filter value conversion issue - [`4a40085`](https://github.com/actualbudget/actual/commit/4a40085c72f74d24f12bc1e1311f0df577828daa) Address PR feedback: remove notes test, preserve single values between operators - [`67f8be5`](https://github.com/actualbudget/actual/commit/67f8be54a78e17254fe35128eae7440440c07b4c) Update value handling in updateFilterReducer - [`229d628`](https://github.com/actualbudget/actual/commit/229d628627b361fbdba094ed821bc322483f1cef) Refactor value assignment for single-value operators - [`16aaa6e`](https://github.com/actualbudget/actual/commit/16aaa6eee751d6f61e26c7d94b521ac463786978) Refactor value assignment logic in updateFilterReducer ### 📊 Changes **3 files changed** (+173 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `packages/desktop-client/src/components/filters/updateFilterReducer.test.ts` (+151 -0) 📝 `packages/desktop-client/src/components/filters/updateFilterReducer.ts` (+16 -3) ➕ `upcoming-release-notes/6491.md` (+6 -0) </details> ### 📄 Description ## Plan to Fix Filter Crash Issue - [x] Explore repository structure and understand the issue - [x] Identify the root cause: When switching from "is" to "one of", the value is not converted from a single value to an array - [x] Create a test to verify the fix - [x] Fix the `updateFilterReducer.ts` to convert single values to arrays when switching to "oneOf" or "notOneOf" operators - [x] Verify the fix works correctly (tests passing) - [x] Run full test suite to ensure no regressions (all web tests pass) - [x] Run type checking and linting (both pass) - [x] Handle switching from 'one of' to 'is' by keeping first element - [x] Use strict comparison operators (===) - [x] Code review completed with no issues - [x] Address PR feedback: remove notes test, improve single-value preservation **Fix Summary**: This PR fixes a crash that occurred when editing report filters by changing operators between single-value and multi-value types. **Changes Made**: 1. **Bidirectional conversion support**: - Switching TO "oneOf"/"notOneOf": Converts single values to arrays, null/undefined to empty arrays - Switching FROM "oneOf"/"notOneOf": Keeps the first element if array has values, otherwise null - Single values are preserved when switching between single-value operators (e.g., 'is' to 'contains') 2. **Code quality**: Uses strict comparison operators (===) throughout 3. **Comprehensive testing**: 9 unit tests covering all conversion scenarios **Testing**: All tests pass, type checking and linting pass, no regressions detected. <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Bug]: App crashes when editing report field from "is" (with value) to "one of"</issue_title> > <issue_description>### Verified issue does not already exist? > > - [x] I have searched and found no existing issue > > ### What happened? > > I've noticed Actual consistently crashes when editing a report filter when moving from `is` to `one of` and the is field is set to a value. Haven't tested all the combinations, but guessing other changes can trigger a similar problem. Example screenshots below. > ``` > TypeError: l.map is not a function at Lot... > ``` > > <img width="255" height="197" alt="Image" src="https://github.com/user-attachments/assets/92d3fc8e-b8b5-40bb-bbb9-4229adaeb718" /> > > <img width="566" height="250" alt="Image" src="https://github.com/user-attachments/assets/a9d013b3-349c-4f18-a7fc-6a19053c2ef2" /> > > ### How can we reproduce the issue? > > How can we reproduce the issue? > > Go to a report filter of type account, category, or notes (interestingly, payee does not have this bug), and set a value under `is` or `is not` and then change to `one of` or `not one of`. (I have not tested all the combinations, but these ones for sure cause the crash.) > > ### Where are you hosting Actual? > > Docker > > ### What browsers are you seeing the problem on? > > Chrome, Other, Firefox > > ### Operating System > > Windows 10</issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> <!-- START COPILOT CODING AGENT SUFFIX --> - Fixes actualbudget/actual#6452 <!-- START COPILOT CODING AGENT TIPS --> --- ✨ Let Copilot coding agent [set things up for you](https://github.com/actualbudget/actual/issues/new?title=✨+Set+up+Copilot+instructions&body=Configure%20instructions%20for%20this%20repository%20as%20documented%20in%20%5BBest%20practices%20for%20Copilot%20coding%20agent%20in%20your%20repository%5D%28https://gh.io/copilot-coding-agent-tips%29%2E%0A%0A%3COnboard%20this%20repo%3E&assignees=copilot) — coding agent works faster and does higher quality work when set up for your repo. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved filter operator switching to intelligently preserve and convert filter values based on the selected operator type. When switching between single-value operators (is, contains) and multi-value operators (oneOf), values are now properly handled rather than unexpectedly cleared, with better support for edge cases. <sub>✏️ Tip: You can customize this high-level summary in your review settings.</sub> <!-- end of auto-generated comment: release notes by coderabbit.ai --> <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Fixes filter operator switching by normalizing `value` between single- and multi-select modes to prevent crashes. > > - Updates `updateFilterReducer` to: > - When switching to single-value ops (`is`, `isNot`, `contains`, etc.), convert arrays to first element or `null` if empty > - When switching to multi-value ops (`oneOf`, `notOneOf`), convert single values to arrays and `null/undefined` to `[]` > - Adds unit tests (`updateFilterReducer.test.ts`) covering bidirectional conversions and edge cases (empty arrays, nulls, preservation between single-value ops) > - Adds release note entry documenting the bugfix > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit fe0bf2cf9d520f580026258dc2ada1270429c0a4. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-06-14 05:00:28 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
tech-support
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#125989
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?