github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-06 07:01:45 -05:00
Code Issues 1.5k Packages Projects Releases 54 Wiki Activity

[PR #2494] [MERGED] 🐛 (import) disallow importing transactions with too large or small amounts #11388

New Issue
Closed
opened 2026-04-10 20:59:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-10 20:59:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/actualbudget/actual/pull/2494
Author: @MatissJanis
Created: 3/23/2024
Status: ✅ Merged
Merged: 3/24/2024
Merged by: @MatissJanis

Base: master ← Head: matiss/fix-1811

📝 Commits (3)

  • 5b60154 🐛 (import) disallow importing transactions with too large or small amounts
  • 2f2fd84 Release notes
  • 9c331b3 Fix in/out logic

📊 Changes

3 files changed (+74 additions, -25 deletions)

View changed files

📝 packages/desktop-client/src/components/modals/ImportTransactions.jsx (+58 -24)
📝 packages/loot-core/src/shared/util.ts (+10 -1)
➕ upcoming-release-notes/2494.md (+6 -0)

📄 Description

Closes #1811

Disallow importing transactions with too large or too small amounts. These transactions are poison pills. We allow to import them, but afterwards they crash the app with no way to recover. So now it will no longer be possible to import with poison pill amounts.

Screenshot 2024-03-23 at 10 46 10

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/actualbudget/actual/pull/2494 **Author:** [@MatissJanis](https://github.com/MatissJanis) **Created:** 3/23/2024 **Status:** ✅ Merged **Merged:** 3/24/2024 **Merged by:** [@MatissJanis](https://github.com/MatissJanis) **Base:** `master` ← **Head:** `matiss/fix-1811` --- ### 📝 Commits (3) - [`5b60154`](https://github.com/actualbudget/actual/commit/5b601548e08cca98af96a59c4fa4665c35ea10e9) :bug: (import) disallow importing transactions with too large or small amounts - [`2f2fd84`](https://github.com/actualbudget/actual/commit/2f2fd84d4fe75b748c2188cfe90b0b2058779750) Release notes - [`9c331b3`](https://github.com/actualbudget/actual/commit/9c331b3705d2c4b6a83912cf25a417f731fbc59e) Fix in/out logic ### 📊 Changes **3 files changed** (+74 additions, -25 deletions) <details> <summary>View changed files</summary> 📝 `packages/desktop-client/src/components/modals/ImportTransactions.jsx` (+58 -24) 📝 `packages/loot-core/src/shared/util.ts` (+10 -1) ➕ `upcoming-release-notes/2494.md` (+6 -0) </details> ### 📄 Description Closes #1811 Disallow importing transactions with too large or too small amounts. These transactions are poison pills. We allow to import them, but afterwards they crash the app with no way to recover. So now it will no longer be possible to import with poison pill amounts. <img width="962" alt="Screenshot 2024-03-23 at 10 46 10" src="https://github.com/actualbudget/actual/assets/886567/1f01dfce-7642-4a8a-979e-8fb0c4c6d750"> --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-10 20:59:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
AI generated
API
bank sync
budgeting
bug
can’t replicate
dependencies
docker
documentation
electron
experimental feature
feature
feedback
goal templates
good first issue
help wanted
importers
maintenance
needs info
needs testing
needs triage
needs votes
openid
payees
pull-request
Mirrored from GitHub Pull Request
 regression
reports
responsive
rules
schedules
server
✨ merged
split transactions
tech debt
theme
transaction import
transaction reconciliation
transactions
translations
upstream
user interface
✅ approved
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/actual#11388
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?