[autofix.ci] apply automated fixes

.coderabbit.yaml

@@ -10,7 +10,6 @@ reviews:
       enabled: false
   pre_merge_checks:
     docstrings:
-      mode: off
       enabled: false
     custom_checks:
       - mode: error

.github/actions/ai-generated-release-notes/pr-details.js

@@ -36,13 +36,11 @@ async function getPRDetails() {
     console.log('- PR Number:', pr.number);
     console.log('- PR Author:', pr.user.login);
     console.log('- PR Title:', pr.title);
-    console.log('- Base Branch:', pr.base.ref);
 
     const result = {
       number: pr.number,
       author: pr.user.login,
       title: pr.title,
-      baseBranch: pr.base.ref,
     };
 
     setOutput('result', JSON.stringify(result));

.github/workflows/ai-generated-release-notes.yml

@@ -41,21 +41,8 @@ jobs:
           GITHUB_REPOSITORY: ${{ github.repository }}
           GITHUB_EVENT_ISSUE_NUMBER: ${{ github.event.issue.number }}
 
-      - name: Check if PR targets master branch
-        if: steps.check-first-comment.outputs.result == 'true' && steps.pr-details.outputs.result != 'null'
-        id: check-base-branch
-        run: |
-          BASE_BRANCH=$(echo '${{ steps.pr-details.outputs.result }}' | jq -r '.baseBranch')
-          echo "Base branch: $BASE_BRANCH"
-          if [ "$BASE_BRANCH" = "master" ]; then
-            echo "targets_master=true" >> $GITHUB_OUTPUT
-          else
-            echo "targets_master=false" >> $GITHUB_OUTPUT
-            echo "PR does not target master branch, skipping release notes generation"
-          fi
-
       - name: Check if release notes file already exists
-        if: steps.check-first-comment.outputs.result == 'true' && steps.pr-details.outputs.result != 'null' && steps.check-base-branch.outputs.targets_master == 'true'
+        if: steps.check-first-comment.outputs.result == 'true' && steps.pr-details.outputs.result != 'null'
         id: check-release-notes-exists
         run: node .github/actions/ai-generated-release-notes/check-release-notes-exists.js
         env:

.github/workflows/e2e-test.yml

@@ -30,7 +30,7 @@ jobs:
       matrix:
         shard: [1, 2, 3, 4, 5]
     container:
-      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      image: mcr.microsoft.com/playwright:v1.56.0-jammy
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Set up environment
@@ -53,7 +53,7 @@ jobs:
     name: Functional Desktop App
     runs-on: ubuntu-latest
     container:
-      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      image: mcr.microsoft.com/playwright:v1.56.0-jammy
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Set up environment
@@ -81,7 +81,7 @@ jobs:
       matrix:
         shard: [1, 2, 3, 4, 5]
     container:
-      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      image: mcr.microsoft.com/playwright:v1.56.0-jammy
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Set up environment
@@ -104,7 +104,7 @@ jobs:
     runs-on: ubuntu-latest
     if: ${{ !cancelled() }}
     container:
-      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      image: mcr.microsoft.com/playwright:v1.56.0-jammy
     steps:
       - uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0
       - name: Set up environment

.github/workflows/generate-release-pr.yml

@@ -50,7 +50,6 @@ jobs:
       - name: Create PR
         uses: peter-evans/create-pull-request@271a8d0340265f705b14b6d32b9829c1cb33d45e # v7.0.8
         with:
-          token: ${{ secrets.ACTIONS_UPDATE_TOKEN }}
           commit-message: '🔖 (${{ steps.bump_package_versions.outputs.version }})'
           title: '🔖 (${{ steps.bump_package_versions.outputs.version }})'
           body: 'Generated by [generate-release-pr.yml](../tree/master/.github/workflows/generate-release-pr.yml)'

.github/workflows/vrt-update-generate.yml

@@ -44,7 +44,7 @@ jobs:
       github.event.issue.pull_request &&
       startsWith(github.event.comment.body, '/update-vrt')
     container:
-      image: mcr.microsoft.com/playwright:v1.57.0-jammy
+      image: mcr.microsoft.com/playwright:v1.56.0-jammy
     steps:
       - name: Get PR details
         id: pr

.oxlintrc.json

@@ -15,7 +15,7 @@
     "vi": "readonly",
     "backend": "readonly",
     "importScripts": "readonly",
-    "FS": "readonly"
+    "FS": "readonly" // TODO: remove this
   },
   "rules": {
     // TODO fix all these and re-enable
@@ -103,7 +103,13 @@
     "jsx-a11y/scope": "warn",
 
     // Typescript rules
-    "typescript/ban-ts-comment": ["warn"],
+    "typescript/ban-ts-comment": [
+      "warn",
+      {
+        // TODO: remove this
+        "ts-ignore": "allow-with-description"
+      }
+    ],
     "typescript/consistent-type-definitions": ["warn", "type"],
     "typescript/consistent-type-imports": [
       "warn",
@@ -184,7 +190,7 @@
 
     // ESLint rules
     "eslint/array-callback-return": "warn",
-    "eslint/curly": ["warn", "multi-line", "consistent"],
+    // "eslint/curly": ["warn", "multi-line", "consistent"], // TODO: re-enable? this rule is really slow
     "eslint/default-case": [
       "warn",
       {
@@ -464,9 +470,16 @@
     // TODO: enable these
     {
       "files": [
+        "packages/desktop-client/src/components/admin/UserAccess/UserAccess.tsx",
+        "packages/desktop-client/src/components/admin/UserDirectory/UserDirectory.tsx",
+        "packages/desktop-client/src/components/budget/BudgetCategories.tsx",
+        "packages/desktop-client/src/components/budget/envelope/BalanceMovementMenu.tsx",
         "packages/desktop-client/src/components/ManageRules.tsx",
         "packages/desktop-client/src/components/mobile/budget/ExpenseGroupList.tsx",
+        "packages/desktop-client/src/components/modals/EditFieldModal.tsx",
         "packages/desktop-client/src/components/reports/reports/Calendar.tsx",
+        "packages/desktop-client/src/components/schedules/ScheduleLink.tsx",
+        "packages/desktop-client/src/components/ServerContext.tsx",
         "packages/desktop-client/src/components/table.tsx"
       ],
       "rules": {

AGENTS.md

@@ -169,7 +169,7 @@ Custom ESLint rules specific to Actual.
 
 - `no-untranslated-strings`: Enforces i18n usage
 - `prefer-trans-over-t`: Prefers Trans component over t() function
-- `prefer-logger-over-console`: Enforces using logger instead of console in `packages/loot-core/`
+- `prefer-logger-over-console`: Enforces using logger instead of console
 - `typography`: Typography rules
 - `prefer-if-statement`: Prefers explicit if statements
 
@@ -328,6 +328,7 @@ Always maintain newlines between import groups.
 
 **Never:**
 
+- Use `console.*` (use logger instead - enforced by ESLint)
 - Import from `uuid` without destructuring: use `import { v4 as uuidv4 } from 'uuid'`
 - Import colors directly - use theme instead
 - Import `@actual-app/web/*` in `loot-core`
@@ -540,6 +541,7 @@ Before committing changes, ensure:
 - [ ] `yarn typecheck` passes
 - [ ] `yarn lint:fix` has been run
 - [ ] Relevant tests pass
+- [ ] No new console.\* usage (use logger)
 - [ ] User-facing strings are translated
 - [ ] Prefer `type` over `interface`
 - [ ] Named exports used (not default exports)

bin/release-note-generator.ts

@@ -160,8 +160,7 @@ category: ${type}
 authors: [${username}]
 ---
 
-${summary}
-`;
+${summary}`;
 }
 
 // simple exec that fails silently and returns an empty string on failure

bin/run-browser-tests

@@ -1,29 +0,0 @@
-#!/bin/sh
-
-# Run browser tests (vitest browser mode) in Docker for consistent screenshot quality
-# Browser tests generate screenshots that vary by environment (fonts, rendering, etc.)
-# Running in Docker ensures consistent results across different machines
-#
-# Usage:
-#   yarn test:browser                          # Run all browser tests
-#   yarn test:browser AuthSettings.browser     # Run specific test file
-#   yarn test:browser --update                 # Update snapshots
-
-if [ ! -d "node_modules" ] || [ "$(ls -A node_modules)" = "" ]; then
-    yarn
-fi
-
-TEST_ARGS=""
-
-# Loop through all arguments
-while [ $# -gt 0 ]; do
-    TEST_ARGS="$TEST_ARGS $1"
-    shift
-done
-
-echo "Running browser tests in Docker for consistent screenshot quality..."
-echo "Test args: $TEST_ARGS"
-echo ""
-
-MSYS_NO_PATHCONV=1 docker run --rm --network host -v "$(pwd)":/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.57.0-jammy /bin/bash \
-  -c "yarn workspace @actual-app/web test --project=browser $TEST_ARGS"

bin/run-vrt

@@ -28,5 +28,5 @@ echo "Running VRT tests with the following parameters:"
 echo "E2E_START_URL: $E2E_START_URL"
 echo "VRT_ARGS: $VRT_ARGS"
 
-MSYS_NO_PATHCONV=1 docker run --rm --network host -v "$(pwd)":/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.57.0-jammy /bin/bash \
+MSYS_NO_PATHCONV=1 docker run --rm --network host -v "$(pwd)":/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash \
   -c "E2E_START_URL=$E2E_START_URL yarn vrt $VRT_ARGS"

package.json

@@ -44,7 +44,6 @@
     "generate:i18n": "yarn workspace @actual-app/web generate:i18n",
     "generate:release-notes": "ts-node ./bin/release-note-generator.ts",
     "test": "lage test --continue",
-    "test:browser": "./bin/run-browser-tests",
     "test:debug": "lage test --no-cache --continue",
     "e2e": "yarn workspace @actual-app/web run e2e",
     "e2e:desktop": "yarn build:desktop --skip-exe-build --skip-translations && yarn workspace desktop-electron e2e",
@@ -62,7 +61,7 @@
   },
   "devDependencies": {
     "@octokit/rest": "^22.0.1",
-    "@types/node": "^22.19.3",
+    "@types/node": "^22.19.1",
     "@types/prompts": "^2.4.9",
     "cross-env": "^10.1.0",
     "eslint": "^9.39.2",
@@ -76,7 +75,7 @@
     "node-jq": "^6.3.1",
     "npm-run-all": "^4.1.5",
     "oxfmt": "^0.22.0",
-    "oxlint": "^1.38.0",
+    "oxlint": "^1.37.0",
     "p-limit": "^7.2.0",
     "prompts": "^2.4.2",
     "source-map-support": "^0.5.21",

packages/api/index.ts

@@ -6,7 +6,6 @@ import type {
 // loot-core types
 import type { InitConfig } from 'loot-core/server/main';
 
-// oxlint-disable-next-line typescript/ban-ts-comment
 // @ts-ignore: bundle not available until we build it
 import * as bundle from './app/bundle.api.js';
 import * as injected from './injected';

packages/api/package.json

@@ -21,7 +21,7 @@
   },
   "dependencies": {
     "@actual-app/crdt": "workspace:^",
-    "better-sqlite3": "^12.5.0",
+    "better-sqlite3": "^12.4.1",
     "compare-versions": "^6.1.1",
     "node-fetch": "^3.3.2",
     "uuid": "^13.0.0"
@@ -29,7 +29,7 @@
   "devDependencies": {
     "tsc-alias": "^1.8.16",
     "typescript": "^5.9.3",
-    "vitest": "^4.0.16"
+    "vitest": "^4.0.9"
   },
   "engines": {
     "node": ">=20"

packages/api/utils.ts

@@ -1,4 +1,3 @@
-// oxlint-disable-next-line typescript/ban-ts-comment
 // @ts-ignore: bundle not available until we build it
 import * as bundle from './app/bundle.api.js';
 

packages/ci-actions/package.json

@@ -6,6 +6,6 @@
     "test": "vitest --run"
   },
   "devDependencies": {
-    "vitest": "^4.0.16"
+    "vitest": "^4.0.9"
   }
 }

packages/component-library/package.json

@@ -14,6 +14,7 @@
     "./block": "./src/Block.tsx",
     "./button": "./src/Button.tsx",
     "./card": "./src/Card.tsx",
+    "./combo-box": "./src/ComboBox.tsx",
     "./form-error": "./src/FormError.tsx",
     "./initial-focus": "./src/InitialFocus.ts",
     "./inline-field": "./src/InlineField.tsx",
@@ -41,7 +42,7 @@
   },
   "dependencies": {
     "@emotion/css": "^11.13.5",
-    "react-aria-components": "^1.14.0",
+    "react-aria-components": "^1.13.0",
     "usehooks-ts": "^3.1.1"
   },
   "devDependencies": {
@@ -49,7 +50,7 @@
     "@types/react": "^19.2.5",
     "react": "19.2.0",
     "react-dom": "19.2.0",
-    "vitest": "^4.0.16"
+    "vitest": "^4.0.9"
   },
   "peerDependencies": {
     "react": ">=18.2",

packages/component-library/src/ComboBox.tsx

@@ -0,0 +1,198 @@
+import {
+  type ComponentProps,
+  useRef,
+  useContext,
+  type KeyboardEvent,
+  useEffect,
+  createContext,
+  type ReactNode,
+} from 'react';
+import {
+  ComboBox as AriaComboBox,
+  ListBox,
+  ListBoxItem,
+  ListBoxSection,
+  type ListBoxSectionProps,
+  type ComboBoxProps as AriaComboBoxProps,
+  type ListBoxItemProps,
+  ComboBoxStateContext as AriaComboBoxStateContext,
+  type Key,
+} from 'react-aria-components';
+import { type ComboBoxState as AriaComboBoxState } from 'react-stately';
+
+import { css, cx } from '@emotion/css';
+
+import { Input } from './Input';
+import { Popover } from './Popover';
+import { styles } from './styles';
+import { theme } from './theme';
+import { View } from './View';
+
+const popoverClassName = () =>
+  css({
+    ...styles.darkScrollbar,
+    ...styles.popover,
+    backgroundColor: theme.menuAutoCompleteBackground,
+    color: theme.menuAutoCompleteText,
+    padding: '5px 0',
+    borderRadius: 4,
+  });
+
+const listBoxClassName = ({ width }: { width?: number }) =>
+  css({
+    width,
+    minWidth: 200,
+    maxHeight: 200,
+    overflow: 'auto',
+    '& [data-focused]': {
+      backgroundColor: theme.menuAutoCompleteBackgroundHover,
+    },
+  });
+
+type ComboBoxProps<T extends object> = Omit<
+  AriaComboBoxProps<T>,
+  'children'
+> & {
+  inputPlaceholder?: string;
+  children: ComponentProps<typeof ListBox<T>>['children'];
+};
+
+export function ComboBox<T extends object>({
+  children,
+  ...props
+}: ComboBoxProps<T>) {
+  const viewRef = useRef<HTMLDivElement | null>(null);
+  return (
+    <AriaComboBox<T>
+      allowsEmptyCollection
+      allowsCustomValue
+      menuTrigger="focus"
+      {...props}
+    >
+      <View ref={viewRef}>
+        <ComboBoxInput placeholder={props.inputPlaceholder} />
+      </View>
+      <Popover isNonModal className={popoverClassName()}>
+        <ListBox<T>
+          className={listBoxClassName({ width: viewRef.current?.clientWidth })}
+        >
+          {children}
+        </ListBox>
+      </Popover>
+    </AriaComboBox>
+  );
+}
+
+type ComboBoxInputContextValue = {
+  getFocusedKey?: (state: AriaComboBoxState<unknown>) => Key | null;
+};
+
+const ComboBoxInputContext = createContext<ComboBoxInputContextValue | null>(
+  null,
+);
+
+type ComboBoxInputProviderProps = {
+  children: ReactNode;
+  getFocusedKey?: (state: AriaComboBoxState<unknown>) => Key | null;
+};
+
+export function ComboBoxInputProvider({
+  children,
+  getFocusedKey,
+}: ComboBoxInputProviderProps) {
+  return (
+    <ComboBoxInputContext.Provider value={{ getFocusedKey }}>
+      {children}
+    </ComboBoxInputContext.Provider>
+  );
+}
+
+type ComboBoxInputProps = ComponentProps<typeof Input>;
+
+function ComboBoxInput({ onKeyUp, ...props }: ComboBoxInputProps) {
+  const state = useContext(AriaComboBoxStateContext);
+  const _onKeyUp = (e: KeyboardEvent<HTMLInputElement>) => {
+    if (e.key === 'Escape') {
+      state?.revert();
+    }
+    onKeyUp?.(e);
+  };
+
+  const comboBoxInputContext = useContext(ComboBoxInputContext);
+
+  useEffect(() => {
+    if (state && state.inputValue && !state.selectionManager.focusedKey) {
+      const focusedKey: Key | null =
+        (comboBoxInputContext?.getFocusedKey
+          ? comboBoxInputContext.getFocusedKey(state)
+          : defaultGetFocusedKey(state)) ?? null;
+
+      state.selectionManager.setFocusedKey(focusedKey);
+    }
+  }, [comboBoxInputContext, state, state?.inputValue]);
+
+  return <Input onKeyUp={_onKeyUp} {...props} />;
+}
+
+function defaultGetFocusedKey<T>(state: AriaComboBoxState<T>) {
+  // Focus on the first suggestion item when typing.
+  const keys = Array.from(state.collection.getKeys());
+  return (
+    keys
+      .map(key => state.collection.getItem(key))
+      .find(i => i && i.type === 'item')?.key ?? null
+  );
+}
+
+const defaultComboBoxSectionClassName = () =>
+  css({
+    display: 'flex',
+    flexDirection: 'column',
+    justifyContent: 'center',
+    '& header': {
+      paddingTop: 5,
+      paddingBottom: 5,
+      paddingLeft: 10,
+      color: theme.menuAutoCompleteTextHeader,
+    },
+  });
+
+type ComboBoxSectionProps<T extends object> = ListBoxSectionProps<T>;
+
+export function ComboBoxSection<T extends object>({
+  className,
+  ...props
+}: ComboBoxSectionProps<T>) {
+  return (
+    <ListBoxSection
+      className={cx(defaultComboBoxSectionClassName(), className)}
+      {...props}
+    />
+  );
+}
+
+const defaultComboBoxItemClassName = () =>
+  css({
+    display: 'flex',
+    flexDirection: 'row',
+    alignItems: 'center',
+    paddingTop: 5,
+    paddingBottom: 5,
+    paddingLeft: 20,
+  });
+
+type ComboBoxItemProps = ListBoxItemProps;
+
+export function ComboBoxItem({ className, ...props }: ComboBoxItemProps) {
+  return (
+    <ListBoxItem
+      className={
+        typeof className === 'function'
+          ? renderProps =>
+              cx(defaultComboBoxItemClassName(), className(renderProps))
+          : cx(defaultComboBoxItemClassName(), className)
+      }
+      {...props}
+    />
+  );
+}

packages/component-library/src/styles.ts

@@ -91,10 +91,7 @@ export const styles: Record<string, any> = {
   },
   shadowLarge,
   tnum: {
-    // tnum: Tabular numbers
-    // ss01: Open digits
-    // ss04: Disambiguation w/o zero
-    fontFeatureSettings: '"tnum", "ss01", "ss04"',
+    fontFeatureSettings: '"tnum"',
   },
   notFixed: { fontFeatureSettings: '' },
   text: {

packages/crdt/package.json

@@ -24,6 +24,6 @@
     "protoc-gen-js": "3.21.4-4",
     "ts-protoc-gen": "0.15.0",
     "typescript": "^5.9.3",
-    "vitest": "^4.0.16"
+    "vitest": "^4.0.9"
   }
 }

packages/desktop-client/.gitignore

@@ -8,7 +8,6 @@ coverage
 test-results
 playwright-report
 blob-report
-.vitest-attachments/
 
 # production
 build

packages/desktop-client/README.md

@@ -65,10 +65,10 @@ Run manually:
 
 ```sh
 # Run docker container
-docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.57.0-jammy /bin/bash
+docker run --rm --network host -v $(pwd):/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash
 
     # If you receive an error such as "docker: invalid reference format", please instead use the following command:
-    docker run --rm --network host -v ${pwd}:/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.57.0-jammy /bin/bash
+    docker run --rm --network host -v ${pwd}:/work/ -w /work/ -it mcr.microsoft.com/playwright:v1.56.0-jammy /bin/bash
 
 # Once inside the docker container, run the VRT tests: important - they MUST be ran against a HTTPS server.
 # Use the ip and port noted earlier
@@ -96,48 +96,3 @@ Run locally:
 ```sh
 E2E_START_URL=https://my-remote-server.com yarn vrt
 ```
-
-## Browser Tests (Vitest Browser Mode)
-
-Browser tests (`.browser.test.tsx` files) use Vitest's browser mode to test React components with visual regression screenshots. These tests generate screenshots that can vary significantly by environment (fonts, rendering, DPI, etc.).
-
-**IMPORTANT: For consistent screenshot quality, always run browser tests in Docker.**
-
-### Running Browser Tests in Docker
-
-From the project root:
-
-```sh
-# Run all browser tests
-yarn test:browser:docker
-
-# Run a specific browser test file
-yarn test:browser:docker AuthSettings.browser
-
-# Run with update flag to update snapshots
-yarn test:browser:docker AuthSettings.browser --update
-```
-
-From the `packages/desktop-client` directory:
-
-```sh
-# Run all browser tests
-yarn test:browser:docker
-
-# Run a specific browser test file
-yarn test:browser:docker AuthSettings.browser
-
-# Run with update flag
-yarn test:browser:docker AuthSettings.browser --update
-```
-
-### Why Docker?
-
-Running browser tests locally will produce inconsistent screenshots due to:
-
-- System-specific font rendering
-- Different DPI/display scaling
-- OS-specific rendering differences
-- Font availability variations
-
-Docker ensures all tests run in the same standardized environment (`mcr.microsoft.com/playwright:v1.56.0-jammy`), producing consistent, reproducible screenshots.