github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-28 01:58:40 -05:00
Code Issues 1.3k Packages Projects Releases 54 Wiki Activity

🐛 fix 'delete budget' button always deleting cloud file (#2251)

Browse Source 
Closes #2216
This commit is contained in:
Matiss Janis Aboltins
2024-01-19 20:04:00 +00:00
committed by GitHub
parent 06cf65497f
commit fbb1a9647d
2 changed files with 23 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

30
packages/desktop-client/src/components/manager/DeleteFile.tsx
View File

@@ -26,17 +26,6 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {
null,
);
async function onDelete() {
setLoadingState(isCloudFile ? 'cloud' : 'local');
await actions.deleteBudget(
'id' in file ? file.id : undefined,
isCloudFile ? file.cloudFileId : undefined,
);
setLoadingState(null);
modalProps.onBack();
}
return (
<Modal
{...modalProps}
@@ -75,7 +64,16 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {
padding: '10px 30px',
fontSize: 14,
}}
onClick={onDelete}
onClick={async () => {
setLoadingState('cloud');
await actions.deleteBudget(
'id' in file ? file.id : undefined,
file.cloudFileId,
);
setLoadingState(null);
modalProps.onBack();
}}
>
Delete file from all devices
</ButtonWithLoading>
@@ -125,7 +123,13 @@ export function DeleteFile({ modalProps, actions, file }: DeleteFileProps) {
backgroundColor: theme.errorText,
}),
}}
onClick={onDelete}
onClick={async () => {
setLoadingState('local');
await actions.deleteBudget(file.id);
setLoadingState(null);
modalProps.onBack();
}}
>
Delete file locally
</ButtonWithLoading>

6
upcoming-release-notes/2251.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [MatissJanis]
---
Fix 'delete file' button always deleting the cloud file.