fix split transaction button on desktop (#6269)

* fix split transaction button on desktop

* note

packages/desktop-client/src/components/autocomplete/CategoryAutocomplete.tsx

@@ -136,12 +136,20 @@ function CategoryList({
         }}
       >
         {splitTransaction &&
-          renderSplitTransactionButton({
-            key: 'split',
-            ...(getItemProps ? getItemProps({ item: splitTransaction }) : {}),
-            highlighted: splitTransaction.highlightedIndex === highlightedIndex,
-            embedded,
-          })}
+          (() => {
+            const splitButtonProps = getItemProps
+              ? getItemProps({ item: splitTransaction })
+              : {};
+            const { onClick, ...restSplitButtonProps } = splitButtonProps;
+            return renderSplitTransactionButton({
+              key: 'split',
+              ...restSplitButtonProps,
+              onClick,
+              highlighted:
+                splitTransaction.highlightedIndex === highlightedIndex,
+              embedded,
+            });
+          })()}
         {groupedCategories.map(({ group, categories }) => {
           if (!group) {
             return null;
@@ -334,7 +342,7 @@ function defaultRenderCategoryItemGroupHeader(
   return <ItemHeader {...props} type="category" />;
 }
 
-type SplitTransactionButtonProps = {
+type SplitTransactionButtonProps = ComponentPropsWithoutRef<typeof View> & {
   Icon?: ComponentType<SVGProps<SVGElement>>;
   highlighted?: boolean;
   embedded?: boolean;

upcoming-release-notes/6269.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [matt-fidd]
+---
+
+Fix split transaction button on desktop