github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 20:44:32 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Improve fix: prevent split transaction processing duplicates at source

Browse Source 
- Track processed splits to avoid duplicate updates when multiple members are selected
- Remove deduplication workaround in favor of preventing duplicates at source
- Add helper to find split parent ID
- More robust solution that prevents the accumulation issue entirely

Co-authored-by: MatissJanis <886567+MatissJanis@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-02-04 13:13:59 +00:00
parent fcf42bef63
commit dfb6612333
1 changed files with 32 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

47
packages/desktop-client/src/hooks/useTransactionBatchActions.ts
View File

@@ -106,6 +106,27 @@ export function useTransactionBatchActions() {
}
const idSet = new Set(ids);
// Track which split transactions have been processed to avoid
// processing the same split multiple times when multiple members are selected
const processedSplits = new Set<string>();
// Helper to find the parent ID of a split transaction
const findSplitParentId = (trans: TransactionEntity): string => {
if (trans.is_parent) {
return trans.id;
}
if (trans.is_child) {
// Find the parent in the transactions list
const idx = transactionsToChange.findIndex(t => t.id === trans.id);
for (let i = idx - 1; i >= 0; i--) {
const t = transactionsToChange[i];
if (t.is_parent) {
return t.id;
}
}
}
return trans.id; // Non-split transaction
};
transactionsToChange.forEach(trans => {
if (name === 'cleared' && trans.reconciled) {
@@ -120,6 +141,16 @@ export function useTransactionBatchActions() {
return;
}
// For split transactions, skip if we've already processed this split
// to avoid duplicate updates when multiple members are selected
if (trans.is_parent || trans.is_child) {
const splitParentId = findSplitParentId(trans);
if (processedSplits.has(splitParentId)) {
return;
}
processedSplits.add(splitParentId);
}
let valueToSet = value;
if (name === 'notes') {
@@ -175,21 +206,7 @@ export function useTransactionBatchActions() {
: diff.added;
});
// Deduplicate changes by ID to prevent duplicate updates when
// multiple members of a split transaction are selected
const deduplicatedChanges: Diff<TransactionEntity> = {
added: Array.from(
new Map(changes.added?.map(item => [item.id, item])).values(),
),
updated: Array.from(
new Map(changes.updated?.map(item => [item.id, item])).values(),
),
deleted: Array.from(
new Map(changes.deleted?.map(item => [item.id, item])).values(),
),
};
await send('transactions-batch-update', deduplicatedChanges);
await send('transactions-batch-update', changes);
onSuccess?.(ids, name, value, mode);
};