github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-09 03:32:54 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

[Bug] Goals: Fix schedules 'in between' calculation (#1753)

Browse Source 
* fix in between calculation

* release note
This commit is contained in:
shall0pass
2023-10-06 17:11:52 -05:00
committed by GitHub
parent 0ea7f1852b
commit d3ab8f9812
2 changed files with 13 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
packages/loot-core/src/server/budget/goaltemplates.ts
View File

@@ -645,7 +645,12 @@ async function applyCategoryTemplate(
let conditions = rule.serialize().conditions;
let { date: dateConditions, amount: amountCondition } =
extractScheduleConds(conditions);
let target = -amountCondition.value;
let target =
amountCondition.op === 'isbetween'
? -Math.round(
amountCondition.value.num1 + amountCondition.value.num2,
) / 2
: -amountCondition.value;
let next_date_string = getNextDate(
dateConditions,
monthUtils._parse(current_month),
@@ -682,7 +687,7 @@ async function applyCategoryTemplate(
monthUtils._parse(current_month),
);
while (next_date < next_month) {
monthlyTarget += amountCondition.value;
monthlyTarget += -target;
next_date = monthUtils.addDays(next_date, 1);
next_date = getNextDate(
dateConditions,

6
upcoming-release-notes/1753.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [shall0pass]
---
Goals - Fix schedules 'in between' calculation