fix(#2495): fix GoCardless transaction ID to fallback to it's own generated ID on sync (#4241)

* fix(#2495): fixed gocardless import ID

* chore: added release note

* chore: updated release note

* refactor: made condition more clear

* Revert "refactor: made condition more clear"

This reverts commit ec16c99041.

* fix: added edge case

packages/loot-core/src/server/accounts/sync.ts

@@ -351,6 +351,12 @@ async function normalizeBankSyncTransactions(transactions, acctId) {
 
     trans.cleared = Boolean(trans.booked);
 
+    let imported_id = trans.transactionId;
+
+    if (trans.cleared && !trans.transactionId && trans.internalTransactionId) {
+      imported_id = `${trans.account}-${trans.internalTransactionId}`;
+    }
+
     const notes =
       trans.remittanceInformationUnstructured ||
       (trans.remittanceInformationUnstructuredArray || []).join(', ');
@@ -364,7 +370,7 @@ async function normalizeBankSyncTransactions(transactions, acctId) {
         date: trans.date,
         notes: notes.trim().replace('#', '##'),
         category: trans.category ?? null,
-        imported_id: trans.transactionId,
+        imported_id,
         imported_payee: trans.imported_payee,
         cleared: trans.cleared,
       },

upcoming-release-notes/4241.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [NullScope]
+---
+
+Fix GoCardless transaction ID to fallback to it's own generated ID on sync