github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 20:44:32 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

Add a new number format (space-dot) (#995)

Browse Source
This commit is contained in:
TheTrueCaligari
2023-05-05 16:26:35 +02:00
committed by GitHub
parent f913d99c9f
commit acaff825c1
3 changed files with 23 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
packages/loot-core/src/shared/util.test.ts
View File

@@ -64,4 +64,15 @@ describe('utility functions', () => {
formatter = getNumberFormat().formatter;
expect(formatter.format(Number('1234.56'))).toBe('1\xa0235');
});
test('number formatting works with space-dot format', () => {
setNumberFormat({ format: 'space-dot', hideFraction: false });
let formatter = getNumberFormat().formatter;
// grouping separator space char is a non-breaking space, or UTF-16 \xa0
expect(formatter.format(Number('1234.56'))).toBe('1\xa0234.56');
setNumberFormat({ format: 'space-dot', hideFraction: true });
formatter = getNumberFormat().formatter;
expect(formatter.format(Number('1234.56'))).toBe('1\xa0235');
});
});

6
packages/loot-core/src/shared/util.ts
View File

@@ -252,6 +252,7 @@ export let numberFormats = [
{ value: 'comma-dot', label: '1,000.33', labelNoFraction: '1,000' },
{ value: 'dot-comma', label: '1.000,33', labelNoFraction: '1.000' },
{ value: 'space-comma', label: '1 000,33', labelNoFraction: '1 000' },
{ value: 'space-dot', label: '1 000.33', labelNoFraction: '1 000' },
];
let numberFormat: {
@@ -279,6 +280,11 @@ export function setNumberFormat({ format, hideFraction }) {
regex = /[^-0-9,]/g;
separator = ',';
break;
case 'space-dot':
locale = 'dje';
regex = /[^-0-9,]/g;
separator = '.';
break;
case 'comma-dot':
default:
locale = 'en-US';

6
upcoming-release-notes/995.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Enhancements
authors: [TheTrueCaligari]
---
Number Format: Add a new option (space-dot) e.g. "1 234.56"