github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-04-28 18:40:34 -05:00
Code Issues 1.3k Packages Projects Releases 54 Wiki Activity

Add GoCardless banks to the bank factory test suite. (#367)

Browse Source
This commit is contained in:
Robert Dyer
2024-06-05 11:33:23 -05:00
committed by GitHub
parent 55724acafa
commit aa22e6951d
3 changed files with 16 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/app-gocardless/bank-factory.js
View File

@@ -15,7 +15,7 @@ import SparNordSpNoDK22 from './banks/sparnord-spnodk22.js';
import SpkMarburgBiedenkopfHeladef1mar from './banks/spk-marburg-biedenkopf-heladef1mar.js';
import SpkKarlsruhekarsde66 from './banks/spk-karlsruhe-karsde66.js';
const banks = [
export const banks = [
AmericanExpressAesudef1,
BankinterBkbkesmm,
Belfius,

48
src/app-gocardless/tests/bank-factory.spec.js
View File

@@ -1,50 +1,20 @@
import BankFactory from '../bank-factory.js';
import MbankRetailBrexplpw from '../banks/mbank-retail-brexplpw.js';
import SandboxfinanceSfin0000 from '../banks/sandboxfinance-sfin0000.js';
import IngPlIngbplpw from '../banks/ing-pl-ingbplpw.js';
import { banks } from '../bank-factory.js';
import IntegrationBank from '../banks/integration-bank.js';
import Belfius from '../banks/belfius_gkccbebb.js';
import SpkMarburgBiedenkopfHeladef1mar from '../banks/spk-marburg-biedenkopf-heladef1mar.js';
describe('BankFactory', () => {
it('should return MbankRetailBrexplpw when institutionId is mbank-retail-brexplpw', () => {
const institutionId = MbankRetailBrexplpw.institutionIds[0];
const result = BankFactory(institutionId);
it.each(banks.flatMap((bank) => bank.institutionIds))(
`should return same institutionId`,
(institutionId) => {
const result = BankFactory(institutionId);
expect(result.institutionIds).toContain(institutionId);
});
it('should return SandboxfinanceSfin0000 when institutionId is sandboxfinance-sfin0000', () => {
const institutionId = SandboxfinanceSfin0000.institutionIds[0];
const result = BankFactory(institutionId);
expect(result.institutionIds).toContain(institutionId);
});
it('should return IngPlIngbplpw when institutionId is ing-pl-ingbplpw', () => {
const institutionId = IngPlIngbplpw.institutionIds[0];
const result = BankFactory(institutionId);
expect(result.institutionIds).toContain(institutionId);
});
it('should return SpkMarburgBiedenkopfHeladef1mar when institutionId is SPK_MARBURG_BIEDENKOPF_HELADEF1MAR', () => {
const institutionId = SpkMarburgBiedenkopfHeladef1mar.institutionIds[0];
const result = BankFactory(institutionId);
expect(result.institutionIds).toContain(institutionId);
});
it('should return Belfius when institutionId is BELFIUS_GKCCBEBB', () => {
const institutionId = Belfius.institutionIds[0];
const result = BankFactory(institutionId);
expect(result.institutionIds).toContain(institutionId);
});
expect(result.institutionIds).toContain(institutionId);
},
);
it('should return IntegrationBank when institutionId is not found', () => {
const institutionId = IntegrationBank.institutionIds[0];
const result = BankFactory(institutionId);
const result = BankFactory('fake-id-not-found');
expect(result.institutionIds).toContain(institutionId);
});

6
upcoming-release-notes/367.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [psybers]
---
Add GoCardless banks to the bank factory test suite.