feat: fix categories being set on offbudget transactions (#3705)

* chore: release note

* feat: fix categories being set on offbudget transactions

* fix: #2266

* fix: small mistake

* chore: update comment

packages/loot-core/src/server/accounts/transactions.ts

@@ -77,7 +77,13 @@ export async function batchUpdateTransactions({
   await batchMessages(async () => {
     if (added) {
       addedIds = await Promise.all(
-        added.map(async t => db.insertTransaction(t)),
+        added.map(async t => {
+          const account = accounts.find(acct => acct.id === t.account);
+          if (account.offbudget === 1) {
+            t.category = null;
+          }
+          return db.insertTransaction(t);
+        }),
       );
     }
 

packages/loot-core/src/server/accounts/transfer.ts

@@ -26,11 +26,16 @@ async function clearCategory(transaction, transferAcct) {
     [transferAcct],
   );
 
-  // We should clear the category to make sure it's not being
-  // accounted for in the budget, unless it should be in the case of
-  // transferring from an on-budget to off-budget account
+  // If the transfer is between two on-budget or two off-budget accounts,
+  // we should clear the category, because the category is not relevant
   if (fromOffBudget === toOffBudget) {
     await db.updateTransaction({ id: transaction.id, category: null });
+    if (transaction.transfer_id) {
+      await db.updateTransaction({
+        id: transaction.transfer_id,
+        category: null,
+      });
+    }
     return true;
   }
   return false;

upcoming-release-notes/3705.md

@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [UnderKoen]
+---
+
+Fix category being set on off-budget accounts