mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-11 20:44:32 -05:00
🐛 (autocomplete) fix multi-select (#947)
This commit is contained in:
committed by
GitHub
parent
6325a36847
commit
89c065e401
@@ -126,6 +126,7 @@ function SingleAutocomplete({
|
||||
onSelect,
|
||||
tableBehavior,
|
||||
value: initialValue,
|
||||
isMulti = false,
|
||||
}) {
|
||||
const [selectedItem, setSelectedItem] = useState(() =>
|
||||
findItem(strict, suggestions, initialValue),
|
||||
@@ -174,7 +175,12 @@ function SingleAutocomplete({
|
||||
onSelect={(item, { inputValue }) => {
|
||||
setSelectedItem(item);
|
||||
setHighlightedIndex(null);
|
||||
setIsOpen(false);
|
||||
|
||||
if (isMulti) {
|
||||
setValue('');
|
||||
} else {
|
||||
setIsOpen(false);
|
||||
}
|
||||
|
||||
if (onSelect) {
|
||||
// I AM NOT PROUD OF THIS OK??
|
||||
@@ -267,9 +273,6 @@ function SingleAutocomplete({
|
||||
) {
|
||||
setHighlightedIndex(changes.highlightedIndex);
|
||||
}
|
||||
if ('isOpen' in changes) {
|
||||
setIsOpen(embedded ? true : changes.isOpen);
|
||||
}
|
||||
if ('selectedItem' in changes) {
|
||||
setSelectedItem(changes.selectedItem);
|
||||
}
|
||||
@@ -506,6 +509,7 @@ export function MultiAutocomplete({
|
||||
return (
|
||||
<Autocomplete
|
||||
{...props}
|
||||
isMulti
|
||||
value={null}
|
||||
suggestions={suggestions.filter(
|
||||
item => !selectedItems.includes(getItemId(item)),
|
||||
|
||||
6
upcoming-release-notes/947.md
Normal file
6
upcoming-release-notes/947.md
Normal file
@@ -0,0 +1,6 @@
|
||||
---
|
||||
category: Bugfix
|
||||
authors: [MatissJanis]
|
||||
---
|
||||
|
||||
Autocomplete: fix multi-autocomplete filtering UX
|
||||
Reference in New Issue
Block a user