github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-03-11 20:44:32 -05:00
Code Issues 250 Packages Projects Releases 53 Wiki Activity

:electron: Improve metainfo validation for flathub (#6593)

Browse Source 
* manifest validation for flathub

* install builder separately

* confirmed working, now removing validation errors

* updates to metainfo with new validation fixes

* release notes
This commit is contained in:
Michael Clark
2026-01-08 09:15:02 +00:00
committed by GitHub
parent 771e5072cb
commit 4b8feb1dfc
5 changed files with 17 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
.github/workflows/electron-master.yml vendored
View File

@@ -52,14 +52,13 @@ jobs:
sudo flatpak install org.freedesktop.Sdk//24.08 -y
sudo flatpak install org.freedesktop.Platform//24.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp//24.08 -y
sudo flatpak install org.flatpak.Builder -y
METAINFO_FILE="packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml"
TODAY=$(date +%Y-%m-%d)
VERSION=${{ steps.process_version.outputs.version }}
sed -i "s/%RELEASE_VERSION%/$VERSION/g; s/%RELEASE_DATE%/$TODAY/g" "$METAINFO_FILE"
sudo apt-get install appstream
appstreamcli --version
appstreamcli validate "$METAINFO_FILE"
flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream "$METAINFO_FILE"
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Electron for Mac

5
.github/workflows/electron-pr.yml vendored
View File

@@ -52,14 +52,13 @@ jobs:
sudo flatpak install org.freedesktop.Sdk//24.08 -y
sudo flatpak install org.freedesktop.Platform//24.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp//24.08 -y
sudo flatpak install org.flatpak.Builder -y
METAINFO_FILE="packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml"
TODAY=$(date +%Y-%m-%d)
VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/desktop-electron/package.json --type nightly)
sed -i "s/%RELEASE_VERSION%/$VERSION/g; s/%RELEASE_DATE%/$TODAY/g" "$METAINFO_FILE"
sudo apt-get install appstream
appstreamcli --version
appstreamcli validate "$METAINFO_FILE"
flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream "$METAINFO_FILE"
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Electron

5
.github/workflows/publish-nightly-electron.yml vendored
View File

@@ -49,14 +49,13 @@ jobs:
sudo flatpak install org.freedesktop.Sdk//24.08 -y
sudo flatpak install org.freedesktop.Platform//24.08 -y
sudo flatpak install org.electronjs.Electron2.BaseApp//24.08 -y
sudo flatpak install org.flatpak.Builder -y
METAINFO_FILE="packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml"
TODAY=$(date +%Y-%m-%d)
VERSION=$(node ./packages/ci-actions/bin/get-next-package-version.js --package-json ./packages/desktop-electron/package.json --type nightly)
sed -i "s/%RELEASE_VERSION%/$VERSION/g; s/%RELEASE_DATE%/$TODAY/g" "$METAINFO_FILE"
sudo apt-get install appstream
appstreamcli --version
appstreamcli validate "$METAINFO_FILE"
flatpak run --command=flatpak-builder-lint org.flatpak.Builder appstream "$METAINFO_FILE"
- name: Set up environment
uses: ./.github/actions/setup

6
packages/desktop-electron/extra-resources/linux/com.actualbudget.actual.metainfo.xml
View File

@@ -21,6 +21,7 @@
<launchable type="desktop-id">com.actualbudget.actual.desktop</launchable>
<url type="homepage">https://actualbudget.org/</url>
<url type="bugtracker">https://github.com/actualbudget/actual/issues</url>
<url type="vcs-browser">https://github.com/actualbudget/actual</url>
<recommends>
<control>keyboard</control>
<control>pointing</control>
@@ -68,6 +69,9 @@
</description>
</release>
</releases>
<developer_name>Actual Core Contributors</developer_name>
<developer id="com.actualbudget">
<name>Actual Core Contributors</name>
</developer>
<update_contact>dev@actualbudget.org</update_contact>
</component>

6
upcoming-release-notes/6593.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MikesGlitch]
---
Switch flathub validation to flatpak-builder-lint for metainfo validations