🔥 removing privacyMode feature flag (#1688)

packages/desktop-client/src/components/PrivacyFilter.tsx

@@ -8,7 +8,6 @@ import React, {
 
 import usePrivacyMode from 'loot-core/src/client/privacy';
 
-import useFeatureFlag from '../hooks/useFeatureFlag';
 import { useResponsive } from '../ResponsiveProvider';
 
 import View from './common/View';
@@ -53,7 +52,6 @@ export default function PrivacyFilter({
   children,
   ...props
 }: PrivacyFilterProps) {
-  let privacyModeFeatureFlag = useFeatureFlag('privacyMode');
   let privacyMode = usePrivacyMode();
   // Limit mobile support for now.
   let { isNarrowWidth } = useResponsive();
@@ -67,7 +65,7 @@ export default function PrivacyFilter({
 
   let blurAmount = blurIntensity != null ? `${blurIntensity}px` : '3px';
 
-  return !privacyModeFeatureFlag || !activate ? (
+  return !activate ? (
     <>{Children.toArray(children)}</>
   ) : (
     <BlurredOverlay blurIntensity={blurAmount} {...props}>

packages/desktop-client/src/components/Titlebar.tsx

@@ -296,7 +296,6 @@ export default function Titlebar({ style }) {
     state => state.prefs.global.floatingSidebar,
   );
 
-  let privacyModeFeatureFlag = useFeatureFlag('privacyMode');
   let themesFlag = useFeatureFlag('themes');
 
   return isNarrowWidth ? null : (
@@ -369,7 +368,7 @@ export default function Titlebar({ style }) {
       <View style={{ flex: 1 }} />
       <UncategorizedButton />
       {themesFlag && <ThemeSelector />}
-      {privacyModeFeatureFlag && <PrivacyButton />}
+      <PrivacyButton />
       {serverURL ? <SyncButton style={{ marginLeft: 10 }} /> : null}
       <LoggedInUser style={{ marginLeft: 10 }} />
     </View>

packages/desktop-client/src/components/settings/Experimental.tsx

@@ -99,7 +99,6 @@ export default function ExperimentalFeatures() {
               Goal templates
             </FeatureToggle>
 
-            <FeatureToggle flag="privacyMode">Privacy mode</FeatureToggle>
             <FeatureToggle flag="experimentalOfxParser">
               Experimental OFX parser
             </FeatureToggle>

packages/desktop-client/src/hooks/useFeatureFlag.ts

@@ -6,7 +6,6 @@ const DEFAULT_FEATURE_FLAG_STATE: Record<FeatureFlag, boolean> = {
   categorySpendingReport: false,
   reportBudget: false,
   goalTemplatesEnabled: false,
-  privacyMode: true,
   themes: false,
   experimentalOfxParser: true,
 };

packages/loot-core/src/types/prefs.d.ts

@@ -4,7 +4,6 @@ export type FeatureFlag =
   | 'categorySpendingReport'
   | 'reportBudget'
   | 'goalTemplatesEnabled'
-  | 'privacyMode'
   | 'themes'
   | 'experimentalOfxParser';
 

upcoming-release-notes/1688.md

@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [MatissJanis]
+---
+
+Remove `privacyMode` feature flag as this feature is GA