github-starred/actual
2
0
Fork 0
mirror of https://github.com/actualbudget/actual.git synced 2026-05-10 16:26:43 -05:00
Code Issues 1.6k Packages Projects Releases 57 Wiki Activity

fix: csv parser delimiter (#1774)

Browse Source
This commit is contained in:
凯 - kǎi
2023-10-09 21:49:54 +02:00
committed by GitHub
parent efba86a72d
commit 3dfe633428
2 changed files with 16 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
packages/desktop-client/src/components/modals/ImportTransactions.js
View File

@@ -578,7 +578,7 @@ export default function ImportTransactions({ modalProps, options }) {
// options which are simple post-processing. That means if you
// parsed different files without closing the modal, it wouldn't
// re-read this.
let [csvDelimiter, setCsvDelimiter] = useState(
let [delimiter, setDelimiter] = useState(
prefs[`csv-delimiter-${accountId}`] ||
(filename.endsWith('.tsv') ? '\t' : ','),
);
@@ -666,7 +666,7 @@ export default function ImportTransactions({ modalProps, options }) {
const fileType = getFileType(options.filename);
const parseOptions = getParseOptions(
fileType,
{ csvDelimiter, hasHeaderRow },
{ delimiter, hasHeaderRow },
{ fallbackMissingPayeeToMemo },
);
@@ -716,7 +716,7 @@ export default function ImportTransactions({ modalProps, options }) {
const fileType = getFileType(res[0]);
const parseOptions = getParseOptions(
fileType,
{ csvDelimiter, hasHeaderRow },
{ delimiter, hasHeaderRow },
{ fallbackMissingPayeeToMemo },
);
@@ -787,7 +787,7 @@ export default function ImportTransactions({ modalProps, options }) {
savePrefs({
[`csv-mappings-${accountId}`]: JSON.stringify(fieldMappings),
});
savePrefs({ [`csv-delimiter-${accountId}`]: csvDelimiter });
savePrefs({ [`csv-delimiter-${accountId}`]: delimiter });
}
if (filetype === 'csv' || filetype === 'qif') {
@@ -966,11 +966,12 @@ export default function ImportTransactions({ modalProps, options }) {
options={[
[',', ','],
[';', ';'],
['|', '|'],
['\t', 'tab'],
]}
value={csvDelimiter}
value={delimiter}
onChange={value => {
setCsvDelimiter(value);
setDelimiter(value);
parse(
filename,
getParseOptions('csv', {
@@ -990,7 +991,7 @@ export default function ImportTransactions({ modalProps, options }) {
parse(
filename,
getParseOptions('csv', {
delimiter: csvDelimiter,
delimiter,
hasHeaderRow: !hasHeaderRow,
}),
);
@@ -1070,8 +1071,8 @@ export default function ImportTransactions({ modalProps, options }) {
function getParseOptions(fileType, csvOptions, ofxOptions) {
if (fileType === 'csv') {
const { csvDelimiter, hasHeaderRow } = csvOptions;
return { csvDelimiter, hasHeaderRow };
const { delimiter, hasHeaderRow } = csvOptions;
return { delimiter, hasHeaderRow };
} else if (isOfxFile(fileType)) {
const { fallbackMissingPayeeToMemo } = ofxOptions;
return { fallbackMissingPayeeToMemo };

6
upcoming-release-notes/1774.md Normal file
View File

@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [KaiBelmo]
---
Fix selecting delimiters in CSV options when uploading a CSV; it will apply to parsing. Also added a new delimiter '|'.