mirror of
https://github.com/actualbudget/actual.git
synced 2026-04-28 01:58:40 -05:00
🔥 remove unused tableNavigatorOpts code-path (#781)
Just cleaning up things: removing an unused code-path.
This commit is contained in:
committed by
GitHub
parent
ce40e61ab7
commit
2903fd0037
@@ -342,7 +342,6 @@ export const ManagePayees = React.forwardRef(
|
||||
payees,
|
||||
ruleCounts,
|
||||
categoryGroups,
|
||||
tableNavigatorOpts, // TODO: remove as it's unused
|
||||
initialSelectedIds,
|
||||
ruleActions,
|
||||
onBatchChange,
|
||||
@@ -455,18 +454,15 @@ export const ManagePayees = React.forwardRef(
|
||||
|
||||
let buttonsDisabled = selected.items.size === 0;
|
||||
|
||||
let tableNavigator = useTableNavigator(
|
||||
filteredPayees,
|
||||
item =>
|
||||
['select', 'name', 'rule-count'].filter(name => {
|
||||
switch (name) {
|
||||
case 'select':
|
||||
return item.transfer_acct == null;
|
||||
default:
|
||||
return true;
|
||||
}
|
||||
}),
|
||||
tableNavigatorOpts,
|
||||
let tableNavigator = useTableNavigator(filteredPayees, item =>
|
||||
['select', 'name', 'rule-count'].filter(name => {
|
||||
switch (name) {
|
||||
case 'select':
|
||||
return item.transfer_acct == null;
|
||||
default:
|
||||
return true;
|
||||
}
|
||||
}),
|
||||
);
|
||||
|
||||
let payeesById = getPayeesById(payees);
|
||||
|
||||
@@ -999,11 +999,10 @@ export const Table = React.forwardRef(
|
||||
},
|
||||
);
|
||||
|
||||
export function useTableNavigator(data, fields, opts = {}) {
|
||||
export function useTableNavigator(data, fields) {
|
||||
let getFields = typeof fields !== 'function' ? () => fields : fields;
|
||||
let { initialEditingId, initialFocusedField, moveKeys } = opts;
|
||||
let [editingId, setEditingId] = useState(initialEditingId || null);
|
||||
let [focusedField, setFocusedField] = useState(initialFocusedField || null);
|
||||
let [editingId, setEditingId] = useState(null);
|
||||
let [focusedField, setFocusedField] = useState(null);
|
||||
let containerRef = useRef();
|
||||
|
||||
// See `onBlur` for why we need this
|
||||
@@ -1128,47 +1127,37 @@ export function useTableNavigator(data, fields, opts = {}) {
|
||||
return;
|
||||
}
|
||||
|
||||
let fieldKeys =
|
||||
moveKeys && moveKeys[focusedField] && moveKeys[focusedField];
|
||||
switch (e.code) {
|
||||
case 'ArrowUp':
|
||||
case 'KeyK':
|
||||
if (e.target.tagName !== 'INPUT') {
|
||||
onMove('up');
|
||||
}
|
||||
break;
|
||||
|
||||
if (fieldKeys && fieldKeys[e.keyCode]) {
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
case 'ArrowDown':
|
||||
case 'KeyJ':
|
||||
if (e.target.tagName !== 'INPUT') {
|
||||
onMove('down');
|
||||
}
|
||||
break;
|
||||
|
||||
onMove(fieldKeys[e.keyCode]);
|
||||
} else {
|
||||
switch (e.code) {
|
||||
case 'ArrowUp':
|
||||
case 'KeyK':
|
||||
if (e.target.tagName !== 'INPUT') {
|
||||
onMove('up');
|
||||
}
|
||||
break;
|
||||
case 'Enter':
|
||||
case 'Tab':
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
|
||||
case 'ArrowDown':
|
||||
case 'KeyJ':
|
||||
if (e.target.tagName !== 'INPUT') {
|
||||
onMove('down');
|
||||
}
|
||||
break;
|
||||
|
||||
case 'Enter':
|
||||
case 'Tab':
|
||||
e.preventDefault();
|
||||
e.stopPropagation();
|
||||
|
||||
onMove(
|
||||
e.code === 'Enter'
|
||||
? e.shiftKey
|
||||
? 'up'
|
||||
: 'down'
|
||||
: e.shiftKey
|
||||
? 'left'
|
||||
: 'right',
|
||||
);
|
||||
break;
|
||||
default:
|
||||
}
|
||||
onMove(
|
||||
e.code === 'Enter'
|
||||
? e.shiftKey
|
||||
? 'up'
|
||||
: 'down'
|
||||
: e.shiftKey
|
||||
? 'left'
|
||||
: 'right',
|
||||
);
|
||||
break;
|
||||
default:
|
||||
}
|
||||
},
|
||||
|
||||
|
||||
6
upcoming-release-notes/781.md
Normal file
6
upcoming-release-notes/781.md
Normal file
@@ -0,0 +1,6 @@
|
||||
---
|
||||
category: Maintenance
|
||||
authors: [MatissJanis]
|
||||
---
|
||||
|
||||
Remove unused `tableNavigatorOpts` code-path
|
||||
Reference in New Issue
Block a user