Update recommended version to Node.js 18 (#1117)

After #1115, new Node.js versions will be able to be used for
development of the frontend. This PR changes the recommended Node.js
version to 18 (the current LTS version). I have also tested with 16 and
20 and it works.

I also took the opportunity to:

- move the build script that was at the project root to the `bin/`
folder
- update the `browserslist` to target Electron 24 (which is the version
we currently build against). This results in a slightly smaller bundle
due to no longer having to transpile optional chaining.

.github/actions/setup/action.yml

@@ -6,7 +6,7 @@ runs:
     - name: Install node
       uses: actions/setup-node@v3
       with:
-        node-version: 16.15.0
+        node-version: 18.16.0
     - name: Cache
       uses: actions/cache@v3
       id: cache

.nvmrc

@@ -1 +1 @@
-v16.15.0
+v18.16.0

Dockerfile

@@ -1,11 +1,11 @@
 ###################################################
-# This Dockerfile is used by the docker-compose.yml 
+# This Dockerfile is used by the docker-compose.yml
 # file to build the development container.
 # Do not make any changes here unless you know what
 # you are doing.
 ###################################################
 
-FROM node:16-bullseye as dev 
+FROM node:18-bullseye as dev
 RUN apt-get update -y && apt-get upgrade -y && apt-get install -y openssl
 WORKDIR /app
-CMD ["sh", "./docker-start.sh"]
+CMD ["sh", "./bin/docker-start"]

bin/docker-start

@@ -1,11 +1,11 @@
+#!/bin/sh
+
 #####################################################
 # This startup script is used by the docker container
 # to check if the node_modules folder is empty and
 # if so, run yarn to install the dependencies.
 #####################################################
 
-#!/bin/sh
-
 if [ ! -d "node_modules" ] || [ "$(ls -A node_modules)" = "" ]; then
     yarn
 fi

package.json

@@ -53,9 +53,12 @@
   "resolutions": {
     "react-error-overlay": "6.0.9"
   },
+  "engines": {
+    "node": ">=18.0.0"
+  },
   "packageManager": "yarn@3.5.1",
   "browserslist": [
-    "electron 12.0",
+    "electron 24.0",
     "defaults"
   ]
 }

upcoming-release-notes/1117.md

@@ -0,0 +1,6 @@
+---
+category: Maintenance
+authors: [j-f1]
+---
+
+Recommend that the frontend be developed on using Node 18, correct Electron target version