mirror of
https://github.com/actualbudget/actual.git
synced 2026-03-09 06:02:22 -05:00
Add custom checks to CodeRabbit configuration (#6592)
* Add custom checks to CodeRabbit configuration - Add settings check to evaluate new setting toggles against core design principles - Add linting check to prevent oxlint-disable lines - Add typecheck check to prevent @ts-strict-ignore in new components/utilities * Add release notes for custom checks in CodeRabbit configuration * Refactor custom checks in CodeRabbit configuration for clarity and consistency - Consolidate custom checks under a single list format for better readability - Maintain existing checks for settings, linting, and typecheck with unchanged instructions
This commit is contained in:
committed by
GitHub
parent
fd42705c75
commit
771e5072cb
@@ -11,6 +11,16 @@ reviews:
|
||||
pre_merge_checks:
|
||||
docstrings:
|
||||
enabled: false
|
||||
custom_checks:
|
||||
- mode: error
|
||||
name: 'settings'
|
||||
instructions: 'Every addition of a new setting toggle must be thoroughly evaluated against the core design principles of Actual. The settings screen is reserved for essential and foundational options only — do not introduce settings for minor UI adjustments such as sizes, paddings, colors, or margins. Prioritize preserving a simple and uncluttered user experience. Users proposing new settings must confirm in a reply to the Coderabbit comment that they have reviewed and ensured alignment with these principles. Excessive or granular UI options increase code complexity and risk confusing users, and are generally not permitted.'
|
||||
- mode: error
|
||||
name: 'linting'
|
||||
instructions: 'Do not allow any oxlint-disable lines.'
|
||||
- mode: error
|
||||
name: 'typecheck'
|
||||
instructions: 'Do not allow creating new components or utilities with the @ts-strict-ignore comment.'
|
||||
labeling_instructions:
|
||||
- label: 'suspect ai generated'
|
||||
instructions: 'This issue or PR is suspected to be generated by AI.'
|
||||
|
||||
6
upcoming-release-notes/6592.md
Normal file
6
upcoming-release-notes/6592.md
Normal file
@@ -0,0 +1,6 @@
|
||||
---
|
||||
category: Maintenance
|
||||
authors: [MatissJanis]
|
||||
---
|
||||
|
||||
Add custom checks to CodeRabbit configuration for settings evaluation, linting, and typecheck enforcement.
|
||||
Reference in New Issue
Block a user