Change Done Reconciling button text - fixes #6196 (#6220)

* Rename button text from 'Done reconciling' to 'Complete Reconciling'

* Change button text from 'Done' to 'Complete'

* Update button text in reconciliation test

* Update button text for reconciliation completion

* Modify reconciliation completion messages

Updated reconciliation messages to provide clearer instructions.

* Change button text from 'Complete Reconciliation' to 'Exit reconciling'

* Fix capitalization in 'Exit Reconciling' text

* [autofix.ci] apply automated fixes

* Update release notes for reconciliation changes

Changes wording for clarity and adds exit option.

* Update release notes with button wording changes

Changes wording for clarity and adds a new exit option.

* Update category and button wording in release notes

Changes the category from 'Changes' to 'Enhancements' and updates button wording.

* Clarify wording for reconciliation exit options

* Update test expectation for reconciled message

* Update test to check for reconciled message

* [autofix.ci] apply automated fixes

* Clean up reconciliation view text

Removed unnecessary line breaks and exit message from the reconciliation view.

* [autofix.ci] apply automated fixes

* Update reconciliation test for improved text matching

* [autofix.ci] apply automated fixes

* Update packages/desktop-client/src/components/accounts/Reconcile.tsx

Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

* [autofix.ci] apply automated fixes

* Change button click from 'Exit reconciling' to 'Lock transactions'

* Enhance release notes for reconciliation button changes

Updates authors and clarifies button wording for reconciliation.

---------

Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
Co-authored-by: Matt Fiddaman <github@m.fiddaman.uk>

packages/desktop-client/src/components/accounts/Reconcile.test.tsx

@@ -57,7 +57,7 @@ describe('ReconcilingMessage math & UI', () => {
     ).not.toBeInTheDocument();
 
     // Done button triggers callback
-    await userEvent.click(screen.getByText('Done reconciling'));
+    await userEvent.click(screen.getByText('Lock transactions'));
     expect(onDone).toHaveBeenCalledTimes(1);
   });
 

packages/desktop-client/src/components/accounts/Reconcile.tsx

@@ -105,7 +105,9 @@ export function ReconcilingMessage({
         )}
         <View style={{ marginLeft: 15 }}>
           <Button variant="primary" onPress={onDone}>
-            <Trans>Done reconciling</Trans>
+            {targetDiff === 0
+              ? t('Lock transactions')
+              : t('Exit reconciliation')}
           </Button>
         </View>
         {targetDiff !== 0 && (

upcoming-release-notes/6220.md

@@ -0,0 +1,6 @@
+---
+category: Enhancements
+authors: [Juulz, matt-fidd]
+---
+
+Changes and clarifies wording of "Done reconciling" button to "Lock transactions" when _All reconciled!_ or "Exit reconciliation if leaving unbalanced.