[PR #5] [MERGED] Fix #4 and another small bug in the dataset viewer #9

New Issue

GiteaMirror · 2026-04-10T16:03:30-05:00

GiteaMirror commented

2026-04-10 16:03:30 -05:00

📋 Pull Request Information

Original PR: https://github.com/KohakuBlueleaf/KohakuHub/pull/5
Author: @LenDigLearn
Created: 11/12/2025
Status: ✅ Merged
Merged: 11/13/2025
Merged by: @KohakuBlueleaf

Base: main ← Head: main

📝 Commits (4)

04961a8 Truncate commit ID in info endpoint to be compatible with huggingface client requirements
cb6c9cc fix loadFolder s.t. correct paths are returned for files in subfolders
b86e00a correctly display lists in markdown viewer
015d60a use single space placeholder in case a readme exists but has no content apart from frontmatter

📊 Changes

4 files changed (+13 additions, -2 deletions)

View changed files

📝 src/kohaku-hub-ui/src/components/common/MarkdownViewer.vue (+1 -0)
📝 src/kohaku-hub-ui/src/components/repo/DatasetViewerTab.vue (+10 -0)
📝 src/kohaku-hub-ui/src/components/repo/RepoViewer.vue (+1 -1)
📝 src/kohakuhub/api/repo/routers/info.py (+1 -1)

📄 Description

Pull Request

What changed?

Fixed #4 by truncating returned IDs in the info endpoint
Fixed a bug in the dataset viewer where files in subfolders could not be loaded since it was not using the full path

Why?

#4 and undocumented bug with dataset viewer where files in subfolders could not be loaded since it was not using the full path

Testing

[x ] Tested locally
[x ] Tested in Docker

Checklist

Code follows project style (see CONTRIBUTING.md)
Updated docs if needed (README, API.md, CLI.md, etc.) (I think not needed here)
No breaking changes (or documented them)
Tested my changes

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/KohakuBlueleaf/KohakuHub/pull/5 **Author:** [@LenDigLearn](https://github.com/LenDigLearn) **Created:** 11/12/2025 **Status:** ✅ Merged **Merged:** 11/13/2025 **Merged by:** [@KohakuBlueleaf](https://github.com/KohakuBlueleaf) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (4) - [`04961a8`](https://github.com/KohakuBlueleaf/KohakuHub/commit/04961a89b1628f1e5cf84443dc891499d6bdf46c) Truncate commit ID in info endpoint to be compatible with huggingface client requirements - [`cb6c9cc`](https://github.com/KohakuBlueleaf/KohakuHub/commit/cb6c9ccac13b4c7c53e568261c15e3290c70d2ef) fix loadFolder s.t. correct paths are returned for files in subfolders - [`b86e00a`](https://github.com/KohakuBlueleaf/KohakuHub/commit/b86e00a1a16f9346caa1e1429575c476c442b43e) correctly display lists in markdown viewer - [`015d60a`](https://github.com/KohakuBlueleaf/KohakuHub/commit/015d60aa2c59906e78421e765031ffbf25bde2b3) use single space placeholder in case a readme exists but has no content apart from frontmatter ### 📊 Changes **4 files changed** (+13 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/kohaku-hub-ui/src/components/common/MarkdownViewer.vue` (+1 -0) 📝 `src/kohaku-hub-ui/src/components/repo/DatasetViewerTab.vue` (+10 -0) 📝 `src/kohaku-hub-ui/src/components/repo/RepoViewer.vue` (+1 -1) 📝 `src/kohakuhub/api/repo/routers/info.py` (+1 -1) </details> ### 📄 Description # Pull Request ## What changed? - Fixed #4 by truncating returned IDs in the info endpoint - Fixed a bug in the dataset viewer where files in subfolders could not be loaded since it was not using the full path ## Why? #4 and undocumented bug with dataset viewer where files in subfolders could not be loaded since it was not using the full path ## Testing - [x ] Tested locally - [x ] Tested in Docker ## Checklist - [x] Code follows project style (see CONTRIBUTING.md) - [ ] Updated docs if needed (README, API.md, CLI.md, etc.) (I think not needed here) - [x] No breaking changes (or documented them) - [x] Tested my changes --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-10 16:03:30 -05:00

GiteaMirror closed this issue

2026-04-10 16:03:31 -05:00

GiteaMirror referenced this issue

2026-04-10 16:03:37 -05:00

[PR #9] [MERGED] chore(json-schema-generator): `generate_json_schema.py` script helpful for generating schemas for pydantic models #11

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/KohakuHub#9