ComputerSurge/vikunja
3
0
Fork 0
Code Issues 1 Pull Requests 10 Activity

feat: use withDefaults in Description (#2453)

Browse Source 
This will not fix the current issues yet, but I think it makes sense to start with this to rule this out.

Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2453
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Co-committed-by: Dominik Pschenitschni <mail@celement.de>
This commit is contained in:
Dominik Pschenitschni
2025-01-14 16:47:13 +00:00
committed by konrad
parent 9d985f7e96
commit e9a932e0f0
1 changed files with 17 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
frontend/src/components/tasks/partials/Description.vue
View File

@@ -38,7 +38,7 @@
</template>
<script setup lang="ts">
import {ref, computed, watch, onBeforeUnmount} from 'vue'
import {ref, computed, watchEffect, onBeforeUnmount} from 'vue'
import CustomTransition from '@/components/misc/CustomTransition.vue'
import Editor from '@/components/input/AsyncEditor'
@@ -46,21 +46,25 @@ import Editor from '@/components/input/AsyncEditor'
import type {ITask} from '@/modelTypes/ITask'
import {useTaskStore} from '@/stores/tasks'
type AttachmentUploadFunction = (file: File, onSuccess: (attachmentUrl: string) => void) => Promise<string>
export type AttachmentUploadFunction = (file: File, onSuccess: (attachmentUrl: string) => void) => Promise<string>
const {
modelValue,
attachmentUpload,
canWrite,
} = defineProps<{
const props = withDefaults(defineProps<{
modelValue: ITask,
attachmentUpload: AttachmentUploadFunction,
canWrite: boolean,
}>(), {
canWrite: true,
})
const emit = defineEmits<{
'update:modelValue': [value: ITask]
}>()
const emit = defineEmits(['update:modelValue'])
const description = ref<string>('')
watchEffect(() => {
description.value = props.modelValue.description
})
const saved = ref(false)
// Since loading is global state, this variable ensures we're only showing the saving icon when saving the description.
@@ -69,14 +73,6 @@ const saving = ref(false)
const taskStore = useTaskStore()
const loading = computed(() => taskStore.isLoading)
watch(
() => modelValue.description,
value => {
description.value = value
},
{immediate: true},
)
const changeTimeout = ref<ReturnType<typeof setTimeout> | null>(null)
async function saveWithDelay() {
@@ -99,13 +95,12 @@ async function save() {
if (changeTimeout.value !== null) {
clearTimeout(changeTimeout.value)
}
saved.value = false
saving.value = true
try {
// FIXME: don't update state from internal.
const updated = await taskStore.update({
...modelValue,
...props.modelValue,
description: description.value,
})
emit('update:modelValue', updated)
@@ -119,13 +114,12 @@ async function save() {
}
}
async function uploadCallback(files: File[] | FileList): (Promise<string[]>) {
async function uploadCallback(files: File[] | FileList): Promise<string[]> {
const uploadPromises: Promise<string>[] = []
files.forEach((file: File) => {
const promise = new Promise<string>((resolve) => {
attachmentUpload(file, (uploadedFileUrl: string) => resolve(uploadedFileUrl))
props.attachmentUpload(file, (uploadedFileUrl: string) => resolve(uploadedFileUrl))
})
uploadPromises.push(promise)