ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity
Files
3bb392dfae5a3c9a669cbb8df66ba4da4c8f83d2
shields/services
History
Paul Melnikow 3bb392dfae Remove some duplicated URL generation code (#2240) 
I went down a rabbit hole while trying to untangle the bug in the dockbit and bitrise examples https://github.com/badges/shields/pull/2234#pullrequestreview-169997546.

The URL generation code is spaghetti-like, with functions, many of which I wrote, with opaque names, doing similar but not identical things, and making slightly incompatible assumptions about the way query strings are handled.

I got a bit lost and need to take a step back.

Meanwhile, this is a small piece of work I did that’s worth keeping. It doesn’t scratch the surface of the tangle, but it does remove a bit of duplication.

It also makes a minor stylistic ES6 change in the handling of default arguments.

Ref: #2027
2018-11-05 16:55:49 -05:00
..
amo
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
ansible
refactor [ansible] role service (#2158)
2018-10-19 19:23:41 +01:00
apm
Enforce no extensions in require (#1999)
2018-09-01 11:14:01 -07:00
appveyor
improve [appveyor] error handling (#2085)
2018-09-18 09:07:20 +01:00
aur
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
azure-devops
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
beerpay
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bintray
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bitbucket
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bithound
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
bitrise
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bountysource
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bower
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
bugzilla
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
buildkite
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
bundlephobia
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
cauditor
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
cdnjs
…
chocolatey
…
chrome-web-store
Enforce using async-await [f-droid] (#2241)
2018-11-04 00:33:47 -04:00
circleci
bugfix: [CircleCI] uses 'github' as a default VCS (#2137)
2018-10-05 22:46:51 +01:00
clojars
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
cocoapods
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
codacy
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
codeclimate
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
codecov
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
codeship
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
codetally
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
conda
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
continuousphp
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
cookbook
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
coveralls
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
coverity
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
cpan
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
cran
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
crates
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
ctan
[ctan] refactor service (#2194)
2018-10-20 14:51:25 +02:00
david
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
dependabot
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
depfu
refactor [depfu] service (#2204)
2018-10-23 18:24:14 +01:00
discord
allow badge maxAge to be set by category; affects [discord] (#2205)
2018-10-26 20:08:02 +01:00
discourse
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
dockbit
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
docker
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
dotnetstatus
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
dub
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
eclipse-marketplace
[eclipse-marketplace] License badge (#2212)
2018-10-25 20:53:34 +01:00
elm-package
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
f-droid
Enforce using async-await [f-droid] (#2241)
2018-11-04 00:33:47 -04:00
gem
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
gemnasium
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
github
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
gitter
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
gratipay
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
hackage
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
hexpm
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
hhvm
…
homebrew
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
imagelayers
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
issuestats
Deprecate [issuestats] service (#2038)
2018-09-01 20:53:52 +01:00
itunes
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
jenkins
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
jetbrains
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
jira
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
jitpack
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
json
update service tests tutorial (#2075)
2018-10-01 20:53:04 +01:00
lgtm
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
liberapay
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
librariesio
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
libscore
Deprecated libscore (#2105)
2018-09-22 12:28:54 +01:00
luarocks
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
magnumci
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
maintenance
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
maven-central
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
maven-metadata
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
microbadger
Move build badge examples into services/ (#2234)
2018-10-31 17:32:35 -04:00
myget
Support [nuget myget] packages using SemVer 2 (#2098)
2018-09-20 20:18:30 +01:00
nexus
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
node
…
npm
Add support for private [npm] packages (#2187)
2018-10-20 08:06:36 +01:00
nsp
…
nuget
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
osstracker
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
packagecontrol
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
packagist
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
php-eye
Enforce using async-await [f-droid] (#2241)
2018-11-04 00:33:47 -04:00
powershellgallery
switch [powershellgallery] to use temp url (#2189)
2018-10-23 18:03:50 +01:00
pub
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
puppetforge
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
pypi
bring back the [PyPI] downloads badges (#2131)
2018-10-06 16:38:41 +01:00
readthedocs
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
redmine
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
requires
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
resharper
…
scrutinizer
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
sensiolabs
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
shippable
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
snap-ci
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
sonarqube
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
sourceforge
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
sourcegraph
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
stackexchange
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
steam
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
suggest
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
swagger
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
teamcity
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
time
…
travis
Enforce using async-await [f-droid] (#2241)
2018-11-04 00:33:47 -04:00
twitter
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
uptimerobot
Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)
2018-09-03 19:37:37 +01:00
vaadin-directory
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
versioneye
Rewrite deprecated services and add tests (#2018)
2018-08-30 10:03:15 -07:00
vscode-marketplace
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
waffle
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
website
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
wercker
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
wheelmap
Enforce use of template literals (#2242)
2018-11-02 17:11:44 -04:00
wordpress
Enforce property shorthand (#2243)
2018-11-01 13:46:23 -04:00
xml
update service tests tutorial (#2075)
2018-10-01 20:53:04 +01:00
yaml
update service tests tutorial (#2075)
2018-10-01 20:53:04 +01:00
base-json.js
Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)
2018-09-03 19:37:37 +01:00
base-json.spec.js
Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)
2018-09-03 19:37:37 +01:00
base-svg-scraping.js
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
base-svg-scraping.spec.js
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
base-xml.js
Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)
2018-09-03 19:37:37 +01:00
base-xml.spec.js
Delete BaseHTTPService and implement new BaseXmlService (affects [eclipse-marketplace f-droid]; also testing on [uptimerobot circleci]) (#2037)
2018-09-03 19:37:37 +01:00
base.js
Remove some duplicated URL generation code (#2240)
2018-11-05 16:55:49 -05:00
base.spec.js
Remove some duplicated URL generation code (#2240)
2018-11-05 16:55:49 -05:00
create-service-tester.js
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
deprecated-service.js
…
errors.js
…
index.js
Add some error messages for the developer when .service.js is malformed (#1894)
2018-10-28 15:58:38 +00:00
index.spec.js
Add some error messages for the developer when .service.js is malformed (#1894)
2018-10-28 15:58:38 +00:00
legacy-service.js
…
nuget-fixtures.js
…
response-fixtures.js
…
service-tester.js
Rewrite vso, rename to [AzureDevops], validate SVG [readthedocs] (#2252)
2018-11-05 16:52:53 -05:00
test-helpers.js
update service tests tutorial (#2075)
2018-10-01 20:53:04 +01:00
test-validators.js
upgrade to Joi 14; affects [elm-package jetbrains npmversion pypi vaadin-directory dynamic-xml] (#2221)
2018-10-28 15:56:19 +00:00
trace.js
…
validators.js
…