Enforce no extensions in require (#1999)

This removes remaining `.js` extensions from `require()` expressions and automatically enforces this rule.

.eslintrc-frontend.yml

@@ -1,6 +1,9 @@
 env:
   browser: true
 
+plugins:
+  - import
+
 parser: "babel-eslint"
 
 parserOptions:
@@ -17,3 +20,5 @@ settings:
 
 rules:
   no-console: "error"
+
+  import/extensions: ["error", "never", { "json": "always" }]

.eslintrc.yml

@@ -13,6 +13,7 @@ parserOptions:
 
 plugins:
   - mocha
+  - no-extension-in-require
   - "chai-friendly"
 
 rules:
@@ -33,6 +34,7 @@ rules:
   prefer-const: "error"
   strict: "error"
   arrow-body-style: ["error", "as-needed"]
+  no-extension-in-require/main: "error"
 
   # Mocha-related.
   mocha/no-exclusive-tests: "error"

package-lock.json

@@ -4973,6 +4973,12 @@
         "ramda": "^0.25.0"
       }
     },
+    "eslint-plugin-no-extension-in-require": {
+      "version": "0.2.0",
+      "resolved": "https://registry.npmjs.org/eslint-plugin-no-extension-in-require/-/eslint-plugin-no-extension-in-require-0.2.0.tgz",
+      "integrity": "sha1-4ZMRC4sf+AMuK1YSPzFRwY+Tqr4=",
+      "dev": true
+    },
     "eslint-plugin-node": {
       "version": "7.0.1",
       "resolved": "https://registry.npmjs.org/eslint-plugin-node/-/eslint-plugin-node-7.0.1.tgz",

package.json

@@ -133,6 +133,7 @@
     "eslint-plugin-chai-friendly": "^0.4.1",
     "eslint-plugin-import": "^2.8.0",
     "eslint-plugin-mocha": "^5.1.0",
+    "eslint-plugin-no-extension-in-require": "^0.2.0",
     "eslint-plugin-node": "^7.0.0",
     "eslint-plugin-promise": "^4.0.0",
     "eslint-plugin-react": "^7.6.1",

services/apm/apm.service.js

@@ -6,7 +6,7 @@ const { renderVersionBadge } = require('../../lib/version')
 const { metric } = require('../../lib/text-formatters')
 const BaseJsonService = require('../base-json')
 const { InvalidResponse } = require('../errors')
-const { nonNegativeInteger } = require('../validators.js')
+const { nonNegativeInteger } = require('../validators')
 
 const apmSchema = Joi.object({
   downloads: nonNegativeInteger,

services/gem/gem-downloads.service.js

@@ -10,7 +10,7 @@ const {
 } = require('../../lib/color-formatters')
 const { metric } = require('../../lib/text-formatters')
 const { latest: latestVersion } = require('../../lib/version')
-const { nonNegativeInteger } = require('../validators.js')
+const { nonNegativeInteger } = require('../validators')
 
 const gemsSchema = Joi.object({
   downloads: nonNegativeInteger,

services/gem/gem-rank.service.js

@@ -5,7 +5,7 @@ const Joi = require('joi')
 const BaseJsonService = require('../base-json')
 const { floorCount: floorCountColor } = require('../../lib/color-formatters')
 const { ordinalNumber } = require('../../lib/text-formatters')
-const { nonNegativeInteger } = require('../validators.js')
+const { nonNegativeInteger } = require('../validators')
 
 const totalSchema = Joi.array()
   .items(

services/npm/npm-downloads.service.js

@@ -3,7 +3,7 @@
 const Joi = require('joi')
 const BaseJsonService = require('../base-json')
 const { metric } = require('../../lib/text-formatters')
-const { nonNegativeInteger } = require('../validators.js')
+const { nonNegativeInteger } = require('../validators')
 
 // https://github.com/npm/registry/blob/master/docs/download-counts.md#output
 const pointResponseSchema = Joi.object({

services/pypi/pypi-helpers.spec.js

@@ -7,7 +7,7 @@ const {
   sortDjangoVersions,
   getLicenses,
   getPackageFormats,
-} = require('./pypi-helpers.js')
+} = require('./pypi-helpers')
 
 const classifiersFixture = {
   info: {