* which --> variant
* which --> alias
* which --> format
* improve param names in codeclimate
* improve param names in github-issue-detail
* update github-issue-detail unit tests
* Add subreddit subscribers service file.
* Fix small detail in service and add the tests files.
* Apply suggested changes by the reviewer.
* Trying to make tests work.
* Update services/reddit/subreddit-subscribers.tester.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Update services/reddit/subreddit-subscribers.tester.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* Apply suggested changes.
* Add different handler for non existing and invalid subreddits.
* Update services/reddit/subreddit-subscribers.service.js
Co-Authored-By: Caleb Cartwright <calebcartwright@users.noreply.github.com>
* switch [circleci] service to scrape SVG badge
* reorganise [circleci] routes
Default URL is now
circleci/build/gh/badges/shields/master?token=abc123
There are redirects on the legacy routes to provide
backwards compatibility for existing users
* Fix LGTM badges for non-GitHub projects.
* Allow using full repository host names in LGTM badge URLs.
* Add an LGTM redirector service to redirect old LGTM badge URLs to new LGTM badge URLs.
* Add LGTM redirector tester.
* Remove unneeded check in LGTM base file.
Co-Authored-By: chrisgavin <chris@chrisgavin.me>
* Add [Ubuntu] package version support
https://api.launchpad.net/1.0/
* Mark 400 responses as series not found
* Extract API call into separate fetch function
* Display suggested badges
* E2e test for badge suggestion
* Suggest resource returns example with pattern
* Do not require preview in MarkupModalContent
* Skip integration test for suggestion
* Unmodifiable path in customizer
* Use suggested link
* Allow to change suggested badges
* Enable skipped test
* Enable skipped test
* Code refactoring
* Code refactoring
* Code refactoring
* Code refactoring
* Code refactoring
* Code refactoring
* Unused code removed
* Unused code removed
* getExampleWithServiceByPattern helper added
* BadgeExamples uses examples instead of services definitions
* Revert "getExampleWithServiceByPattern helper added"
This reverts commit 80839fd705.
* style removed from example
* example.exact replaced with preview.buildFromExample
* keywords are required again
* Code refactoring
* More e2e tests for suggestion feature
* Code refactoring
* Build add with a base url
* showActualParams -> isPrefilled
* A new schema for BadgeExamples
* Link moved to queryParams
* Updated documentation for the suggest reponse format
* Link moved to queryParams - another test updated
* Revert "Link moved to queryParams - another test updated"
This reverts commit b5f811bb07.
* Revert "Link moved to queryParams"
This reverts commit 3b54c6d2b4.
* Disable changes in path in suggested badges
* 'link' element documentation restored
* refactor(Scrutinizer): migrated to new BaseJsonService
* refactor(ScrutinizerCoverage): updated color scale to match
* refactor(Scrutinizer): switched to multiple classes to handle dif. git hosts
* refactor(Scrutinizer): finished migrating to new service arch.
* fix(Scrutinizer): fixed branch check logic
* refactor(Scrutinizer): inline transforms based on PR feedback
* refactor(ScrutinizerCoverage): change handling of no coverage scenario
* refactor maven central
* misc fixes
- include a pretty message on NotFound when the filter returns no results
- split the group and artifact into seperate variables
- remove the connection error test
* remove xml parsing test and add inexistent version prefix test
* use existing test validators and shorthand createservicetester
I find having these in a consistent order makes the services much faster to read.
This is the order I’ve generally been using:
1. Category
2. Route
3. Examples
4. Rendering
5. Other helpers (`fetch()`, `transform()`)
6. `handle()`
* refactor(JenkinsTests): finished core refactor to new service model
* refactor(JenkinsTests): more updates
* refactor(JenkinsCoverage): minor refactor to leverage new common Jenkins content
* refactor(JenkinsBuild): update redirector to include shorthand alias
* chore: apply suggestion on jenkins-tests.service.js
Co-Authored-By: calebcartwright <calebcartwright@users.noreply.github.com>
* refactor(JenkinsTests): rename test helpers
* chore: cleanup JenkinsCoverage redirector
* chore: cleanup JenkinsBuild redirector
* chore: cleanup test docs
* [Bit] add bit components count service
* [Bit] change 404 error to 'collection not found'
* [Bit] remove comment
* [Bit] change collection schema
* [Bit] use isMetric
* [Bit] replace static color to dynamic color
* [BIt] change bit total components route
* change scope to collection
* change all scope var to collection
- Prefer inline transforms to take place in `handle()` rather than `render()`
- Avoid inversion of control by removing `BaseWordpress#handle()`, passing `extensionType` into `fetch()`, and removing one layer of subclassing
- Move “not found” checks into `fetch()`
- Cache wordpress versions instead of fetching on each request
- Start to convert aliases to redirects (there are more of these which could be tackled in a follow-on)
- Replace at least one route `format` with a `pattern` (ref #3329)
- Partially reorder: name, category, route, examples, defaultBadgeData, render, fetch, handle
Some of this is in line with our established patterns or makes it clearly easier to follow; some of it is arguably stylistic.
