Move checkErrorResponse from lib/ to core/ [chrome] (#3408)

core/base-service/base.js

@@ -4,8 +4,8 @@ const decamelize = require('decamelize')
 // See available emoji at http://emoji.muan.co/
 const emojic = require('emojic')
 const Joi = require('joi')
-const { checkErrorResponse } = require('../../lib/error-helper')
 const { assertValidCategory } = require('./categories')
+const checkErrorResponse = require('./check-error-response')
 const coalesceBadge = require('./coalesce-badge')
 const {
   NotFound,

core/base-service/check-error-response.js

@@ -1,16 +1,12 @@
 'use strict'
 
-const {
-  NotFound,
-  InvalidResponse,
-  Inaccessible,
-} = require('../core/base-service/errors')
+const { NotFound, InvalidResponse, Inaccessible } = require('./errors')
 
 const defaultErrorMessages = {
   404: 'not found',
 }
 
-function checkErrorResponse(errorMessages = {}) {
+module.exports = function checkErrorResponse(errorMessages = {}) {
   return async function({ buffer, res }) {
     let error
     errorMessages = { ...defaultErrorMessages, ...errorMessages }
@@ -39,7 +35,3 @@ function checkErrorResponse(errorMessages = {}) {
     }
   }
 }
-
-module.exports = {
-  checkErrorResponse,
-}

core/base-service/check-error-response.spec.js

@@ -1,12 +1,8 @@
 'use strict'
 
 const { expect } = require('chai')
-const {
-  NotFound,
-  InvalidResponse,
-  Inaccessible,
-} = require('../core/base-service/errors')
-const { checkErrorResponse } = require('./error-helper')
+const { NotFound, InvalidResponse, Inaccessible } = require('./errors')
+const checkErrorResponse = require('./check-error-response')
 
 describe('async error handler', function() {
   const buffer = Buffer.from('some stuff')

services/chrome-web-store/chrome-web-store-base.js

@@ -2,7 +2,7 @@
 
 const { BaseService, Inaccessible } = require('..')
 const chromeWebStore = require('chrome-web-store-item-property')
-const { checkErrorResponse } = require('../../lib/error-helper')
+const checkErrorResponse = require('../../core/base-service/check-error-response')
 
 module.exports = class BaseChromeWebStoreService extends BaseService {
   async fetch({ storeId }) {