Commit Graph
3181 Commits
Author SHA1 Message Date
dependabot-preview[bot]andPaul Melnikow f251de395d Build(deps): bump config from 3.1.0 to 3.2.2 (#3751)
Bumps [config](https://github.com/lorenwest/node-config) from 3.1.0 to 3.2.2.
- [Release notes](https://github.com/lorenwest/node-config/releases)
- [Changelog](https://github.com/lorenwest/node-config/blob/master/History.md)
- [Commits](https://github.com/lorenwest/node-config/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-22 15:14:22 -05:00
Paul MelnikowandGitHub 28b8836595 Unify the ESLint config (#3743)
Adding TypeScript to the frontend and a `.d.ts` file to `core` (see #3742) has multiplied out the different combinations of lint rules. ESLint has support for file-pattern-based overrides, which we've used in some places, but we've also maintained a separate eslintrc for `frontend/`.

This merges the config together, with the strategy of putting all the rules at the top level except where they conflict, and applying settings to exactly the files where they should apply.

This introduces a few new errors in the server but they are true positives – hoisting and lowercase class names – things we don't really need to be doing).
2019-07-22 15:06:38 -05:00
Pierre-Yves BandGitHub ecb85cef53 Remove popout styles (#3747)
* Remove popout styles

* Make popout-square fall back to flat-square
2019-07-22 20:56:07 +01:00
Paul MelnikowandCaleb Cartwright ec6512b7ba Rewrite RequestMarkupButton using hooks (#3739) 2019-07-21 13:48:49 -05:00
Pierre-Yves BandGitHub 345c26f72d Handle packages with no released versions in [PackagistVersion] (#3746) 2019-07-20 17:52:53 +01:00
Paul MelnikowandGitHub 236decac29 Rewrite Main using hooks (#3738) 2019-07-19 12:27:25 -05:00
Paul MelnikowandGitHub 4090ab8a01 Rewrite SugggestionAndSearch using hooks (#3741) 2019-07-19 12:10:10 -05:00
Paul MelnikowandGitHub 88fc4a751c Initial adoption of TypeScript in the frontend (#3722)
Ref #3657
2019-07-17 23:11:51 -04:00
Paul MelnikowandGitHub d4e17d4e94 Rewrite PathBuilder using hooks (#3721) 2019-07-17 22:02:01 -04:00
Paul MelnikowandGitHub 5d3d78b209 Rewrite Customizer using hooks (#3720) 2019-07-17 21:15:30 -04:00
Paul MelnikowandGitHub be275b9f13 Rewrite CopiedContentIndicator using hooks (#3719) 2019-07-17 16:16:42 -04:00
Pierre-Yves BandGitHub 3dbe655611 Display one decimal for metrics smaller than 10 (#3735)
* Display one decimal for metrics smaller than 10

* Update test validators

* Run Prettier

* Update GitHub regexes
2019-07-17 20:00:29 +01:00
dependabot-preview[bot]andCaleb Cartwright e556ac2793 Build(deps): bump simple-icons from 1.10.0 to 1.11.0 (#3728)
Bumps [simple-icons](https://github.com/simple-icons/simple-icons) from 1.10.0 to 1.11.0.
- [Release notes](https://github.com/simple-icons/simple-icons/releases)
- [Commits](https://github.com/simple-icons/simple-icons/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 19:40:51 -05:00
dependabot-preview[bot]andCaleb Cartwright c7130bec61 Build(deps-dev): bump babel-preset-gatsby from 0.2.1 to 0.2.6 (#3733)
Bumps [babel-preset-gatsby](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/babel-preset-gatsby) from 0.2.1 to 0.2.6.
- [Release notes](https://github.com/gatsbyjs/gatsby/releases)
- [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/babel-preset-gatsby/CHANGELOG.md)
- [Commits](https://github.com/gatsbyjs/gatsby/commits/babel-preset-gatsby@0.2.6/packages/babel-preset-gatsby)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 19:05:38 -05:00
dependabot-preview[bot]andMarcin Mielnicki da36dcf195 Build(deps-dev): bump portfinder from 1.0.20 to 1.0.21 (#3730)
Bumps [portfinder](https://github.com/indexzero/node-portfinder) from 1.0.20 to 1.0.21.
- [Release notes](https://github.com/indexzero/node-portfinder/releases)
- [Commits](https://github.com/indexzero/node-portfinder/compare/v1.0.20...v1.0.21)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 23:02:18 +02:00
dependabot-preview[bot]andMarcin Mielnicki d9aefc61bf Build(deps): bump prom-client from 11.5.2 to 11.5.3 (#3731)
Bumps [prom-client](https://github.com/siimon/prom-client) from 11.5.2 to 11.5.3.
- [Release notes](https://github.com/siimon/prom-client/releases)
- [Changelog](https://github.com/siimon/prom-client/blob/master/CHANGELOG.md)
- [Commits](https://github.com/siimon/prom-client/compare/v11.5.2...v11.5.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 22:49:58 +02:00
dependabot-preview[bot]andMarcin Mielnicki 7ba56fa96d Build(deps-dev): bump cypress from 3.3.2 to 3.4.0 (#3729)
Bumps [cypress](https://github.com/cypress-io/cypress) from 3.3.2 to 3.4.0.
- [Release notes](https://github.com/cypress-io/cypress/releases)
- [Commits](https://github.com/cypress-io/cypress/compare/v3.3.2...v3.4.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 22:15:02 +02:00
dependabot-preview[bot]andPierre-Yves B aa03fdcdb4 Build(deps): bump semver from 6.1.2 to 6.2.0 (#3732)
Bumps [semver](https://github.com/npm/node-semver) from 6.1.2 to 6.2.0.
- [Release notes](https://github.com/npm/node-semver/releases)
- [Changelog](https://github.com/npm/node-semver/blob/master/CHANGELOG.md)
- [Commits](https://github.com/npm/node-semver/compare/v6.1.2...v6.2.0)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 20:11:17 +01:00
dependabot-preview[bot]andCaleb Cartwright cde36f642d Build(deps-dev): bump react-modal from 3.8.2 to 3.9.1 (#3727)
Bumps [react-modal](https://github.com/reactjs/react-modal) from 3.8.2 to 3.9.1.
- [Release notes](https://github.com/reactjs/react-modal/releases)
- [Changelog](https://github.com/reactjs/react-modal/blob/master/CHANGELOG.md)
- [Commits](https://github.com/reactjs/react-modal/compare/v3.8.2...v3.9.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-16 08:31:27 -05:00
Paul MelnikowandPierre-Yves B 3bce0b0eee Capitalize Open Collective in badge listing (#3734) 2019-07-15 22:27:16 +01:00
dependabot-preview[bot]andCaleb Cartwright f44352f74a Build(deps-dev): bump gatsby-plugin-styled-components (#3726)
Bumps [gatsby-plugin-styled-components](https://github.com/gatsbyjs/gatsby/tree/HEAD/packages/gatsby-plugin-styled-components) from 3.1.0 to 3.1.2.
- [Release notes](https://github.com/gatsbyjs/gatsby/releases)
- [Changelog](https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-plugin-styled-components/CHANGELOG.md)
- [Commits](https://github.com/gatsbyjs/gatsby/commits/gatsby-plugin-styled-components@3.1.2/packages/gatsby-plugin-styled-components)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-15 07:37:26 -05:00
dependabot-preview[bot]andCaleb Cartwright 289e69c475 Build(deps-dev): bump jsdoc from 3.6.2 to 3.6.3 (#3725)
Bumps [jsdoc](https://github.com/jsdoc/jsdoc) from 3.6.2 to 3.6.3.
- [Release notes](https://github.com/jsdoc/jsdoc/releases)
- [Changelog](https://github.com/jsdoc/jsdoc/blob/master/CHANGES.md)
- [Commits](https://github.com/jsdoc/jsdoc/compare/3.6.2...3.6.3)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-15 07:22:12 -05:00
dependabot-preview[bot]andCaleb Cartwright 5ff5462e8d Build(deps-dev): bump nock from 11.0.0-beta.20 to 11.0.0-beta.24 (#3723)
Bumps [nock](https://github.com/nock/nock) from 11.0.0-beta.20 to 11.0.0-beta.24.
- [Release notes](https://github.com/nock/nock/releases)
- [Changelog](https://github.com/nock/nock/blob/beta/CHANGELOG.md)
- [Commits](https://github.com/nock/nock/commits)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
2019-07-15 06:47:35 -05:00
Paul MelnikowandGitHub 4e4e7be804 Update lockfile with npm audit fixes (#3718) 2019-07-14 19:30:00 -04:00
Paul MelnikowandGitHub b493fbf70e Add warnings alongside deprecated URL patterns (#3715)
Ref #3714
2019-07-14 19:14:19 -04:00
Paul MelnikowandGitHub 6a2f384860 Update [Sonar] routes: metric first, and server in the query string (#3696)
This is the preferred way we’re handling server URLs: in the query string.

While we still have a mix of these, I’ve argued this way is better for these reasons:

1. It allows us to make the URLs a bit more standardized across services.
2. It makes the routes unambiguous.
3. It requires less code.

While it introduces a URL-encoding requirement on the parameter, I think these tradeoffs are worth it.
2019-07-14 17:06:14 -04:00
Caleb CartwrightandPierre-Yves B bd8b1ead59 tests: remove service tests for dropped static png routes (#3712) 2019-07-13 17:40:17 +01:00
Jan ŠkrášekandCaleb Cartwright 39d47a10b4 service/packagist: normalize stability suffixes (#3699) 2019-07-13 11:02:43 -05:00
Pierre-Yves BandCaleb Cartwright 9576ba8fc3 Split [Conda] tests (#3711) 2019-07-13 10:55:41 -05:00
Pierre-Yves BandCaleb Cartwright 102db63d46 Split [pypi] tests (#3704)
* Split [pypi] tests

* Changed filenames to match previous class names
2019-07-13 10:45:58 -05:00
Paul MelnikowandCaleb Cartwright 6cbc7b587a Document the production Redis hosting (#3710)
Close #3332
2019-07-13 08:39:07 -05:00
Paul MelnikowandGitHub ec0264dfb7 Fix Redis prod issue for Node 9 (#3707)
Encountered while testing #3332
2019-07-12 19:51:05 -04:00
Paul MelnikowandGitHub 153732756c Log internal errors to Sentry (#3706)
Fix #3688
2019-07-12 19:40:46 -04:00
Paul MelnikowandGitHub 65afff40d4 Fix up Redis config (#3705)
- Move to private
- Fix validation
- Don't log the URL

Ref #3332
2019-07-12 19:12:49 -04:00
Paul MelnikowandGitHub 84063f8ae3 Switch to ioredis, and update RedisTokenPersistence to use a set instead of a list (#3668)
Also add a script for importing a batch of tokens.

Ref #3332
2019-07-12 18:30:24 -04:00
Pierre-Yves BandGitHub 5fb429a1ef Split [Jetbrains] tests (#3702)
* Split [Jetbrains] tests

* Removed inaccessible/invalid tests
2019-07-12 22:59:21 +01:00
Pierre-Yves BandGitHub 69862549a8 Split [LGTM] tests (#3703) 2019-07-12 22:22:56 +01:00
Pierre-Yves BandGitHub 12db962e50 Split [Bitbucket] tests (#3701) 2019-07-12 21:09:29 +01:00
Paul MelnikowandGitHub 46ac947e9b Refactor auth config checks in another test (#3698)
This is one more like #3694.

Ref #3652 #3393
2019-07-11 20:00:20 -04:00
Paul MelnikowandGitHub 5d20a371d1 Update serverSecrets reference in legacy monitor (#3697)
Ref #3652 #3393
2019-07-11 19:41:22 -04:00
Pierre-Yves BandGitHub 0a276f692f Colorize [OSSLifecycle] badge (#3695)
* Updated examples

* Ran Prettier again
2019-07-11 23:28:21 +01:00
Paul MelnikowandGitHub ace66f457d Refactor auth config checks within tests (#3694)
Ref #3652 #3393
2019-07-11 18:11:34 -04:00
Paul MelnikowandGitHub e2608a6570 Refactor GitHub OAuth credential handling (#3693)
Continues the work of #3652.
2019-07-11 18:04:53 -04:00
Paul MelnikowandGitHub 930a7219b0 Refactor [bitbucket] secrets (#3691)
Continues the work of #3652.

Since Bitbucket is the only service to use two sets of credentials like this, it seems to make the most sense to build a very local solution.
2019-07-11 17:56:51 -04:00
Paul MelnikowandGitHub b2e5aa9208 Cache raster redirects longer (#3690)
Haven't seen error reports on these, so let's cache these a bit longer to reduce our server load.
2019-07-11 16:57:21 -04:00
Pierre-Yves BandGitHub 7bdda90c0f Documentation for OSS Lifecycle (#3689) 2019-07-11 21:23:57 +01:00
chris48sandGitHub 38cdc0033f adopt JSDoc, eslint-plugin-jsdoc (#3645)
eslint-plugin-jsdoc:
- install eslint-plugin-jsdoc
- config file
- fix lint/style errors

JSDoc:
- add JSDoc as a dev dependency
- get everything rendering nicely with JSDoc
- config, build command + ignores
2019-07-11 20:14:47 +01:00
Duane O'BrienandPierre-Yves B ad7023bcbe Make the osslifecycle badge company-agnostic (#3618)
* Make the osslifecycle badge company-agnostic 

Removes references to Netflix in the example titles of the osslifecycle badge
To make the badge more generic and easier to use by companies besides Netflix, the examples should remove Netflix from the title.

* Adding Netflix back in as a keyword, to make the badge easily searchable for people who remember it with the old title.
2019-07-11 19:08:43 +01:00
Chintalagiri ShashankandCaleb Cartwright a9d0f0d323 Updates *GPL licenses to new SPDX ids and adds additional aliases, run service tests for [apm aur bowerlicense cocoapodslicense cpanlicense cran crates ctan dublicense eclipsemarketplacelicense githublicense hexpm npmlicense packagistlicense pypilicense] (#3686)
* Updated GPL, LGPL, and AGPL licence IDs to the SPEX 3.5 specification.

* Add GPL, LGPL, and AGPL aliases in the format in which they are used in Python classifiers.
2019-07-10 15:38:00 -05:00
Paul MelnikowandGitHub ce0ddf93fc Inject secrets into the services (#3652)
This is a reworking of #3410 based on some feedback @calebcartwright left on that PR.

The goals of injecting the secrets are threefold:

1. Simplify testing
2. Be consistent with all of the other config (which is injected)
3. Encapsulate the sensitive auth-related code in one place so it can be studied and tested thoroughly

- Rather than add more code to BaseService to handle authorization logic, it delegates that to an AuthHelper class.
- When the server starts, it fetches the credentials from `config` and injects them into `BaseService.register()` which passes them to `invoke()`.
- In `invoke()` the service's auth configuration is checked (`static get auth()`, much like `static get route()`).
- If the auth config is present, an AuthHelper instance is created and attached to the new instance.
- Then within the service, the password, basic auth config, or bearer authentication can be accessed via e.g. `this.authHelper.basicAuth` and passed to `this._requestJson()` and friends.
- Everything is being done very explicitly, so it should be very clear where and how the configured secrets are being used.
- Testing different configurations of services can now be done by injecting the config into `invoke()` in `.spec` files instead of mocking global state in the service tests as was done before. See the new Jira spec files for a good example of this.

Ref #3393
2019-07-09 23:14:36 -04:00