It's easy to push services that don't validate, because much of the tooling, including the service test runner and the service definition generator, do not validate all the services. This leads to errors that manifest in CI. It would be more helpful to see these errors sooner.
This moves the `validateDefinition()` check to `loadServiceClasses()`, where the services are first loaded, and fixes related validation errors.
Two of these regexes have triggered a LGTM alert.
https://lgtm.com/rules/1505904457770/
I’m not terribly concerned about it given this is a test, though it’s nice to clear these up, and the new regexes are a bit easier to understand.
* New Service: Bitbucket Server: Pull Request Count
* [Bitbucket]: Pull Requests: Add Support for bitbucket-server
* Update examples to use namedParams instead of exampleUrl
* Simplify cloud vs server check
* [Bitbucket]: Add support for bitbucket cloud private repos
* Add additional tests for bitbucket server
* [Bitbucket]: Add tests for basic auth
* [Bitbucket] Format secrets according to style guides
* [Bitbucket] Add link to server REST documentation
* Punt adding VSCode debug task to separate PR
* [Bitbucket] Remove extra truthy check on serverSecrets
* [Bitbucket] Fix credentials after rename
* [Bitbucket] Use query parameters for Bitbucket Server support
* Fix bitbucket creds in secret template
* [Bitbucket] staticExample -> staticPreview
* Remove VSCode specific gitignore entries
* [Bitbucket] Normalize pluralization of PullReqeust(s) to match file name
This code isn't being run during tests, though let's fix that later as part of #2733. Specifically:
> However _the pool itself_ could be used all the time; there's not a big advantage in turning that off when it doesn't need to be used.
Fix#2728
With the menu in place I think having more categories is helping that process because it's grouping more similar things together. Given #2722, improving our discoverability in the analysis area may be particularly useful to developers right now.
- With examples using `pattern`s, allow building the URL from its component parts, including the query string.
- Provide a button to copy the link, with an animation.
To enable this for other badges, convert them to use a `pattern`: #1961.
* bStats badges
* Remove inline tutorial comments
* Split tests into seperate files
* use shorthand for tester instantiation
* use Joi.number() for validation
* Misc. fixes
* update to use native api
Currently HTML code of shields.io contains two `<title>` elements. This PR removes an extra title element.
Before change:
```bash
> curl https://shields.io -s | egrep "<title.*/title>" -o
<title class="next-head">Shields.io: Quality metadata badges for open source projects</title>
<title>My page</title>
```
After change:
```bash
> curl http://localhost:8080 -s | egrep "<title.*/title>" -o
<title class="next-head">Shields.io: Quality metadata badges for open source projects</title>
```
