For-the-badge | Convert labels to string then uppercase (#1281)

This commit is contained in:
Danial
2017-11-23 17:35:33 +13:00
committed by Paul Melnikow
parent e588bef199
commit a4bce73da6
3 changed files with 19 additions and 4 deletions

View File

@@ -95,8 +95,8 @@ function makeBadge (data) {
data.template = 'flat';
}
if (data.template === 'for-the-badge'){
data.text[0] = data.text[0].toUpperCase();
data.text[1] = data.text[1].toUpperCase();
data.text[0] = ('' + data.text[0]).toUpperCase();
data.text[1] = ('' + data.text[1]).toUpperCase();
}
if (data.colorscheme) {
let pickedColorscheme = colorscheme[data.colorscheme];

View File

@@ -12,3 +12,18 @@ describe('The badge generator', function () {
assert(svg.includes('grown'), 'grown');
});
});
describe('"for-the-badge" template badge generation', function () {
// https://github.com/badges/shields/issues/1280
it('numbers should produce a string', function () {
const svg = makeBadge({ text: [1998, 1999], format: 'svg', template: 'for-the-badge' });
assert(svg.includes('1998'), `${svg} does not contain '1998'`);
assert(svg.includes('1999'), `${svg} does not contain '1999'`);
});
it('lowercase/mixedcase string should produce uppercase string', function () {
const svg = makeBadge({ text: ["Label", "1 string"], format: 'svg', template: 'for-the-badge' });
assert(svg.includes('LABEL'), `${svg} does not contain 'LABEL'`);
assert(svg.includes('1 STRING'), `${svg} does not contain '1 TEST'`);
});
});

View File

@@ -7,8 +7,8 @@
{{?it.logo}}
<image x="9" y="7" width="{{=it.logoWidth}}" height="14" xlink:href="{{=it.logo}}"/>
{{?}}
<text x="{{=((it.widths[0]+it.logoWidth+it.logoPadding)/2)*10}}" y="175" transform="scale(0.1)" textLength="{{=(it.widths[0]-(24+it.logoWidth+it.logoPadding))*10}}" lengthAdjust="spacing">{{=it.escapeXml(it.text[0].toUpperCase())}}</text>
<text x="{{=(it.widths[0]+it.widths[1]/2)*10}}" y="175" font-weight="bold" transform="scale(0.1)" textLength="{{=(it.widths[1]-24)*10}}" lengthAdjust="spacing">{{=it.escapeXml(it.text[1].toUpperCase())}}</text>
<text x="{{=((it.widths[0]+it.logoWidth+it.logoPadding)/2)*10}}" y="175" transform="scale(0.1)" textLength="{{=(it.widths[0]-(24+it.logoWidth+it.logoPadding))*10}}" lengthAdjust="spacing">{{=it.escapeXml(it.text[0])}}</text>
<text x="{{=(it.widths[0]+it.widths[1]/2)*10}}" y="175" font-weight="bold" transform="scale(0.1)" textLength="{{=(it.widths[1]-24)*10}}" lengthAdjust="spacing">{{=it.escapeXml(it.text[1])}}</text>
</g>
{{?(it.links[0] && it.links[0].length)}}
<a xlink:href="{{=it.links[0]}}">

Before

Width:  |  Height:  |  Size: 1.5 KiB

After

Width:  |  Height:  |  Size: 1.5 KiB