fix [githubpipenv] service tests (#10658)

* fix failing test 'Locked version of VCS dependency'

replaced tested package which is missing with another example

* Add regex validator for commit hash format

* fix vcs dependency test to use pipenv's pypiserver
This commit is contained in:
jNullj
2024-11-11 21:15:35 +02:00
committed by GitHub
parent 6219c6da82
commit 4d203e1937
2 changed files with 7 additions and 6 deletions

View File

@@ -1,13 +1,13 @@
import Joi from 'joi'
import { ServiceTester } from '../tester.js'
import {
isCommitHash,
isVPlusDottedVersionAtLeastOne,
isVPlusDottedVersionNClausesWithOptionalSuffix,
} from '../test-validators.js'
// e.g. v19.3b0
const isBlackVersion = Joi.string().regex(/^v\d+(\.\d+)*(.*)?$/)
const isShortSha = Joi.string().regex(/[0-9a-f]{7}/)
export const t = new ServiceTester({
id: 'GithubPipenv',
@@ -82,10 +82,8 @@ t.create('Locked version of unknown dependency')
})
t.create('Locked version of VCS dependency')
.get(
'/locked/dependency-version/thorn-oss/perception/dev/videoalignment.json',
)
.get('/locked/dependency-version/pypa/pipenv/dev/pypiserver.json')
.expectBadge({
label: 'videoalignment',
message: isShortSha,
label: 'pypiserver',
message: isCommitHash,
})

View File

@@ -55,6 +55,8 @@ const isPhpVersionReduction = withRegex(
/^((>= \d+(\.\d+)?)|(\d+\.\d+(, \d+\.\d+)*)|(\d+\.\d+ - \d+\.\d+))(, HHVM)?$/,
)
const isCommitHash = withRegex(/^[a-f0-9]{7,40}$/)
const isStarRating = withRegex(
/^(?=.{5}$)(\u2605{0,5}[\u00BC\u00BD\u00BE]?\u2606{0,5})$/,
)
@@ -187,6 +189,7 @@ export {
isVPlusDottedVersionNClausesWithOptionalSuffixAndEpoch,
isComposerVersion,
isPhpVersionReduction,
isCommitHash,
isStarRating,
isMetric,
isMetricAllowNegative,