Revert "prefer release.name in [Github] release badge (#6879)" (#6880)

This reverts commit a4c93c56e7.

services/github/github-common-release.js

@@ -11,7 +11,6 @@ const releaseInfoSchema = Joi.object({
       download_count: nonNegativeInteger,
     })
     .required(),
-  name: Joi.string().allow('').required(),
   tag_name: Joi.string().required(),
   prerelease: Joi.boolean().required(),
 }).required()

services/github/github-downloads.tester.js

@@ -45,7 +45,6 @@ t.create('downloads for latest release (sort by date)')
         { name: 'phaser.js', download_count: 5 },
         { name: 'phaser.min.js', download_count: 7 },
       ],
-      name: '',
       tag_name: 'v3.15.1',
       prerelease: false,
     })
@@ -61,7 +60,6 @@ t.create('downloads for latest release (sort by SemVer)')
           { name: 'phaser.js', download_count: 1 },
           { name: 'phaser.min.js', download_count: 3 },
         ],
-        name: '',
         tag_name: 'v3.16.0-rc1',
         prerelease: true,
       },
@@ -70,7 +68,6 @@ t.create('downloads for latest release (sort by SemVer)')
           { name: 'phaser.js', download_count: 5 },
           { name: 'phaser.min.js', download_count: 7 },
         ],
-        name: '',
         tag_name: 'v3.15.0',
         prerelease: false,
       },
@@ -79,7 +76,6 @@ t.create('downloads for latest release (sort by SemVer)')
           { name: 'phaser.js', download_count: 9 },
           { name: 'phaser.min.js', download_count: 11 },
         ],
-        name: '',
         tag_name: 'v3.15.1',
         prerelease: false,
       },
@@ -96,7 +92,6 @@ t.create('downloads for latest release (sort by date including pre-releases)')
           { name: 'phaser.js', download_count: 1 },
           { name: 'phaser.min.js', download_count: 3 },
         ],
-        name: '',
         tag_name: 'v3.16.0-rc1',
         prerelease: true,
       },
@@ -105,7 +100,6 @@ t.create('downloads for latest release (sort by date including pre-releases)')
           { name: 'phaser.js', download_count: 5 },
           { name: 'phaser.min.js', download_count: 7 },
         ],
-        name: '',
         tag_name: 'v3.15.0',
         prerelease: false,
       },
@@ -114,7 +108,6 @@ t.create('downloads for latest release (sort by date including pre-releases)')
           { name: 'phaser.js', download_count: 9 },
           { name: 'phaser.min.js', download_count: 11 },
         ],
-        name: '',
         tag_name: 'v3.15.1',
         prerelease: false,
       },
@@ -131,7 +124,6 @@ t.create('downloads for latest release (sort by SemVer including pre-releases)')
           { name: 'phaser.js', download_count: 9 },
           { name: 'phaser.min.js', download_count: 11 },
         ],
-        name: '',
         tag_name: 'v3.15.1',
         prerelease: false,
       },
@@ -140,7 +132,6 @@ t.create('downloads for latest release (sort by SemVer including pre-releases)')
           { name: 'phaser.js', download_count: 1 },
           { name: 'phaser.min.js', download_count: 3 },
         ],
-        name: '',
         tag_name: 'v3.16.0-rc1',
         prerelease: true,
       },
@@ -149,7 +140,6 @@ t.create('downloads for latest release (sort by SemVer including pre-releases)')
           { name: 'phaser.js', download_count: 5 },
           { name: 'phaser.min.js', download_count: 7 },
         ],
-        name: '',
         tag_name: 'v3.15.0',
         prerelease: false,
       },

services/github/github-release.service.js

@@ -79,8 +79,7 @@ class GithubRelease extends GithubAuthV3Service {
       queryParams
     )
     return this.constructor.render({
-      version:
-        latestRelease.name !== '' ? latestRelease.name : latestRelease.tag_name,
+      version: latestRelease.tag_name,
       sort: queryParams.sort,
       isPrerelease: latestRelease.prerelease,
     })

services/github/github-release.tester.js

@@ -20,24 +20,6 @@ t.create('Prerelease')
     color: Joi.string().allow('blue', 'orange').required(),
   })
 
-t.create('Release (custom release name)')
-  .get('/v/release/expressjs/express.json')
-  .intercept(nock =>
-    nock('https://api.github.com')
-      .get('/repos/expressjs/express/releases/latest')
-      .reply(200, {
-        assets: [],
-        name: 'custom release name',
-        tag_name: '1.0.0',
-        prerelease: false,
-      })
-  )
-  .expectBadge({
-    label: 'release',
-    message: 'custom release name',
-    color: 'blue',
-  })
-
 t.create('Release (No releases)')
   .get('/v/release/badges/daily-tests.json')
   .expectBadge({ label: 'release', message: 'no releases or repo not found' })