ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Remove unused parameter in [jsdelivr] (#2988)

Browse Source 
`headers` is not destructured; it needs to go in `options`.

`Shields.io` is set as the `User-Agent` by code in `legacy-request-handler.js`.
This commit is contained in:
Paul Melnikow
2019-02-13 12:53:48 -04:00
committed by Caleb Cartwright
parent 56d374a467
commit 28948925c2
2 changed files with 6 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
services/jsdelivr/jsdelivr-hits-github.service.js
View File

@@ -21,16 +21,11 @@ module.exports = class jsDelivrHitsGitHub extends BaseJsDelivrService {
}
async fetch({ period, user, repo }) {
const url = `https://data.jsdelivr.com/v1/package/gh/${user}/${repo}/stats/date/${
periodMap[period]
}`
return this._requestJson({
schema,
url,
headers: {
'User-Agent': 'Shields.io',
},
url: `https://data.jsdelivr.com/v1/package/gh/${user}/${repo}/stats/date/${
periodMap[period]
}`,
})
}

11
services/jsdelivr/jsdelivr-hits-npm.service.js
View File

@@ -21,16 +21,11 @@ module.exports = class jsDelivrHitsNPM extends BaseJsDelivrService {
}
async fetch({ period, pkg }) {
const url = `https://data.jsdelivr.com/v1/package/npm/${pkg}/stats/date/${
periodMap[period]
}`
return this._requestJson({
schema,
url,
headers: {
'User-Agent': 'Shields.io',
},
url: `https://data.jsdelivr.com/v1/package/npm/${pkg}/stats/date/${
periodMap[period]
}`,
})
}