ComputerSurge/shields
3
0
Fork 0
Code Pull Requests 1 Activity

Only compute user/repo if suggesting badges for GitHub (#1601)

Browse Source 
This resolves the following error occurring in production:

```
TypeError: Cannot read property 'slice' of null
/home/m/shields/lib/suggest.js in findSuggestions at line 40:33
  const userRepo = url.pathname.slice(1).split('/');
```
This commit is contained in:
Thaddée Tyl
2018-03-25 23:47:54 +02:00
committed by Paul Melnikow
parent 400ae013a7
commit 0a248998f2
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/suggest.js
View File

@@ -37,11 +37,11 @@ function suggest (allowedOrigin, data, end, ask) {
// url: string
// cb: function({badges})
function findSuggestions (url, cb) {
const userRepo = url.pathname.slice(1).split('/');
const user = userRepo[0];
const repo = userRepo[1];
let promises = [];
if (url.hostname === 'github.com') {
const userRepo = url.pathname.slice(1).split('/');
const user = userRepo[0];
const repo = userRepo[1];
promises = promises.concat([
githubIssues(user, repo),
githubForks(user, repo),