full err too large for alert

This commit is contained in:
mbecker20
2024-07-09 00:40:11 -07:00
parent b926f89954
commit 7427a158f4
3 changed files with 3 additions and 25 deletions

View File

@@ -359,7 +359,6 @@ impl Resolve<RunBuild, (User, Update)> for State {
warn!("build unsuccessful, alerting...");
let target = update.target.clone();
let version = update.version;
let err = update.logs.iter().find(|l| !l.success).cloned();
tokio::spawn(async move {
let alert = Alert {
id: Default::default(),
@@ -371,7 +370,6 @@ impl Resolve<RunBuild, (User, Update)> for State {
data: AlertData::BuildFailed {
id: build.id,
name: build.name,
err,
version,
},
};
@@ -410,7 +408,6 @@ async fn handle_early_return(
warn!("build unsuccessful, alerting...");
let target = update.target.clone();
let version = update.version;
let err = update.logs.iter().find(|l| !l.success).cloned();
tokio::spawn(async move {
let alert = Alert {
id: Default::default(),
@@ -423,7 +420,6 @@ async fn handle_early_return(
id: build_id,
name: build_name,
version,
err,
},
};
send_alerts(&[alert]).await

View File

@@ -352,25 +352,12 @@ async fn send_slack_alert(
id,
name,
version,
err,
} => {
let text = format!("{level} | Build {name} has failed");
let err = err
.as_ref()
.map(|log| {
let stdout = (!log.stdout.is_empty())
.then(|| format!("\nstdout: {}", log.stdout))
.unwrap_or_default();
let stderr = (!log.stderr.is_empty())
.then(|| format!("\nstderr: {}", log.stderr))
.unwrap_or_default();
format!("\nfailed at stage: {}{stdout}{stderr}", log.stage)
})
.unwrap_or_default();
let blocks = vec![
Block::header(text.clone()),
Block::section(format!(
"build id: *{id}*\nbuild name: *{name}*\nversion: v{version}{err}",
"build id: *{id}*\nbuild name: *{name}*\nversion: v{version}",
)),
Block::section(resource_link(ResourceTargetVariant::Build, id))
];

View File

@@ -7,11 +7,8 @@ use typeshare::typeshare;
use crate::entities::{MongoId, I64};
use super::{
_Serror,
deployment::DeploymentState,
server::stats::SeverityLevel,
update::{Log, ResourceTarget},
Version,
_Serror, deployment::DeploymentState, server::stats::SeverityLevel,
update::ResourceTarget, Version,
};
/// Representation of an alert in the system.
@@ -170,8 +167,6 @@ pub enum AlertData {
name: String,
/// The version that failed to build
version: Version,
/// The reason build failed
err: Option<Log>,
},
}