fix: remove unnecessary blank line in Cloudflare Pages production workflow

Merge pull request #22 from Dokploy/fix/ci/cd
refactor: update build preview workflow for clarity and efficiency
2025-03-16 12:38:37 -06:00 · 2025-03-16 12:36:56 -06:00 · 2025-03-16 12:26:21 -06:00 · 2025-03-16 12:25:26 -06:00 · 2025-03-16 12:24:30 -06:00
3 changed files with 58 additions and 43 deletions
@@ -1,31 +1,24 @@
-name: "Build and Deploy Preview"
+name: Build Preview Deployment
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.number || github.sha }}
+  cancel-in-progress: true

 on:
  pull_request:
    types: [opened, synchronize]

 jobs:
-  build-and-deploy:
+  build-preview:
    runs-on: ubuntu-latest
-    name: Build and Deploy Preview
-    permissions:
-      contents: read
-      actions: write
-      pull-requests: write
-      deployments: write
    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v4
-        with:
-          node-version: '20'
-
-      - name: Setup pnpm
-        uses: pnpm/action-setup@v2
+      - uses: actions/checkout@v4
+      - uses: pnpm/action-setup@v4
        with:
          version: 8
+      - uses: actions/setup-node@v4
+        with:
+          node-version: 20

      - name: Install dependencies
        working-directory: app
@@ -34,32 +27,18 @@ jobs:
      - name: Build
        working-directory: app
        run: pnpm build
-
-      - name: List build output
-        run: ls -la app/dist
-
-      - name: Deploy to Cloudflare Pages
-        uses: AdrianGonz97/refined-cf-pages-action@v1
-        with:
-          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
-          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
-          githubToken: ${{ secrets.GITHUB_TOKEN }}
-          projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
-          deploymentName: Preview
-          directory: app/dist
+      # - name: Deploy to Cloudflare Pages
+      #   uses: AdrianGonz97/refined-cf-pages-action@v1
+      #   with:
+      #     apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
+      #     accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
+      #     githubToken: ${{ secrets.GITHUB_TOKEN }}
+      #     projectName: ${{ secrets.CLOUDFLARE_PROJECT_NAME }}
+      #     deploymentName: Preview
+      #     directory: app/dist

      - name: Upload build artifact
-        id: upload-artifact
        uses: actions/upload-artifact@v4
        with:
          name: preview-build
-          path: app/dist
-          retention-days: 1
-          
-      - name: Verify artifact upload
-        run: |
-          echo "Artifact upload completed"
-          echo "Workflow ID: ${{ github.run_id }}"
-          echo "Repository: ${{ github.repository }}"
-          echo "Event name: ${{ github.event_name }}"
-          echo "Event type: ${{ github.event.action }}" 
+          path: app/dist
@@ -20,7 +20,6 @@ jobs:
        uses: actions/setup-node@v4
        with:
          node-version: '20'
-
      - name: Setup pnpm
        uses: pnpm/action-setup@v2
        with:
@@ -0,0 +1,37 @@
+name: Upload Preview Deployment
+
+on:
+  workflow_run:
+    workflows: [Build Preview Deployment]
+    types:
+      - completed
+
+permissions:
+  actions: read
+  deployments: write
+  contents: read
+  pull-requests: write
+
+jobs:
+  deploy-preview:
+    runs-on: ubuntu-latest
+    if: ${{ github.event.workflow_run.conclusion == 'success' }}
+    steps:
+      - name: Download build artifact
+        uses: actions/download-artifact@v4
+        id: preview-build-artifact
+        with:
+          name: preview-build
+          path: build
+          github-token: ${{ secrets.GITHUB_TOKEN }}
+          run-id: ${{ github.event.workflow_run.id }}
+
+      - name: Deploy to Cloudflare Pages
+        uses: AdrianGonz97/refined-cf-pages-action@v1
+        with:
+          apiToken: ${{ secrets.CLOUDFLARE_API_TOKEN }}
+          accountId: ${{ secrets.CLOUDFLARE_ACCOUNT_ID }}
+          githubToken: ${{ secrets.GITHUB_TOKEN }}
+          projectName: templates
+          deploymentName: Preview
+          directory: ${{ steps.preview-build-artifact.outputs.download-path }}
Author	SHA1	Message	Date
Mauricio Siu	556ca55b18	fix: remove unnecessary blank line in Cloudflare Pages production workflow	2025-03-16 12:38:37 -06:00
Mauricio SiuandGitHub	e885e2be29	Merge pull request #22 from Dokploy/fix/ci/cd refactor: update build preview workflow for clarity and efficiency	2025-03-16 12:36:56 -06:00
Mauricio Siu	05c8bcd839	feat: add deploy preview workflow for Cloudflare Pages - Introduced a new GitHub Actions workflow to handle deployment of preview builds to Cloudflare Pages upon successful completion of the build preview workflow. - Configured necessary permissions and steps for downloading build artifacts and deploying to the specified Cloudflare project.	2025-03-16 12:26:21 -06:00
Mauricio Siu	04d83432df	fix: remove unnecessary comment from build preview workflow - Eliminated an internal issue comment from the artifact upload step for clarity. - Ensured the workflow remains clean and focused on essential configurations.	2025-03-16 12:25:26 -06:00
Mauricio Siu	0ef9970aff	refactor: update build preview workflow for clarity and efficiency - Renamed job to "Build Preview Deployment" and adjusted concurrency settings. - Streamlined steps by removing unnecessary permissions and comments. - Updated pnpm action to the latest version and ensured Node.js setup is consistent. - Removed deployment step to Cloudflare Pages and related verification steps for simplification.	2025-03-16 12:24:30 -06:00