Disable the "kasp" system test on Windows

MR !3771 added some checks to the "kasp" system test that always fail on
Windows.  This issue will be investigated in due course.  Until it is
addressed, prevent the "kasp" system test from being run on Windows.

CHANGES

@@ -1,20 +1,21 @@
+	--- 9.16.5 released ---
+
 5458.	[bug]		Prevent a theoretically possible NULL dereference caused
 			by a data race between zone_maintenance() and
 			dns_zone_setview_helper(). [GL #1627]
 
-5455.	[bug]		`named` could crash when cleaning dead nodes
-			in lib/dns/rbtdb.c that have been reused meanwhile.
-			[GL #1968]
+5455.	[bug]		named could crash when cleaning dead nodes in
+			lib/dns/rbtdb.c that were being reused. [GL #1968]
 
-5454.	[bug]		Address a startup crash happening when server is
-			under load and root zone is not yet loaded. [GL #1862]
+5454.	[bug]		Address a startup crash that occurred when the server
+			was under load and the root zone had not yet been
+			loaded. [GL #1862]
 
-5453.	[bug]		`named` would crash on shutdown when new `rndc`
-			connection is received at the same time as
-			shutting down. [GL #1747]
+5453.	[bug]		named crashed on shutdown when a new rndc connection was
+			received during shutdown. [GL #1747]
 
-5452.	[bug]		The "blackhole" ACL was accidentally disabled with
-			respect to client queries. [GL #1936]
+5452.	[bug]		The "blackhole" ACL was accidentally disabled for client
+			queries. [GL #1936]
 
 5451.	[func]		Add 'rndc dnssec -status' command. [GL #1612]
 
@@ -30,24 +31,24 @@
 
 5446.	[bug]		The validator could fail to accept a properly signed
 			RRset if an unsupported algorithm appeared earlier in
-			the DNSKEY RRset than a supported algorithm.  It could
+			the DNSKEY RRset than a supported algorithm. It could
 			also stop if it detected a malformed public key.
 			[GL #1689]
 
-5444.	[bug]		'rndc dnstap -roll <value>' was not limiting the
-			number of saved files to <value>. [GL !3728]
+5444.	[bug]		'rndc dnstap -roll <value>' did not limit the number of
+			saved files to <value>. [GL !3728]
 
 5443.	[bug]		The "primary" and "secondary" keywords, when used
 			as parameters for "check-names", were not
 			processed correctly and were being ignored. [GL #1949]
 
-5441.	[bug]		${LMDB_CFLAGS} missing from make/includes.in
+5441.	[bug]		${LMDB_CFLAGS} was missing from make/includes.in.
 			[GL #1955]
 
 5440.	[test]		Properly handle missing kyua. [GL #1950]
 
-5439.	[bug]		The dsset returned by dns_keynode_dsset() was not
-			thread safe. [GL #1926]
+5439.	[bug]		The DS RRset returned by dns_keynode_dsset() was used in
+			a non-thread-safe manner. [GL #1926]
 
 	--- 9.16.4 released ---
 

bin/tests/system/conf.sh.common

@@ -61,7 +61,7 @@ PARALLEL_COMMON="dnssec rpzrecurse serve-stale \
 	ednscompliance emptyzones \
 	fetchlimit filter-aaaa formerr forward \
 	geoip2 glue idna inline integrity ixfr \
-	kasp keepalive legacy limits \
+	keepalive legacy limits \
 	masterfile masterformat metadata mirror mkeys \
 	names notify nslookup nsupdate nzd2nzf \
 	padding pending pipelined qmin \

bin/tests/system/conf.sh.in

@@ -83,7 +83,7 @@ KRB5_CONFIG=/dev/null
 SEQUENTIAL_UNIX="@PKCS11_TEST@"
 SEQUENTIALDIRS="$SEQUENTIAL_COMMON $SEQUENTIAL_UNIX"
 
-PARALLEL_UNIX="@CHECKDS@ @COVERAGE@ @DNSTAP@ @KEYMGR@ logfileconfig"
+PARALLEL_UNIX="@CHECKDS@ @COVERAGE@ @DNSTAP@ kasp @KEYMGR@ logfileconfig"
 PARALLELDIRS="$PARALLEL_COMMON $PARALLEL_UNIX"
 
 SUBDIRS="$SEQUENTIALDIRS $PARALLELDIRS"

configure

@@ -17993,6 +17993,7 @@ fi
 
 
 
+
 #
 # was --with-libxml2 specified?
 #
@@ -20863,6 +20864,7 @@ fi
 
 
 
+
 #
 #  The following sets up how non-blocking i/o is established.
 #  cygwin and solaris 2.x (x<5) require special handling.

doc/arm/notes.rst

@@ -59,7 +59,7 @@ https://www.isc.org/download/. There you will find additional
 information about each release, source code, and pre-compiled versions
 for Microsoft Windows operating systems.
 
-.. include:: ../notes/notes-current.rst
+.. include:: ../notes/notes-9.16.5.rst
 .. include:: ../notes/notes-9.16.4.rst
 .. include:: ../notes/notes-9.16.3.rst
 .. include:: ../notes/notes-9.16.2.rst

doc/notes/notes-9.16.5.rst

@@ -0,0 +1,64 @@
+.. 
+   Copyright (C) Internet Systems Consortium, Inc. ("ISC")
+   
+   This Source Code Form is subject to the terms of the Mozilla Public
+   License, v. 2.0. If a copy of the MPL was not distributed with this
+   file, You can obtain one at http://mozilla.org/MPL/2.0/.
+   
+   See the COPYRIGHT file distributed with this work for additional
+   information regarding copyright ownership.
+
+Notes for BIND 9.16.5
+---------------------
+
+New Features
+~~~~~~~~~~~~
+
+- New ``rndc`` command ``rndc dnssec -status`` shows the current DNSSEC
+  policy and keys in use, the key states, and rollover status.
+  [GL #1612]
+
+Bug Fixes
+~~~~~~~~~
+
+- A race condition could occur if a TCP socket connection was closed
+  while ``named`` was waiting for a recursive response. The attempt to
+  send a response over the closing connection triggered an assertion
+  failure in the function ``isc__nm_tcpdns_send()``. [GL #1937]
+
+- A race condition could occur when ``named`` attempted to use a UDP
+  interface that was shutting down. This triggered an assertion failure
+  in ``uv__udp_finish_close()``. [GL #1938]
+
+- Fix assertion failure when server was under load and root zone had not
+  yet been loaded. [GL #1862]
+
+- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c``
+  that were being reused. [GL #1968]
+
+- ``named`` crashed on shutdown when a new ``rndc`` connection was
+  received during shutdown. This has been fixed. [GL #1747]
+
+- The DS RRset returned by ``dns_keynode_dsset()`` was used in a
+  non-thread-safe manner. This could result in an INSIST being
+  triggered. [GL #1926]
+
+- Properly handle missing ``kyua`` command so that ``make check`` does
+  not fail unexpectedly when CMocka is installed, but Kyua is not.
+  [GL #1950]
+
+- The ``primary`` and ``secondary`` keywords, when used as parameters
+  for ``check-names``, were not processed correctly and were being
+  ignored. [GL #1949]
+
+- ``rndc dnstap -roll <value>`` did not limit the number of saved files
+  to ``<value>``. [GL !3728]
+
+- The validator could fail to accept a properly signed RRset if an
+  unsupported algorithm appeared earlier in the DNSKEY RRset than a
+  supported algorithm. It could also stop if it detected a malformed
+  public key. [GL #1689]
+
+- The ``blackhole`` ACL was inadvertently disabled for client queries.
+  Blocked IP addresses were not used for upstream queries but queries
+  from those addresses could still be answered. [GL #1936]

doc/notes/notes-current.rst

@@ -1,70 +0,0 @@
-.. 
-   Copyright (C) Internet Systems Consortium, Inc. ("ISC")
-   
-   This Source Code Form is subject to the terms of the Mozilla Public
-   License, v. 2.0. If a copy of the MPL was not distributed with this
-   file, You can obtain one at http://mozilla.org/MPL/2.0/.
-   
-   See the COPYRIGHT file distributed with this work for additional
-   information regarding copyright ownership.
-
-Notes for BIND 9.16.5
----------------------
-
-Security Fixes
-~~~~~~~~~~~~~~
-
-- None.
-
-Known Issues
-~~~~~~~~~~~~
-
-- None.
-
-New Features
-~~~~~~~~~~~~
-
-- None.
-
-Feature Changes
-~~~~~~~~~~~~~~~
-
-- New ``rndc`` command ``rndc dnssec -status`` that shows the current
-  DNSSEC policy and keys in use, the key states and rollover status.
-  [GL #1612]
-
-Bug Fixes
-~~~~~~~~~
-
-- The DS set returned by ``dns_keynode_dsset()`` was not thread-safe.
-  This could result in an INSIST being triggered. [GL #1926]
-
-- Properly handle missing ``kyua`` command so that ``make check`` does
-  not fail unexpectedly when CMocka is installed, but Kyua is not.
-  [GL #1950]
-
-- The ``primary`` and ``secondary`` keywords, when used as parameters for
-  ``check-names``, were not processed correctly and were being ignored.
-  [GL #1949]
-
-- 'rndc dnstap -roll <value>' was not limiting the number of saved
-  files to <value>. [GL !3728]
-
-- The validator could fail to accept a properly signed RRset if an
-  unsupported algorithm appeared earlier in the DNSKEY RRset than a
-  supported algorithm.  It could also stop if it detected a malformed
-  public key. [GL #1689]
-
-- The ``blackhole`` ACL was inadvertently disabled with respect to
-  client queries. Blocked IP addresses were not used for upstream
-  queries but queries from those addresses could still be answered.
-  [GL #1936]
-
-- ``named`` would crash on shutdown when new ``rndc`` connection is received at
-  the same time as shutting down. [GL #1747]
-
-- Fix assertion failure when server is under load and root zone is not yet
-  loaded. [GL #1862]
-
-- ``named`` could crash when cleaning dead nodes in ``lib/dns/rbtdb.c`` that
-  have been reused meanwhile.  [GL #1968]

lib/bind9/api

@@ -11,5 +11,5 @@
 # 9.13/9.14: 1300-1499
 # 9.15/9.16: 1500-1699
 LIBINTERFACE = 1600
-LIBREVISION = 3
+LIBREVISION = 4
 LIBAGE = 0

lib/dns/api

@@ -10,6 +10,6 @@
 # 9.12: 1200-1299
 # 9.13/9.14: 1300-1499
 # 9.15/9.16: 1500-1699
-LIBINTERFACE = 1604
+LIBINTERFACE = 1605
 LIBREVISION = 0
-LIBAGE = 1
+LIBAGE = 0

lib/isc/api

@@ -10,6 +10,6 @@
 # 9.12: 1200-1299
 # 9.13/9.14: 1300-1499
 # 9.15/9.16: 1500-1699
-LIBINTERFACE = 1604
+LIBINTERFACE = 1605
 LIBREVISION = 0
-LIBAGE = 1
+LIBAGE = 0

lib/ns/api

@@ -10,6 +10,6 @@
 # 9.12: 1200-1299
 # 9.13/9.14: 1300-1499
 # 9.15/9.16: 1500-1699
-LIBINTERFACE = 1603
-LIBREVISION = 1
+LIBINTERFACE = 1604
+LIBREVISION = 0
 LIBAGE = 0

util/copyrights

@@ -1449,7 +1449,7 @@
 ./doc/notes/notes-9.16.2.rst			RST	2020
 ./doc/notes/notes-9.16.3.rst			RST	2020
 ./doc/notes/notes-9.16.4.rst			RST	2020
-./doc/notes/notes-current.rst			RST	2020
+./doc/notes/notes-9.16.5.rst			RST	2020
 ./docutil/HTML_COPYRIGHT			X	2001,2004,2016,2018,2019,2020
 ./docutil/MAN_COPYRIGHT				X	2001,2004,2016,2018,2019,2020
 ./docutil/patch-db2latex-duplicate-template-bug	X	2007,2018,2019,2020

version

@@ -5,7 +5,7 @@ PRODUCT=BIND
 DESCRIPTION="(Stable Release)"
 MAJORVER=9
 MINORVER=16
-PATCHVER=4
+PATCHVER=5
 RELEASETYPE=
 RELEASEVER=
 EXTENSIONS=