ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity
26,793 Commits 589 Branches 805 Tags
f2ca287330110993609fa0443d3bdb17629bd979
Commit Graph

26793 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Michał Kępień
f2ca287330 Fix a shutdown race in bin/dig/dighost.c 
If a tool using the routines defined in bin/dig/dighost.c is sent an
interruption signal around the time a connection timeout is scheduled to
fire, connect_timeout() may be executed after destroy_libs() detaches
from the global task (setting 'global_task' to NULL), which results in a
crash upon a UDP retry due to bringup_timer() attempting to create a
timer with 'task' set to NULL.  Fix by preventing connect_timeout() from
attempting a retry when shutdown is in progress.

(cherry picked from commit 4621756596)
 2018-11-13 13:52:48 +01:00
Evan Hunt
83544b0bdf Merge branch 'fix-rules-typo-v9_11' into 'v9_11' 
fix rules.in typo

See merge request isc-projects/bind9!1038
 2018-11-13 03:41:48 -05:00
Evan Hunt
df3b061c99 fix typo 
(cherry picked from commit 9671909289)
 2018-11-13 00:24:43 -08:00
Mark Andrews
0bd7e3de57 Merge branch 'autoheader-v9_11' into 'v9_11' 
autoheader

See merge request isc-projects/bind9!1031
 2018-11-12 18:13:05 -05:00
Mark Andrews
107fd6758d autoheader 2018-11-12 18:01:28 -05:00
Mark Andrews
54a3d2ac63 Merge branch 'fix-test-linkages-v9_11' into 'v9_11' 
Fix test linkages

See merge request isc-projects/bind9!1029
 2018-11-12 16:01:04 -05:00
Mark Andrews
03f2cc49e3 remove lib/isc/tests/result_test as it is now cmocka 
(cherry picked from commit 9024cf0c15)
 2018-11-13 07:50:51 +11:00
Mark Andrews
173827f78d fixup 
(cherry picked from commit ba0e5ffc09)
 2018-11-13 07:50:49 +11:00
Mark Andrews
ffc56a4bf3 link in lib/isccc/tests/Kyuafile 
(cherry picked from commit 9a59352b4c)
 2018-11-13 07:50:30 +11:00
Mark Andrews
ab5a68b3b1 Merge branch 'backport-require-cmocka-greater-than-or-equal-1.0.0-v9_11' into 'v9_11' 
require cmocka >= 1.0.0

See merge request isc-projects/bind9!1024
 2018-11-12 03:03:17 -05:00
Mark Andrews
58812a4641 define CMOCKA_CFLAGS and CMOCKA_LIBS 
(cherry picked from commit 1e8cdc20f3)
 2018-11-12 18:42:58 +11:00
Mark Andrews
0c738a5673 require cmocka >= 1.0.0 
(cherry picked from commit f3ff5f63ac)
 2018-11-12 18:42:58 +11:00
Mark Andrews
c8d522dd36 Merge branch '351-fix-with-cmocka=path-build-v9_11' into 'v9_11' 
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1021
 2018-11-12 01:49:36 -05:00
Ondřej Surý
6b50da7ba8 Use cmocka_set_message_output as test function for cmocka presence 
(cherry picked from commit 0158c1a4ea)
 2018-11-12 17:25:30 +11:00
Mark Andrews
8da45fcab7 Merge branch '351-disable-cmocka-by-default-v9_11' into 'v9_11' 
Resolve "configure fails unless --enable-developer is specified"

See merge request isc-projects/bind9!1018
 2018-11-12 00:24:29 -05:00
Ondřej Surý
760e336e89 Set with_cmocka=no by default 
(cherry picked from commit ed8000f333)
 2018-11-12 00:01:24 -05:00
Mark Andrews
7d2451460d Merge branch '676-isc_result_toid-tables-not-complete-v9_11' into 'v9_11' 
Resolve "isc_result_toid tables not complete"

See merge request isc-projects/bind9!1017
 2018-11-11 23:58:05 -05:00
Evan Hunt
181c5442b9 convert result tests to use CMocka instead of ATF 
(cherry picked from commit 471110933a)
 2018-11-12 15:38:50 +11:00
Mark Andrews
af5a051e4d check result tables are complete 
(cherry picked from commit 4f04a79250)
 2018-11-12 15:32:58 +11:00
Mark Andrews
c9e712e528 Merge branch '250-integrate-cmocka-into-our-build-scripts-v9_11' into 'v9_11' 
Add cmocka support to infrastructure (build) files

See merge request isc-projects/bind9!1015
 2018-11-11 21:10:13 -05:00
Ondřej Surý
22c0f129ae Add support for cmocka assert testing by overriding REQUIRE/INSIST/... macros when UNIT_TESTING is defined 
(cherry picked from commit 52731c000d)
 2018-11-12 12:56:15 +11:00
Ondřej Surý
2dcc521b29 Add --wrap linker option detection 
(cherry picked from commit 10535d1c79)
 2018-11-12 12:54:59 +11:00
Ondřej Surý
4c8112ec01 Enforce TAP output from cmocka based unit tests 
(cherry picked from commit bd2ddec58f)
 2018-11-12 12:53:21 +11:00
Ondřej Surý
b0745fb156 Integrate cmocka unit testing framework to kyua 
(cherry picked from commit 07910f0153)
 2018-11-12 12:53:15 +11:00
Ondřej Surý
dc05021a4b Merge branch '451-fix-atomic-int-lock-free-usage-v9_11' into 'v9_11' 
(v9_11) Properly use ATOMIC_*_LOCK_FREE preprocessor constants

See merge request isc-projects/bind9!1003
 2018-11-08 17:19:16 -05:00
Ondřej Surý
9000f73ba3 Properly use ATOMIC_*_LOCK_FREE preprocessor constants 
The ATOMIC_*_LOCK_FREE can evalutate either 0, 1, or 2 which indicate the
lock-free property of the corresponding atomic types (both signed and unsigned).

	Value	Explanation
	-----	--------------------------------------
	  0	The atomic type is never lock-free
	  1	The atomic type is sometimes lock-free
	  2	The atomic type is always lock-free
	-----	--------------------------------------

(cherry picked from commit a5e7901eb9)
 2018-11-09 05:00:32 +07:00
Ondřej Surý
9e978d7416 Merge branch '449-isc_stdtime_t-post-stdint-cleanup-v9_11' into 'v9_11' 
(v9_11) Resolve "Follow-up from "Redefine ISC's int and boolean types to use <stdint.h> and <stdbool.h> types""

See merge request isc-projects/bind9!1002
 2018-11-08 15:19:31 -05:00
Ondřej Surý
ba263b5b7e isc_stdtime_t is always 32-bit now, so remove the always true macro STDTIME_ON_32BITS 
(cherry picked from commit 6f5fe11f5a)
 2018-11-09 03:04:22 +07:00
Ondřej Surý
ecc40b18e6 Merge branch '656-add-support-for-utimaco-hsm-v9_11' into 'v9_11' 
Resolve "Add support for Utimaco HSM"

See merge request isc-projects/bind9!972
 2018-11-08 12:34:22 -05:00
Ondřej Surý
ebe63fd316 Add CHANGES entry for GL #656 2018-11-09 00:12:39 +07:00
Ondřej Surý
52784fc3cc Disable runtime detection of md5 and sha1 support for Utimaco HSM. 
Utimaco HSM requires user to be logged in before executing DigestUpdate, thus
breaking dst_lib_init2 that ran isc_md5_check and isc_sha1_check before sending
PIN to the HSM.  Therefore isc_*_check needs to be disabled when Utimaco HSM is
being used as PKCS#11 library.
 2018-11-09 00:07:55 +07:00
Ondřej Surý
2079e44fb9 Define PK11_UTIMACO_FLAVOR and add detection code to configure.ac 2018-11-09 00:07:44 +07:00
Ondřej Surý
62819dcfba Merge branch '305-misc-fixes-v9_12-v9_11' into 'v9_11' 
(v9_11) Miscellaneous style fixes - implicit casts to bool and uninitialized variables fixes

See merge request isc-projects/bind9!995
 2018-11-08 11:15:03 -05:00
Ondřej Surý
29601a6e7e Disable Ed448 algorithm, the implementation in BIND 9 is incomplete and broken 
(cherry picked from commit 03c7bb9ab3)
 2018-11-08 22:42:52 +07:00
Ondřej Surý
c5b54803cd Remove dummy ISLOCKED macro 
(cherry picked from commit 68ca987792)
(cherry picked from commit 5ad72603a8)
 2018-11-08 22:42:52 +07:00
Ondřej Surý
2f8b28efad Hint the compiler with ISC_UNREACHABLE(); that code after INSIST(0); cannot be reached 
(cherry picked from commit 23fff6c569)
(cherry picked from commit 4568669807)
 2018-11-08 22:42:52 +07:00
Ondřej Surý
baa5811623 Modify the dbversion_test.c to detect disabled assertions 
(cherry picked from commit b992b5b811)
(cherry picked from commit ce6ef5b50e)
 2018-11-08 22:03:33 +07:00
Ondřej Surý
6aa63d9349 Add extra return failure after INSIST(0) in default branch 
(cherry picked from commit 29c45200e7)
(cherry picked from commit 2a26189256)
 2018-11-08 22:03:33 +07:00
Ondřej Surý
d894b2da79 Use larger buffers on snprintf buffer overflow false positives 
(cherry picked from commit 4eaf927571)
(cherry picked from commit 65536fb10b)
 2018-11-08 22:03:33 +07:00
Ondřej Surý
c576cb2ff6 Don't assert on failed getrlimit call to allow called to handle this gracefully as it already does, just abort where we need to know the numbers 
(cherry picked from commit e2e138a801)
(cherry picked from commit 1e6329038b)
 2018-11-08 22:03:31 +07:00
Ondřej Surý
f1224b4af1 When ISC assertions are disabled, still execute the condition to prevent unused variable warnings/errors from the compiler 
(cherry picked from commit a831e0f72d)
(cherry picked from commit 3d834566f1)
 2018-11-08 22:03:00 +07:00
Ondřej Surý
7eb962ee14 Add a GitLab CI job that runs with all assertions disabled 
(cherry picked from commit 461ffead1f)
(cherry picked from commit c5825eba40)
 2018-11-08 22:03:00 +07:00
Ondřej Surý
12a266211e Turn (int & flag) into (int & flag) != 0 when implicitly typed to bool 
(cherry picked from commit b2b43fd235)
(cherry picked from commit fcd1569e2b)
 2018-11-08 22:02:58 +07:00
Ondřej Surý
9d15323e24 Add small tweaks to the code to fix compilation when ISC assertions are disabled 
While implementing the new unit testing framework cmocka, it was found that the
BIND 9 code doesn't compile when assertions are disabled or replaced with any
function (such as mock_assert() from cmocka unit testing framework) that's not
directly recognized as assertion by the compiler.

This made the compiler to complain about blocks of code that was recognized as
unreachable before, but now it isn't.

The changes in this commit include:

* assigns default values to couple of local variables,
* moves some return statements around INSIST assertions,
* adds __builtin_unreachable(); annotations after some INSIST assertions,
* fixes one broken assertion (= instead of ==)

(cherry picked from commit fbd2e47f51)
(cherry picked from commit b222783ae9)
 2018-11-08 22:00:49 +07:00
Mark Andrews
76983d693e Merge branch 'wpk-get-rid-of-bashism-in-CDS-test-v9_11' into 'v9_11' 
Small system tests fixes for Solaris

See merge request isc-projects/bind9!992
 2018-11-07 20:36:40 -05:00
Witold Krecicki
2db31ececa Remove unnecessary sed from autosign test 
(cherry picked from commit 82dfb77328)
 2018-11-08 12:26:04 +11:00
Witold Krecicki
4b9d115e35 Use 'local' variable in echo functions in tests 
(cherry picked from commit 0949b1fe2c)
 2018-11-08 12:26:01 +11:00
Mark Andrews
93efc4724f Merge branch '653-idnout-only-on-tty-v9_11' into 'v9_11' 
Enable idnout output only on tty, disable it when the stdout is not a tty

See merge request isc-projects/bind9!984
 2018-11-06 19:50:15 -05:00
Ondřej Surý
0dd034d66b Add CHANGES entry for GL #653 
(cherry picked from commit 9c0c44405c)
 2018-11-07 11:37:11 +11:00
Ondřej Surý
31a974bc05 Add release notes for IDN processing update 
(cherry picked from commit 2a11a7dd29)
 2018-11-07 11:37:11 +11:00