Commit Graph
28342 Commits
Author SHA1 Message Date
Mark Andrews eeaffbe07d Silence Coverity CHECKED_RETURN warnings
CID 1458403 (#1 of 1): Unchecked return value (CHECKED_RETURN)
	8. check_return: Calling isc_socket_recv without checking
	return value (as is done elsewhere 14 out of 17 times).

121        isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);

	CID 1458402 (#1 of 1): Unchecked return value (CHECKED_RETURN)
	2. check_return: Calling isc_socket_recv without checking
	return value (as is done elsewhere 14 out of 17 times).

149        isc_socket_recv(sock, &dev->region, 1, task, my_recv, event->ev_arg);

	CID 1458401 (#1 of 1): Unchecked return value (CHECKED_RETURN)
	6. check_return: Calling isc_socket_recv without checking
	return value (as is done elsewhere 14 out of 17 times).

226                isc_socket_recv(dev->newsocket, &region, 1,
227                                newtask, my_recv, event->ev_arg);
2020-02-11 13:02:08 +00:00
Ondřej Surý 5f90f2ac6c Merge branch 'ondrej/remove-OpenSSL-engine-specification-in-label-v9_11' into 'v9_11'
[v9_11] Cleanup support for specifying PKCS#11 engine as part of the label

See merge request isc-projects/bind9!3034
2020-02-11 10:51:42 +00:00
Ondřej SurýandMichał Kępień ce2198c7c2 Remove reference to prepending label with engine in manpage
(cherry picked from commit 33fa3d5eb1)
2020-02-11 10:42:35 +01:00
Ondřej SurýandMichał Kępień cb2dde567c Cleanup support for specifying PKCS#11 engine as part of the label
The code for specifying OpenSSL PKCS#11 engine as part of the label
(e.g. -l "pkcs11:token=..." instead of -E pkcs11 -l "token=...")
was non-functional.  This commit just cleans the related code.

(cherry picked from commit a5c87d9d18)
2020-02-11 10:42:33 +01:00
Evan Hunt 1c76f9f5b3 Merge branch '932-doc-query-error-logging-v9_11' into 'v9_11'
improve documentation of query logging

See merge request isc-projects/bind9!3028
2020-02-09 00:09:03 +00:00
Evan Hunt f68d30bc60 improve documentation of query logging
(cherry picked from commit 21bb9fa77f)
2020-02-08 16:08:39 -08:00
Ondřej Surý 942224e8bc Merge branch '1560-isc_httpd-and-isc_httpdmgr-structures-are-not-reference-counted-and-magic-v9_11' into 'v9_11'
Resolve "isc_httpd and isc_httpdmgr structures are not reference counted and magic"

See merge request isc-projects/bind9!2940
2020-02-08 20:21:29 +00:00
Ondřej Surý 699bda8de7 Clean the ENTER/EXIT/NOTICE debugging from production code
(cherry picked from commit 5b448996e5)
2020-02-08 11:46:37 -08:00
Ondřej Surý f2c5bdda21 Refactor parts of isc_httpd and isc_httpd for better readability and safety
(cherry picked from commit 9643a62dd5)
2020-02-08 11:46:37 -08:00
Mark AndrewsandOndřej Surý e5522d114b add ISC_MAGIC and reference counting to httpd and httpdmgr
(cherry picked from commit 7c3f419d66)
2020-02-08 11:37:25 -08:00
Ondřej Surý 5323ed870b Merge branch 'cppcheck-1.90-warnings-v9_11' into 'v9_11'
Cppcheck 1.90 warnings v9 11

See merge request isc-projects/bind9!3001
2020-02-08 14:48:40 +00:00
Matthijs MekkingandOndřej Surý ea477e114b mem.c: delay assignment until after REQUIRE 2020-02-08 06:32:42 -08:00
Matthijs MekkingandOndřej Surý c8959c0e3a Check for basic blocks not NULL 2020-02-08 06:32:42 -08:00
Matthijs MekkingandOndřej Surý 4af46a8574 rdata: delay assignment until after REQUIRE 2020-02-08 06:32:42 -08:00
Matthijs MekkingandOndřej Surý 86184dfb68 Suppress cppcheck false positive nullPointerRedundantCheck 2020-02-08 06:32:42 -08:00
Ondřej Surý b54eeb1231 Suppress unknownMacro directive which is currently broken with OpenSSL
(cherry picked from commit 2868eafc46)
2020-02-08 06:32:42 -08:00
Mark AndrewsandOndřej Surý 74c142c972 skip if first is NULL
(manually picked from 704b9ee9d0)
2020-02-08 06:32:42 -08:00
Mark AndrewsandOndřej Surý 39cb4dc6c9 delay assignment until after REQUIRE
(cherry picked from commit c65c06301c)
2020-02-08 06:32:42 -08:00
Mark AndrewsandOndřej Surý 12cda20aa2 simplify ISC_LIKELY/ISC_UNLIKELY for CPPCHECK
(cherry picked from commit 6c2e138d7a)
2020-02-08 06:32:42 -08:00
Mark AndrewsandOndřej Surý 26caad3c12 simplify RUNTIME_CHECK for cppcheck
(cherry picked from commit 668a972d1e)
2020-02-08 06:32:42 -08:00
Mark Andrews 3f68ed9ad0 Merge branch '1596-echo_ic-should-be-used-for-continuations-v9_11' into 'v9_11'
Resolve "echo_ic should be used for continuations."

See merge request isc-projects/bind9!3022
2020-02-07 22:06:05 +00:00
Mark Andrews aef2c41e79 indent failed: descriptions
(cherry picked from commit 1e4773f121)
2020-02-08 08:47:42 +11:00
Mark Andrews ffac1eb5e6 indent some test descriptions/continuation
(cherry picked from commit ec95bc6f2c)
2020-02-08 08:44:43 +11:00
Mark Andrews f63bfc7928 remove space before 'failed'
(cherry picked from commit 0d5ec0c7dc)
2020-02-08 08:42:04 +11:00
Mark Andrews 4f6083138e ident continuation of test descriptions
(cherry picked from commit 059b16b991)
2020-02-08 08:42:04 +11:00
Mark Andrews 41173c0af9 remove space from before 'failed'; count errors
(cherry picked from commit 879c63b573)
2020-02-08 08:41:59 +11:00
Mark Andrews b700eb672f Merge branch '1559-dnssec-system-test-failed-reload-of-root-server-not-completed-in-time-v9_11' into 'v9_11'
wait for root server to complete reloading

See merge request isc-projects/bind9!3019
2020-02-07 21:09:02 +00:00
Mark Andrews 85af984040 wait for root server to complete reloading
(cherry picked from commit 784e64f238)
2020-02-07 14:14:18 +00:00
Mark Andrews 319efe25b3 Merge branch '1599-autosign-conversion-from-nsec3-to-nsec-can-take-more-than-2-seconds-v9_11' into 'v9_11'
wait a short while for no NSEC3PARAM

See merge request isc-projects/bind9!3017
2020-02-07 14:08:40 +00:00
Mark Andrews 870bb60456 wait a short while for no NSEC3PARAM
(cherry picked from commit e378241324)
2020-02-08 00:43:23 +11:00
Michał Kępień 7b91eea23c Merge branch 'marka-coverity-dns-db-find-v9_11' into 'v9_11'
Marka coverity dns db find v9 11

See merge request isc-projects/bind9!3015
2020-02-07 11:18:40 +00:00
Mark Andrews 2543bfe0d2 Fix indenting.
(cherry picked from commit 98d5109e82)
2020-02-07 21:43:57 +11:00
Mark Andrews 9ea647f7e9 Correct logged function name.
(cherry picked from commit 550bbee427)
2020-02-07 21:43:57 +11:00
Michał Kępień ff47e46b91 Merge branch 'michal/fix-the-dnssec-system-test-on-windows-v9_11' into 'v9_11'
[v9_11] Fix the "dnssec" system test on Windows

See merge request isc-projects/bind9!3013
2020-02-06 14:20:58 +00:00
Michał Kępień 9d5d2c9d20 Fix the "dnssec" system test on Windows
Make sure carriage return characters are stripped from awk input to
enable the "dnssec" system test to pass on Windows.

(cherry picked from commit 2f694f0b77)
2020-02-06 15:19:22 +01:00
Matthijs Mekking dc68067388 Merge branch '914-forwarders-port-documentation-v9_11' into 'v9_11'
Document forwarders config port and dscp param

See merge request isc-projects/bind9!3009
2020-02-06 09:40:00 +00:00
Matthijs Mekking 8585624733 Document forwarders config port and dscp param
(cherry picked from commit be3a11029a)
2020-02-06 10:13:45 +01:00
Michal Nowak 0fa51cefad Merge branch 'mnowak/windows-raise-port-range-v9_11' into 'v9_11'
[v9_11] Windows: Prevent tools from clashing with named in system tests

See merge request isc-projects/bind9!3003
2020-02-05 11:07:33 +00:00
Michal Nowak 0e284831ce Windows: Prevent tools from clashing with named in system tests
In system tests on Windows tool's local port can sometimes clash with
'named'. On Unix the system is poked for the minimal local port,
otherwise is set to 32768 as a sane minimum. For Windows we don't
poke but set a hardcoded limit; this change aligns the limit with
Unix and changes it to 32768.

(cherry picked from commit ed7fe5fae3b22d136f0a5a92ea3b67536b10a5ce)
2020-02-05 11:07:33 +00:00
Michał Kępień 69efd2e77d Merge branch '1305-update-gitlab-ci-to-openbsd-6.6-v9_11' into 'v9_11'
[v9_11] Update GitLab CI to OpenBSD 6.6

See merge request isc-projects/bind9!2995
2020-02-04 10:46:25 +00:00
Michał Kępień f36b39adc2 Update GitLab CI to OpenBSD 6.6
Since OpenBSD 6.6 is the current OpenBSD release, replace OpenBSD 6.5
GitLab CI jobs with their up-to-date counterparts.

As CI jobs for OpenBSD 6.6 will be run by a generalized libvirt executor
rather than an OpenBSD-specific one, make the necessary tag and variable
adjustments as well.

(cherry picked from commit 99ed3a0e13)
2020-02-04 11:44:32 +01:00
Evan Hunt 6aa4b590ca Merge branch '1592-catz-filename-v9_11' into 'v9_11'
Resolve "catalog zones fail if a zone name contains a slash"

See merge request isc-projects/bind9!2993
2020-02-04 06:00:00 +00:00
Evan Hunt a4021838de CHANGES
(cherry picked from commit 7a002c7ece)
2020-02-03 19:46:21 -08:00
Mark AndrewsandEvan Hunt c02d947772 don't swallow backslash characters in test output
(cherry picked from commit fc4e44bd37)
2020-02-03 19:46:17 -08:00
Mark AndrewsandEvan Hunt a68a187edf test all the scenarios for hashed filenames together
(cherry picked from commit 8745043a86)
2020-02-03 19:30:35 -08:00
Evan Hunt edee4f93c5 Correctly handle catalog zone entries containing slashes
- Add quotes before and after zone name when generating "addzone"
  input so avoid "unexpected token" errors.
- Use a hex digest for zone filenames when the zone or view name
  contains a slash.
- Test with a domain name containing a slash.
- Incidentally added 'catzhash.py' to contrib/scripts to generate
  hash labels for catalog zones, as it was needed to write the test.

(cherry picked from commit dba0163dac)
2020-02-03 19:23:37 -08:00
Michal Nowak 57050ea8d1 Merge branch 'mnowak/drop-kyua-report-verbose-option-v9_11' into 'v9_11'
[v9_11] Drop kyua report's --verbose option

See merge request isc-projects/bind9!2983
2020-01-31 09:14:33 +00:00
Michal Nowak 145f754fc4 Drop kyua report's --verbose option
It prints far more than needed.

(cherry picked from commit 5d14ed8465ccb1cb35bdbdeba2e0143b62b5455c)
2020-01-31 09:14:33 +00:00
Mark Andrews fe6307450b Merge branch '1554-cds-cdnskey-consistency-checks-don-t-work-with-deletion-records-v9_11' into 'v9_11'
Resolve "CDS / CDNSKEY consistency checks don't work with deletion records"

See merge request isc-projects/bind9!2978
2020-01-31 00:57:52 +00:00
Mark Andrews f9390767f6 add CHANGES
(cherry picked from commit 272a31f758)
2020-01-31 11:33:27 +11:00