Commit Graph

35170 Commits

Author SHA1 Message Date
Aram Sargsyan
eeaa830ecd Add an "rpz" system test check for a failed reconfiguration
The faulty "DLZ" configuration triggers a reconfiguration failure
in such a place where view reverting code is covered.

(cherry picked from commit 95f4bac002)
2023-02-27 08:42:34 +00:00
Michal Nowak
7f90dc8d8d Merge branch 'mnowak/freebsd-12.4-v9_16' into 'v9_16'
[9.16] Add FreeBSD 12.4

See merge request isc-projects/bind9!7600
2023-02-24 13:30:44 +00:00
Michal Nowak
e3a1945d3c Add FreeBSD 12.4
(cherry picked from commit 2307661b1a)
2023-02-24 14:11:49 +01:00
Michal Nowak
76ad247785 Merge branch 'mnowak/alpine-3.17-v9_16' into 'v9_16'
[9.16] Add Alpine Linux 3.17

See merge request isc-projects/bind9!7597
2023-02-24 13:09:53 +00:00
Michal Nowak
850f865856 Drop date from "Regularly Tested Platforms" section
Changing the date is easy to forget and may be outdated.

(cherry picked from commit 5783280b10)
2023-02-24 13:26:40 +01:00
Michal Nowak
1d3d73b997 Add Alpine Linux 3.17
(cherry picked from commit 345089ad23)
2023-02-24 13:25:15 +01:00
Michal Nowak
cbae4704c5 Merge branch 'mnowak/set-TEST_PARALLEL_JOBS-to-four' into 'v9_16'
[9.16] Update the TEST_PARALLEL_JOBS value in CI

See merge request isc-projects/bind9!7594
2023-02-24 09:42:11 +00:00
Tom Krizek
6a975344a2 Update the TEST_PARALLEL_JOBS value in CI
The tests have been executed with four jobs for a long time because the
TEST_PARALLEL_JOBS variable was set to 4 in the project's CI/CD
Variables Settings. The variable was recently dropped in favor of
.gitlab-ci.yaml one and now needs to be streamlined with the rest of
BIND 9 maintained branches.

(cherry picked from commit 03d7b45d81)
2023-02-24 10:08:04 +01:00
Michal Nowak
7d4b21067f Merge branch 'mnowak/update_TEST_PARALLEL_JOBS_for_BSD-v9_16' into 'v9_16'
[9.16] Disable OpenBSD system test parallelism in CI

See merge request isc-projects/bind9!7593
2023-02-24 09:05:35 +00:00
Michal Nowak
208d49a28d Disable OpenBSD system test parallelism in CI
Make OpenBSD system tests more stable by disabling parallelism in CI.

Accordingly, they will run 3-4 times longer.

(cherry picked from commit d73eba57bd)
2023-02-24 09:58:38 +01:00
Michal Nowak
6a5459c9df Do not set TEST_PARALLEL_JOBS in FreeBSD system test
Setting TEST_PARALLEL_JOBS to 4 in FreeBSD system test jobs is a no-op
because it's already set to 4, one level above, on the global level.

(cherry picked from commit cf46addf51)
2023-02-24 09:58:38 +01:00
Ondřej Surý
f3422838fc Merge branch 'ondrej-restore-sonarcloud-analysis-v9_16' into 'v9_16'
[9.16] Add SonarCloud GitHub Action

See merge request isc-projects/bind9!7592
2023-02-24 08:57:53 +00:00
Ondřej Surý
973f2ebdcc Add SonarCloud GitHub Action
Add new SonarCloud GitHub Action and configuration; something (maybe
the way the builds were submitted) has apparently changed and the
project got deleted and the analysis wasn't working.

(cherry picked from commit 4bfbb4ddf7)
2023-02-24 09:54:59 +01:00
Michal Nowak
9a3364df3a Merge branch 'mnowak/logfileconfig-fix-rndc_conf_does_not_exist' into 'v9_16'
Stop logfileconfig/ns1 server with TERM signal

See merge request isc-projects/bind9!7581
2023-02-23 16:06:08 +00:00
Michal Nowak
e8918b1304 Stop logfileconfig/ns1 server with TERM signal
stop.pl tries to stop ns1 via rndc but fails to find rndc.conf because
the logfileconfig test code is unexpectedly executed from the
logfileconfig/ns1/ directory. Instead of stopping ns1 with rndc, it
waits for 30 seconds and then terminates ns1 with the TERM signal.

    I:logfileconfig:testing default logfile using named -L file (9)
    rndc: ../common/rndc.conf does not exist

Stopping ns1 with rndc was recently inadvertently introduced in
172826bfa8. Stop ns1 with the TERM signal
directly, as we did before.
2023-02-23 16:52:59 +01:00
Matthijs Mekking
d026b020b8 Merge branch 'marka-fixup-named_zone_configure-v9_16' into 'v9_16'
[9.16] Fix dns_kasp_attach / dns_kasp_detach usage - Fix backport error

See merge request isc-projects/bind9!7583
2023-02-23 08:30:11 +00:00
Mark Andrews
e4b5ca92ea Fix backport error in 84929d1cd7
Not all the RETERR's in named_zone_configure where converted to
CHECK's, as was the case in main, leading to a memory leak with
the early returns.
2023-02-23 18:13:58 +11:00
Tom Krizek
975895c05b Merge branch '3622-serve-stale-rrsig-test-v9_16' into 'v9_16'
[9.16][CVE-2022-3736] Test RRSIG queries with serve-stale enabled

See merge request isc-projects/bind9!7580
2023-02-22 13:31:49 +00:00
Mark Andrews
f0cbe3ab1f Test RRSIG queries with serve-stale enabled
Make RRSIG queries where the existing tests trigger a DNS_EVENT_TRYSTALE
event.

(cherry picked from commit add40273df)
2023-02-22 14:01:56 +01:00
Tom Krizek
4af1b2f660 Merge branch '3619-serve-stale-client-timeout-crash-test-v9_16' into 'v9_16'
[9.16][CVE-2022-3924] Add a reproducer for the serve-stale crash when recursive clients soft quota is reached

See merge request isc-projects/bind9!7577
2023-02-22 12:27:24 +00:00
Aram Sargsyan
d6568bea7c Add tests for CVE-2022-3924
Reproduce the assertion by configuring a 'named' resolver with
'recursive-clients 10;' configuration option and running 20
queries is parallel.

Also tweak the 'ans2/ans.pl' to simulate a 50ms network latency
when qname starts with "latency". This makes sure that queries
running in parallel don't get served immediately, thus allowing
the configured recursive clients quota limitation to be activated.

(cherry picked from commit 4b52b0b4a9)
2023-02-22 10:59:31 +01:00
Matthijs Mekking
84929d1cd7 Merge branch 'matthijs-fix-kasp-attach-detach-usage-v9_16' into 'v9_16'
[9.16] Fix dns_kasp_attach / dns_kasp_detach usage

See merge request isc-projects/bind9!7567
2023-02-22 07:26:35 +00:00
Mark Andrews
b49a3a56c9 Fix dns_kasp_attach / dns_kasp_detach usage
The kasp pointers in dns_zone_t should consistently be changed by
dns_kasp_attach and dns_kasp_detach so the usage is balanced.

(cherry picked from commit b41882cc75)
2023-02-21 16:58:42 +01:00
Tom Krizek
e920857601 Merge branch '3874-the-7530-broke-mkeys-test-on-windows' into 'v9_16'
Resolve "The !7530 broke mkeys test on Windows"

See merge request isc-projects/bind9!7550
2023-02-20 13:32:27 +00:00
Mark Andrews
552b5152a0 Source conf.sh the v9_16 way 2023-02-19 10:59:08 +00:00
Mark Andrews
7279c3826e Merge branch '3879-hmac_createctx-fails-to-free-context-on-isc_hmac_init-failure-v9_16' into 'v9_16'
[9.16] Resolve "hmac_createctx fails to free context on isc_hmac_init failure"

See merge request isc-projects/bind9!7557
2023-02-18 00:49:48 +00:00
Mark Andrews
d0c92a31a9 In hmac_createctx free ctx on isc_hmac_init failure
(cherry picked from commit d22257a370)
2023-02-18 10:27:11 +11:00
Michal Nowak
4b64ccf50e Merge branch 'mnowak/qa-tools-update-v9_16' into 'v9_16'
[9.16] Python formatting updates

See merge request isc-projects/bind9!7554
2023-02-17 17:59:14 +00:00
Michal Nowak
e0158ab2b5 Adapt to Python scripts to black 23.1.0
(cherry picked from commit 3cd2cc6254)
2023-02-17 16:55:47 +01:00
Michal Nowak
596918c57a Fix unnecessary "else" after "raise" with pylint 2.16.2
bin/tests/system/get_algorithms.py:225:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise)

(cherry picked from commit 8064ac6bec)
2023-02-17 16:55:24 +01:00
Michal Nowak
17b954141b Merge branch 'mnowak/enable-windows-system-tests-in-merge-requests' into 'v9_16'
Run system:msvc:windows:amd64 for merge requests

See merge request isc-projects/bind9!7543
2023-02-16 19:37:52 +00:00
Michal Nowak
7221221fd7 Run system:msvc:windows:amd64 for merge requests
Historically, we avoided running system tests on Windows for merge
request-triggered pipelines because we have only one limited GitLab
Runner, which would be unable to reliably sustain the CI load of merge
requests for three maintained branches, and instead, we opted for
running Windows system tests in daily pipelines. CI load should no
longer be an issue since "v9_16" is the only (and last) maintained
branch with Windows support. We are only left with the downside of
failing to run system tests for merge requests on Windows: missing
Windows-specific quirks in the review process and finding out about them
only a day later in the daily pipeline (e.g., #3865 and #3874 from this
week).
2023-02-16 20:30:43 +01:00
Michal Nowak
fed8a373a3 Merge tag 'v9_16_38' into v9_16
BIND 9.16.38
2023-02-16 17:53:48 +01:00
Mark Andrews
f9a1e293d2 Merge branch 'feature/main/fips-tests-v9_16' into 'v9_16'
[9.16] FIPS tests changes for RHEL

See merge request isc-projects/bind9!7541
2023-02-15 22:11:54 +00:00
Mark Andrews
1b5848aebe Add CHANGES note for [GL !7417]
(cherry picked from commit 55a6b15087)
2023-02-16 08:49:06 +11:00
Petr Menšík
3f81fbed12 FIPS tests changes for RHEL
Include MD5 feature detection in featuretest tool and use it in some
places. When RHEL distribution or Fedora ELN is in FIPS mode, then MD5
algorithm is unavailable completely and even hmac-md5 algorithm usage
will always fail. Work that around by checking MD5 works and if not,
skipping its usage.

Those changes were dragged as downstream patch bind-9.11-fips-tests.patch
in Fedora and RHEL.

(cherry picked from commit 6ad794a8cd)
2023-02-16 08:48:39 +11:00
Ondřej Surý
77fb1a4dc8 Merge branch '3865-failing-windows-system-tests-due-to-libuv-version-check' into 'v9_16'
Resolve "Failing windows system tests due to libuv version check"

See merge request isc-projects/bind9!7536
2023-02-15 11:28:08 +00:00
Ondřej Surý
100c20b470 Don't check for maximal version on Windows
The Windows doesn't have support for recvmmsg(), so we don't need to
check for maximal version on Windows (only for a minimal version).

Remove the MAXIMAL_VERSION when compiling on Windows.
2023-02-15 11:02:57 +01:00
Mark Andrews
5ce64ea878 Merge branch '3662-extend-mkeys-system-test-to-handle-islands-of-trust-v9_16' into 'v9_16'
[9.16] Resolve "Extend mkeys system test to handle islands of trust"

See merge request isc-projects/bind9!7530
2023-02-14 22:34:09 +00:00
Mark Andrews
d0fd97f67c Add CHANGES note for [GL #3662]
(cherry picked from commit 2928f21733)
2023-02-14 22:09:52 +00:00
Mark Andrews
9109f38ece Add islands of trust to mkeys test
This adds an island of trust that is reachable from the root
where the trust anchors are added to island.conf.

This add an island of trust that is not reachable from the root
where the trust anchors are added to private.conf.

(cherry picked from commit 41bdb5b9fe)
2023-02-14 22:09:52 +00:00
Mark Andrews
4df6019c16 Report the key name that failed in retry_keyfetch
When there are multiple managed trust anchors we need to know the
name of the trust anchor that is failing.  Extend the error message
to include the trust anchor name.

(cherry picked from commit fb7b7ac495)
2023-02-14 22:09:52 +00:00
Evan Hunt
9507facb36 Merge branch '3673-delay-trust-anchor-management-v9_16' into 'v9_16'
[9.16] Merge branch '3673-delay-trust-anchor-management' into 'main'

See merge request isc-projects/bind9!7534
2023-02-14 19:07:10 +00:00
Evan Hunt
aca10608b6 delay trust anchor management until zones are loaded
it was possible for a managed trust anchor needing to send a key
refresh query to be unable to do so because an authoritative zone
was not yet loaded. this has been corrected by delaying the
synchronization of managed-keys zones until after all zones are
loaded.

(cherry picked from commit bafbbd2465)
2023-02-14 10:23:28 -08:00
Tom Krizek
89ed0724e2 Merge branch '3848-increase-wait-time-runtime-test-v9_16' into 'v9_16'
[9.16] Increase named startup wait time for runtime test

See merge request isc-projects/bind9!7525
2023-02-13 16:02:45 +00:00
Tom Krizek
208777b74e Increase named startup wait time for runtime test
Occasionally, the allotted 10 seconds for the "running" line to appear
in log after named is started proved insufficient in CI, especially
during increased load. Give named up to 60 seconds to start up to
mitigate this issue.

(cherry picked from commit b8bb4233e8)
2023-02-13 16:11:04 +01:00
Michal Nowak
12e323dd2e Merge branch '3846-nsupdate-test-fix-v9_16' into 'v9_16'
[9.16] increase simultaneous updates for quota test

See merge request isc-projects/bind9!7522
2023-02-13 15:03:01 +00:00
Evan Hunt
5d0a8996ce increase simultaneous updates for quota test
the nsupdate system test was intermittently failing due to the update
quota not being exceeded when it should have been.  this is most likely
a timing issue: the client is sending updates too slowly, or the server
is processing them too quickly, for the quota to fill. this commit
attempts to make that the failure less likely by increasing the number
of update transactions from 10 to 20.

(cherry picked from commit 06b1faf068)
2023-02-13 13:36:11 +01:00
Ondřej Surý
dd0ce8e218 Merge branch 'pspacek/make-manin-on-dist-v9_16-fix2' into 'v9_16'
Use placeholders in pre-generated manpages in the tarball

See merge request isc-projects/bind9!7520
2023-02-10 17:46:02 +00:00
Ondřej Surý
0c7bd27598 Use placeholders in pre-generated manpages in the tarball
When pre-generating the manpages in the tarball-create CI job, we need
to use placeholders, and not the final values.
2023-02-10 18:40:34 +01:00