Commit Graph

26788 Commits

Author SHA1 Message Date
Mukund Sivaraman
ed29b84e16 return FORMERR when question section is empty if COOKIE is not present
(cherry picked from commit 06d3106002)
2018-06-26 14:36:34 -07:00
Ondřej Surý
fbd85297eb Merge branch 'add-git-replay-merge-v9_12' into 'v9_12'
Add git replay merge to v9_12

See merge request isc-projects/bind9!429
2018-06-26 15:19:37 -04:00
Ondřej Surý
65144c4bf7 Add git-replay-merge.sh script to v9_12 2018-06-26 20:29:07 +02:00
Witold Krecicki
0d2172eeba Merge branch '180-fix-cmsgbuf-usage-v9_12' into 'v9_12'
Resolve "Intermittent recursive resolver issues [socket.c:2135]"

See merge request isc-projects/bind9!427
2018-06-26 14:25:39 -04:00
Witold Kręcicki
4007a9d020 Use completely static-sized buffers
(cherry picked from commit 49f90025a0)
2018-06-26 20:18:59 +02:00
Witold Kręcicki
da63e95612 Fix socket cmsg buffer usage
(cherry picked from commit d79be7dd5e)
2018-06-26 20:12:58 +02:00
Evan Hunt
9e85d16004 Merge branch '288-named-checkconf-does-not-recognize-errors-related-to-in-view-zones-v9_12' into 'v9_12'
Resolve "named-checkconf does not recognize errors related to in-view zones"

See merge request isc-projects/bind9!423
2018-06-26 12:53:55 -04:00
Mark Andrews
7f31e67c16 CHANGES, copyright
(cherry picked from commit f7d346357e)
2018-06-26 09:04:48 -07:00
Mark Andrews
665f9093d2 construct a symtab of valid in-view targets then check that the target exists
(cherry picked from commit e01a4bcb20)
2018-06-26 09:03:47 -07:00
Michał Kępień
7d993ffb0b Merge branch '321-only-request-permitted-capabilities-in-non-libcap-builds-v9_12' into 'v9_12'
[v9_12] Only request permitted capabilities in non-libcap builds

See merge request isc-projects/bind9!417
2018-06-26 08:03:26 -04:00
Michał Kępień
731b003854 Add CHANGES entry
4979.	[bug]		Non-libcap builds were not checking whether all
			requested capabilities are present in the permitted
			capability set. [GL #321]
2018-06-26 13:18:00 +02:00
Michał Kępień
8c66f32e53 Only request permitted capabilities in non-libcap builds
While libcap-enabled builds check whether any capability named requests
is within the permitted capability set, non-libcap builds just try
requesting them, which potentially causes a misleading error message to
be output ("Operation not permitted: please ensure that the capset
kernel module is loaded").  Ensure non-libcap builds also check whether
any requested capability is within the permitted capability set.
2018-06-26 13:18:00 +02:00
Michał Kępień
b7200143f4 Merge branch '312-fix-rpz-system-test-v9_12' into 'v9_12'
[v9_12] Fix rpz system test

See merge request isc-projects/bind9!416
2018-06-26 06:52:06 -04:00
Michał Kępień
80e8f4c366 Add CHANGES entry
4978.	[test]		Fix error handling and resolver configuration in the
			"rpz" system test. [GL #312]

(cherry picked from commit 51522a2b84)
2018-06-26 12:43:47 +02:00
Michał Kępień
6a2c606690 Do not use IANA DNSSEC keys in the "rpz" system test
With "dnssec-validation" now defaulting to "auto", it needs to be
explicitly set to "yes" (the previous default value) for all validating
resolvers used in system tests.  Ensure that requirement is satisfied by
the resolvers used in the "rpz" system test.

(cherry picked from commit ff6b717955)
2018-06-26 12:43:47 +02:00
Michał Kępień
cee0c23d0a Determine "rpz" system test mode based on $mode rather than $DNSRPS_TEST_MODE
Change 4897 modified the way the $DNSRPS_TEST_MODE variable is used in
bin/tests/system/rpz/tests.sh without updating all references to it,
which i.a. causes the $native and $dnsrps variables to not be set in the
default testing mode, effectively preventing failed checks from being
propagated to the final result of the test.  Use $mode instead of
$DNSRPS_TEST_MODE where appropriate to fix error handling in the "rpz"
system test.

(cherry picked from commit 730c6651a0)
2018-06-26 12:43:47 +02:00
Evan Hunt
90e762a1cf Merge branch '247-log-the-remaining-v-info-at-startup' into 'v9_12'
Resolve "Log the remaining -V info at startup"

Closes #247

See merge request isc-projects/bind9!249
2018-06-25 15:02:33 -07:00
Mark Andrews
74bfd11a5f log the remaining -V info at startup
(cherry picked from commit 33ff03db58)
2018-06-25 15:02:31 -07:00
Mark Andrews
9eb2ff6367 Merge branch '254-invalid-rpz-prefix-length-log-message-improperly-displays-the-prefix-labels-not-length-v9_12' into 'v9_12'
Resolve ""invalid RPZ prefix length" log message improperly displays the prefix labels, not length"

See merge request isc-projects/bind9!408
2018-06-25 03:39:54 -04:00
Mukund Sivaraman
a769e80796 Add CHANGES entry
(cherry picked from commit 90e886cfc0)
2018-06-25 17:33:15 +10:00
Mukund Sivaraman
19bad5a7f3 Add system test
(cherry picked from commit 2bf388a31b)
2018-06-25 17:33:15 +10:00
Mukund Sivaraman
82d5a44dfd Patch in trailing nul character to print just the length label (for various cases below)
(cherry picked from commit 6a756ab654)
2018-06-25 17:33:15 +10:00
Mark Andrews
e9f7ef733d Merge branch '343-casecompare-of-ninfo-tkey-txt-have-wrong-return-type-v9_12' into 'v9_12'
Resolve "casecompare of NINFO, TKEY, TXT have wrong return type"

See merge request isc-projects/bind9!404
2018-06-24 23:19:40 -04:00
Mark Andrews
537e3a0a14 fix casecompare return type for ninfo, tkey, txt
(cherry picked from commit 3ba1d1e43b)
2018-06-25 13:08:47 +10:00
Mark Andrews
393b974ed3 Merge branch '356-client-cookie-is-being-hashed-twice-when-computing-the-dns-server-cookie-v9_12' into 'v9_12'
Resolve "Client cookie is being hashed twice when computing the DNS server cookie."

See merge request isc-projects/bind9!401
2018-06-22 03:51:53 -04:00
Mark Andrews
cd1169b605 4975. [bug] The server cookie computation for sha1 and sha256 did
not match the method described in RFC 7873. [GL #356]

(cherry picked from commit 8755a249bc)
2018-06-22 17:45:02 +10:00
Mark Andrews
77496f0b88 the client cookie was being hashed twice when computing the server cookie for sha1 and sha256
(cherry picked from commit 4795f0ca89)
2018-06-22 17:45:02 +10:00
Ondřej Surý
e1dc8b39d3 Merge branch 'release-v9_12_2rc1' into 'v9_12'
Merge 9.12.1rc1 release into v9_12

See merge request isc-projects/bind9!395
2018-06-21 13:13:13 -04:00
Evan Hunt
87344e3493 prepare 9.12.1rc1 2018-06-21 18:46:32 +02:00
Mark Andrews
e684a72f54 Merge branch '336-default-of-rrset-order-silently-changed-to-be-sorted-rather-than-random-v9_12' into 'v9_12'
Resolve "Default of rrset-order silently changed to be sorted (rather than random)"

See merge request isc-projects/bind9!387
2018-06-18 21:43:44 -04:00
Mark Andrews
4f332dc936 Restore default rrset-order to random.
(cherry picked from commit e8154b50d4)
2018-06-19 11:18:19 +10:00
Michał Kępień
b4c0a99f22 Merge branch '341-constify-dns_rdata_tostruct-v9_12' into 'v9_12'
[v9_12] constify dns_rdata_tostruct

See merge request isc-projects/bind9!380
2018-06-15 03:34:48 -04:00
Mark Andrews
d4c55dae8e Declare the 'rdata' argument for dns_rdata_tostruct() to be const
(cherry picked from commit abb2fd1027)
2018-06-15 08:52:28 +02:00
Ondřej Surý
d370125e67 Merge branch '309-fix-default-recursion-v9_12' into 'v9_12'
Resolve "Recursion improperly allowed by default"

See merge request isc-projects/bind9!373
2018-06-14 08:53:10 -04:00
Evan Hunt
be145bc8b6 add a regression test for default allow-recursion settings 2018-06-14 14:45:56 +02:00
Evan Hunt
be02bf6571 allow-recursion could incorrectly inherit from the default allow-query 2018-06-14 14:45:56 +02:00
Michał Kępień
22192a4566 Merge branch '298-fix-dname-handling-in-dnssec-tools-v9_12' into 'v9_12'
[v9_12] Fix DNAME handling in DNSSEC tools

See merge request isc-projects/bind9!363
2018-06-13 07:29:22 -04:00
Michał Kępień
f9637ae0e5 Add CHANGES entry
4971.	[bug]		dnssec-signzone and dnssec-verify did not treat records
			below a DNAME as out-of-zone data. [GL #298]

(cherry picked from commit f467ba8e1f)
2018-06-13 12:57:47 +02:00
Mark Andrews
899e56068e Pull out the saving of the zone cut into a separate function
(cherry picked from commit 7be900a98f)
2018-06-13 12:57:41 +02:00
Michał Kępień
ff7015a0f8 Treat records below a DNAME as out-of-zone data
DNAME records indicate bottom of zone and thus no records below a DNAME
should be DNSSEC-signed or included in NSEC(3) chains.  Add a helper
function, has_dname(), for detecting DNAME records at a given node.
Prevent signing DNAME-obscured records.  Check that DNAME-obscured
records are not signed.

(cherry picked from commit 75c0d85fc4)
2018-06-13 12:57:03 +02:00
Michał Kępień
f3b5550c2c Merge branch '284-unify-keyfile-to-configuration-conversions-in-system-tests-v9_12' into 'v9_12'
[v9_12] Unify keyfile-to-configuration conversions in system tests

See merge request isc-projects/bind9!360
2018-06-13 02:10:50 -04:00
Michał Kępień
2cad382552 Add helper variables in mkeys system test
The keyfile and key ID for the original managed key do not change
throughout the mkeys system test.  Keep them in helper variables to
prevent calling "cat" multiple times and improve code readability.

(cherry picked from commit 68f056b2a0)
2018-06-13 07:59:07 +02:00
Michał Kępień
dce66f7635 Replace duplicated code snippet with calls to helper functions
Reduce code duplication by replacing a code snippet repeated throughout
system tests using "trusted-keys" and/or "managed-keys" configuration
sections with calls to keyfile_to_{managed,trusted}_keys() helper
functions.

(cherry picked from commit 120af964ce)
2018-06-13 07:58:39 +02:00
Michał Kępień
21d3658bcb Add helper functions for converting keyfile data into configuration sections
Add a set of helper functions for system test scripts which enable
converting key data from a set of keyfiles to either a "trusted-keys"
section or a "managed-keys" section suitable for including in a
resolver's configuration file.

(cherry picked from commit 2392b8bc7d)
2018-06-13 07:58:10 +02:00
Michał Kępień
b5478f1281 Merge branch '269-refactor-zone-logging-functions-v9_12' into 'v9_12'
[v9_12] Refactor zone logging functions

See merge request isc-projects/bind9!357
2018-06-11 07:06:04 -04:00
Michał Kępień
056e8acc0e Add CHANGES entry
4969.	[cleanup]	Refactor zone logging functions. [GL #269]

(cherry picked from commit c8de677eae)
2018-06-11 12:50:11 +02:00
Michał Kępień
b39edab59b Reimplement all zone logging functions using dns_zone_logv()
In order to decrease code duplication, express the logic contained in
all zone logging functions using dns_zone_logv() calls.

(cherry picked from commit 5c03cd339e)
2018-06-11 12:50:11 +02:00
Michał Kępień
75959cb369 Add dns_zone_logv()
Add a new libdns function, dns_zone_logv(), which takes a single va_list
argument rather than a variable number of arguments and can be used as a
base for implementing more specific zone logging functions.

(cherry picked from commit bb2dfb3f49)
2018-06-11 12:50:11 +02:00
Evan Hunt
1df48d82d2 Merge branch 'fix-strtok' into v9_12 2018-06-09 23:04:00 -07:00
Evan Hunt
74c3b9d3b2 complete strtok fix 2018-06-09 23:03:38 -07:00