Commit Graph

24218 Commits

Author SHA1 Message Date
Michał Kępień
ec51b6d3d4 Only clear DNS_ZONEFLG_LOADPENDING in zone_asyncload() if zone loading is completed immediately
zone_load() is not always synchronous, it may only initiate an
asynchronous load and return DNS_R_CONTINUE, which means zone loading
has not yet been completed.  In such a case, zone_asyncload() must not
clear DNS_ZONEFLG_LOADPENDING immediately and leave that up to
zone_postload().
2018-02-16 09:03:27 +01:00
Michał Kępień
9c103120ad Lock zone before checking whether its asynchronous load is already pending
While this is not an issue in named, which only calls
dns_zone_asyncload() from task-exclusive mode, this function is exported
by libdns and thus may in theory be concurrently called for the same
zone by multiple threads.  It also does not hurt to be consistent
locking-wise with other DNS_ZONEFLG_LOADPENDING accesses.
2018-02-16 09:03:27 +01:00
Mark Andrews
0402b2121f Merge branch 'fix-cpp-check-errors' into 'v9_9'
Fix cpp check errors v9_9

See merge request isc-projects/bind9!32
2018-02-16 02:49:07 -05:00
Mark Andrews
292245ebbf s/cppchecker/cppcheck 2018-02-16 18:45:24 +11:00
Mark Andrews
f80160d467 add GL issue number 2018-02-16 18:45:24 +11:00
Mark Andrews
469bc9fd15 add CHANGES note 2018-02-16 18:45:23 +11:00
Mark Andrews
1832348d27 add POST(len); 2018-02-16 18:44:47 +11:00
Mark Andrews
2670173c43 conditionally declare stacksize 2018-02-16 18:44:47 +11:00
Mark Andrews
ca738505ec add POST(len); 2018-02-16 18:43:59 +11:00
Mark Andrews
622bf9256b add POST(tl) 2018-02-16 18:43:46 +11:00
Mark Andrews
4404fcb384 return failure count 2018-02-16 18:42:11 +11:00
Mark Andrews
7245f12d3e conditionally declare strbuf 2018-02-16 18:41:31 +11:00
Mark Andrews
192a119b5a test for == 0 rather than <= as value is unsigned 2018-02-16 18:41:31 +11:00
Mark Andrews
872543eca7 add brackets 2018-02-16 18:37:05 +11:00
Mark Andrews
5de799a1c8 reorder test to silence cppcheck 2018-02-16 18:37:05 +11:00
Mark Andrews
32166fae3b remove event which is only used for sizeof 2018-02-16 18:37:05 +11:00
Mark Andrews
a4d8e7526a reorder test to silence cppcheck 2018-02-16 18:36:17 +11:00
Mark Andrews
324039934d use %u instead of %d 2018-02-16 18:36:17 +11:00
Mark Andrews
a6a6928e7e use %u instead of %d 2018-02-16 18:35:49 +11:00
Mark Andrews
fb188d4795 use %u instead of %d 2018-02-16 18:32:54 +11:00
Mark Andrews
f7c7a87cb4 use %u instead of %d 2018-02-16 18:30:18 +11:00
Mark Andrews
810fdbe4e7 use %u instead of %d 2018-02-16 18:30:18 +11:00
Mark Andrews
f6e83e4108 use %u instead of %d 2018-02-16 18:30:18 +11:00
Mark Andrews
9d061a7864 use %u instead of %d 2018-02-16 18:29:17 +11:00
Mark Andrews
a6f0a302ea case to unsigned; reorder expression 2018-02-16 18:25:33 +11:00
Mark Andrews
fd0877d294 simplify expression 2018-02-16 18:23:12 +11:00
Mark Andrews
ef0fb20613 use %u and preserve unsigned property 2018-02-16 18:23:11 +11:00
Mark Andrews
6cc168d6d4 cast to unsigned 2018-02-16 18:17:59 +11:00
Mark Andrews
bc7adce774 preserve unsigned property 2018-02-16 18:17:59 +11:00
Mark Andrews
b7a4a93b0d use %u instead of %d 2018-02-16 18:17:59 +11:00
Mark Andrews
5ae3eb3cfb make both arguments of & unsigned 2018-02-16 18:17:59 +11:00
Mark Andrews
cc21083141 use %u instead of %d 2018-02-16 18:16:48 +11:00
Mark Andrews
13421f89a2 shift unsigned (~0U) rather than signed (~0) contant 2018-02-16 18:16:48 +11:00
Mark Andrews
1bc27d6b26 use %u instead of %d 2018-02-16 18:16:48 +11:00
Mark Andrews
f693b488e1 unsigned constants 2018-02-16 18:15:21 +11:00
Mark Andrews
fe9ab35df1 unsigned constants 2018-02-16 18:13:08 +11:00
Mark Andrews
b6e6160df8 use %u instead of %d 2018-02-16 18:10:41 +11:00
Mark Andrews
606aa56e4f use %u instead of %d 2018-02-16 18:10:41 +11:00
Mark Andrews
131d4c873e use %u instead of %d 2018-02-16 18:08:58 +11:00
Mark Andrews
b3d10f1a43 use %u instead of %d 2018-02-16 18:06:58 +11:00
Mark Andrews
922ada36b5 formally cast to int; use %u instead of %d 2018-02-16 18:05:01 +11:00
Mark Andrews
726eaefd3e formally cast to int 2018-02-16 18:05:01 +11:00
Mark Andrews
62d579f152 use %u instead of %d 2018-02-16 18:05:01 +11:00
Mark Andrews
41ac666f4a use %u instead of %d 2018-02-16 18:04:27 +11:00
Mark Andrews
5c91a79de9 use %u instead of %d 2018-02-16 18:02:21 +11:00
Mark Andrews
3ddd77519d use %u instead of %d 2018-02-16 17:58:39 +11:00
Mark Andrews
e3bc8bc293 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews
75691e0d90 use %u instead of %d 2018-02-16 17:53:13 +11:00
Mark Andrews
01fd4fcca2 use %u instead of %d 2018-02-16 17:51:07 +11:00
Mark Andrews
a365729e6a make declarations consistent 2018-02-16 17:49:02 +11:00