Commit Graph
28264 Commits
Author SHA1 Message Date
Witold Kręcicki e18cdac443 tests: add a missing log nextpart in inline test 2020-01-21 16:15:07 +01:00
Ondřej Surý 32fa45d19c Merge branch 'ondrej/lower-the-artifact-expiration-time-to-just-12-hours-v9_11' into 'v9_11'
Lower the artifact expiration time to just 1 day

See merge request isc-projects/bind9!2932
2020-01-21 12:14:30 +00:00
Ondřej Surý 86c297fb20 Lower the artifact expiration time to just 1 day
(cherry picked from commit 27a9be3034)
2020-01-21 13:12:41 +01:00
Mark Andrews 33e59450e9 Merge branch 'marka-omit-spurious-newlines-v9_11' into 'v9_11'
Omit spurious newlines when reporting DNSKEY changes

See merge request isc-projects/bind9!2924
2020-01-21 05:54:50 +00:00
Tony FinchandMark Andrews 353814fc09 Omit spurious newlines when reporting DNSKEY changes
These caused blank lines to appear in the logs.

(cherry picked from commit 3b1bd3f48b)
2020-01-21 16:34:20 +11:00
Mark Andrews f671f3452a Merge branch 'marka-document-authors-bind-v9_11' into 'v9_11'
document that version also controls authors.bind

See merge request isc-projects/bind9!2921
2020-01-21 04:25:36 +00:00
Mark Andrews 50fbacc01b document that version also controls authors.bind
(cherry picked from commit 05c6a29c87)
2020-01-21 15:05:22 +11:00
Mark Andrews 29c86c7c69 Merge branch '1537-nslookup-manual-page-needs-update-for-default-querytype-a-and-aaaa-v9_11' into 'v9_11'
document that nslookup defaults to A + AAAA lookups

See merge request isc-projects/bind9!2917
2020-01-20 02:22:21 +00:00
Mark Andrews 2eb1b00d24 document that nslookup defaults to A + AAAA lookups
(cherry picked from commit 938fc81493)
2020-01-20 10:48:25 +11:00
Mark Andrews 714384b8f8 Merge branch 'marka-check-CHANGES-SE-in-CI-v9_11' into 'v9_11'
check that CHANGES.SE entries are correctly ordered and that whitespace is correct

See merge request isc-projects/bind9!2914
2020-01-19 23:18:37 +00:00
Mark Andrews 6c14221ecd check that CHANGES.SE entries are correctly ordered and that whitespace is correct
(cherry picked from commit 05f2ba973f)
2020-01-18 08:10:51 +11:00
Michał Kępień 235765a8ce Merge branch 'michal/make-retry_quiet-available-on-windows' into 'v9_11'
Make retry_quiet() available on Windows

See merge request isc-projects/bind9!2911
2020-01-16 20:38:21 +00:00
Michał Kępień c9a12b8a1b Make retry_quiet() available on Windows
When retry_quiet() was backported to v9_11, it was only placed in
bin/tests/system/conf.sh.in, but not in bin/tests/system/conf.sh.win32.
This prevents every system test which employs this shell function either
directly or indirectly from ever succeeding on Windows.  Fix by copying
the definition of retry_quiet() to bin/tests/system/conf.sh.win32.
2020-01-16 21:37:06 +01:00
Matthijs Mekking 0ee0b251b4 Merge branch 'prepare-release-notes-for-bind-9-11.15' into 'v9_11'
Add release notes section for BIND 9.11.15

See merge request isc-projects/bind9!2906
2020-01-16 12:16:23 +00:00
Michał KępieńandMatthijs Mekking a8587a0899 Add release notes section for BIND 9.11.15 2020-01-16 12:28:06 +01:00
Michał Kępień 4df74c85f8 Merge branch 'michal/fix-the-dnssec-system-test-on-windows-v9_11' into 'v9_11'
[v9_11] Fix the "dnssec" system test on Windows

See merge request isc-projects/bind9!2904
2020-01-16 08:51:28 +00:00
Michał Kępień a4f6af58b2 Fix the "dnssec" system test on Windows
Make sure carriage return characters are stripped from awk input to
enable the "dnssec" system test to pass on Windows.

(cherry picked from commit 451484b870)
2020-01-16 09:50:16 +01:00
Michał Kępień 71bc5cc65c Merge branch '1525-inline-system-test-failed-need-to-wait-for-zone-to-be-loaded-v9_11' into 'v9_11'
[v9_11] Resolve "inline system test failed, need to wait for zone to be loaded."

See merge request isc-projects/bind9!2891
2020-01-14 14:14:51 +00:00
Mark AndrewsandMichał Kępień 8c857665d0 address some timing issues in inline system test
(cherry picked from commit 2dc4d72fa9)
2020-01-14 14:49:52 +01:00
Matthijs MekkingandMichał Kępień 553a2498e1 Move wait_for_log to conf.sh.common
(cherry picked from cfaa631f65)
2020-01-14 14:49:52 +01:00
Michał Kępień 349c922da8 Merge branch '1482-autosign-system-test-failed-v9_11' into 'v9_11'
[v9_11] Resolve "autosign system test failed"

See merge request isc-projects/bind9!2888
2020-01-14 13:35:11 +00:00
Mark AndrewsandMichał Kępień 24d52c1a38 Fix autosign system test issues.
* report when NSEC3PARAM is not yet present
* allow more time for NSEC3PARAM to become present
* adjust frequency failure message

(cherry picked from commit 17d25dbf47)
2020-01-14 13:24:26 +01:00
Michał Kępień fa784b5a60 Merge branch '1467-xfer-test-suppress-zone-transfer-when-we-are-going-to-retry-v9_11' into 'v9_11'
[v9_11] Resolve "xfer test: suppress zone transfer when we are going to retry."

See merge request isc-projects/bind9!2886
2020-01-14 12:20:13 +00:00
Mark AndrewsandMichał Kępień 57cd453b1e improve forensic logs
improve forensic logs by directing output to per sub-test named
files and reporting the sub-subtest number.

(cherry picked from commit 895f60d6f8)
2020-01-14 12:20:19 +01:00
Mark AndrewsandMichał Kępień e49100c9ab suppress unnecessary zone transfer
suppressed unnecessary zone transfer in "test mapped zone with
out of zone data" sub-test.

(cherry picked from commit 28695f1c92)
2020-01-14 12:20:18 +01:00
Mark AndrewsandMichał Kępień a3343b61ba Improve forensic logging in "testing basic zone transfer functionality"
Split the "testing basic zone transfer functionality" into primary and
secondary parts to improve forensic logging.

(cherry picked from commit 14ef8b10af)
2020-01-14 12:20:16 +01:00
Mark Andrews 1ed4fcdc9f Merge branch '1531-add-calls-to-dns_rdata_additionaldata-to-lib-dns-tests-rdata_test-c-v9_11' into 'v9_11'
Resolve "Add calls to dns_rdata_additionaldata to lib/dns/tests/rdata_test.c"

See merge request isc-projects/bind9!2879
2020-01-14 09:38:15 +00:00
Mark Andrews 9b71352f25 exercise dns_rdata_checknames
(cherry picked from commit b3c1b2a869)
2020-01-14 09:17:10 +00:00
Mark Andrews ecdb80ca85 exercise dns_rdata_additionaldata
(cherry picked from commit 649a34d628)
2020-01-14 09:17:10 +00:00
Mark Andrews 83b5274f84 call dns_rdata_towire on valid output from dns_rdata_fromtext and dns_rdata_fromwire
(cherry picked from commit 5e74550740)
2020-01-14 09:17:10 +00:00
Ondřej Surý b65df9526b Merge branch '1443-threadsanitizer-data-race-lib-dns-rbtdb-c-1960-in-decrement_reference-2-v9_11' into 'v9_11'
Resolve "ThreadSanitizer: data race lib/dns/rbtdb.c:1960 in decrement_reference"

See merge request isc-projects/bind9!2874
2020-01-14 08:02:57 +00:00
Mark AndrewsandOndřej Surý 3a9cdba3d8 Add is_leaf and send_to_prune_tree.
Add is_leaf and send_to_prune_tree to make the logic easier
to understand in cleanup_dead_nodes and decrement_reference.

(cherry picked from commit c6efc0e50f)
2020-01-14 08:35:37 +01:00
Mark AndrewsandOndřej Surý 4db29f1f7d Testing node->down requires the tree lock to be held.
In decrement_reference only test node->down if the tree lock
is held.  As node->down is not always tested in
decrement_reference we need to test that it is non NULL in
cleanup_dead_nodes prior to removing the node from the rbt
tree.  Additionally it is not always possible to aquire the
node lock and reactivate a node when adding parent nodes.
Reactivate such nodes in cleanup_dead_nodes if required.

(cherry picked from commit 176b23b6cd)
2020-01-14 08:35:37 +01:00
Mark Andrews 17945a1d03 Merge branch 'u/fanf2/rndc-secroots-newlines-v9_11' into 'v9_11'
Fix line spacing in `rndc secroots`

See merge request isc-projects/bind9!2867
2020-01-13 22:13:40 +00:00
Tony FinchandMark Andrews e0a7baa6af Fix line spacing in rndc secroots
Before this change, there was a missing blank line between the
negative trust anchors for one view, and the heading line for the next
view. This is because dns_ntatable_totext() omits the last newline.
There is an example of the incorrect output below; the fixed output
has a blank line before "Start view auth".

secure roots as of 21-Oct-2019 12:03:23.500:

 Start view rec
   Secure roots:

./RSASHA256/20326 ; managed

   Negative trust anchors:

example.com: expiry 21-Oct-2019 13:03:15.000
 Start view auth
   Secure roots:

./RSASHA256/20326 ; managed

   Negative trust anchors:

example.com: expiry 21-Oct-2019 13:03:07.000

(cherry picked from commit 5b600c2cd8)
2020-01-14 08:57:17 +11:00
Michal Nowak 89b26276bc Merge branch 'mnowak/add-openSUSE-Tumblewed-image-v9_11' into 'v9_11'
[v9_11] Add openSUSE Tumbleweed image to the CI

See merge request isc-projects/bind9!2876
2020-01-13 16:32:51 +00:00
Michal Nowak bb3bc5820a Add openSUSE Tumbleweed image to the CI
Ensure BIND is continuously tested on Tumbleweed, a pure rolling release
version of openSUSE.  This will allow BIND incompatibilities with latest
upstream versions of its dependencies to be caught more quickly.

(cherry picked from commit bd5dd1b58c60edb372bc6fa4eb39e355c5c76de4)
2020-01-13 16:32:51 +00:00
Michał Kępień cadc484d76 Merge branch 'michal/update-gitlab-ci-to-alpine-linux-3.11-v9_11' into 'v9_11'
[v9_11] Update GitLab CI to Alpine Linux 3.11

See merge request isc-projects/bind9!2862
2020-01-13 14:25:39 +00:00
Michał Kępień a89de9cbfc Update GitLab CI to Alpine Linux 3.11
Since Alpine Linux 3.11 is the current Alpine Linux release, replace
Alpine Linux 3.10 GitLab CI jobs with their up-to-date counterparts.

(cherry picked from commit bebf353eb5)
2020-01-13 15:09:01 +01:00
Michał Kępień 619e5aa276 Merge branch '1552-properly-detect-mmdb-lookup-failures-v9_11' into 'v9_11'
[v9_11] Properly detect MMDB lookup failures

See merge request isc-projects/bind9!2872
2020-01-13 14:07:21 +00:00
Michał Kępień c1e38394f2 Add CHANGES entry
5339.	[bug]		With some libmaxminddb versions, named could erroneously
			match an IP address not belonging to any subnet defined
			in a given GeoIP2 database to one of the existing
			entries in that database. [GL #1552]

(cherry picked from commit a070defb18)
2020-01-13 15:06:38 +01:00
Michał Kępień 28fe27e47e Properly detect MMDB lookup failures
Only comparing the value of the integer passed as the last argument to
MMDB_lookup_sockaddr() against MMDB_SUCCESS is not enough to ensure that
an MMDB lookup was successful - the 'found_entry' field of the
MMDB_lookup_result_s structure returned by that function also needs to
be true or else the remaining contents of that structure should be
ignored as the lookup failed.  Extend the relevant logical condition in
get_entry_for() to ensure the latter does not return incorrect MMDB
entries for IP addresses which do not belong to any subnet defined in a
given GeoIP2 database.

(cherry picked from commit 814da1c808)
2020-01-13 15:06:35 +01:00
Michał Kępień 832d904802 Merge branch 'michal/handle-catopen-errors' into 'v9_11'
Handle catopen() errors

See merge request isc-projects/bind9!2863
2020-01-13 13:03:35 +00:00
Michał Kępień daade37977 Handle catopen() errors
musl libc's implementation of catgets() crashes when its first argument
is -1 instead of a proper message catalog descriptor.  Prevent that from
happening by making isc_msgcat_get() return the default text if the
prior call to catopen() returns an error.
2020-01-13 14:03:11 +01:00
Mark Andrews 21c707fb9a Merge branch '1464-unchecked-returns-in-v9_11-as-reported-by-coverity-2' into 'v9_11'
Resolve "Unchecked returns in v9_11 as reported by Coverity."

See merge request isc-projects/bind9!2727
2020-01-13 05:44:58 +00:00
Mark Andrews 939f2fa2f5 formally discard return value 2020-01-13 05:07:13 +00:00
Michał Kępień e7f2fc0106 Merge branch 'ondrej/run-full-pipeline-on-schedule-v9_11' into 'v9_11'
[v9_11] Run all jobs on scheduled builds (including OpenBSD and Windows)

See merge request isc-projects/bind9!2860
2020-01-10 10:21:01 +00:00
Ondřej SurýandMichał Kępień f70548724d Run all jobs on scheduled builds (including OpenBSD and Windows)
(cherry picked from commit 52773e226a)
2020-01-10 11:19:32 +01:00
Michał Kępień 01be66f0fe Merge branch 'ondrej/stop-retrying-system-tests-v9_11' into 'v9_11'
[v9_11] Stop retrying the system tests; we should fix the tests instead

See merge request isc-projects/bind9!2858
2020-01-10 10:15:10 +00:00
Ondřej SurýandMichał Kępień dfa4e9199e Stop retrying the system tests; we should fix the tests instead
(cherry picked from commit 8ad67f8b9f)
2020-01-10 11:14:05 +01:00