Commit Graph
29229 Commits
Author SHA1 Message Date
Ondřej SurýandMichał Kępień e145c40c93 Add CHANGES and release note for GL #2354 2021-02-17 22:46:14 +01:00
Ondřej SurýandMichał Kępień abed9404d1 Fix off-by-one bug in ISC SPNEGO implementation
The ISC SPNEGO implementation is based on mod_auth_kerb code.  When
CVE-2006-5989 was disclosed, the relevant fix was not applied to the
BIND 9 codebase, making the latter vulnerable to the aforementioned flaw
when "tkey-gssapi-keytab" or "tkey-gssapi-credential" is set in
named.conf.

The original description of CVE-2006-5989 was:

    Off-by-one error in the der_get_oid function in mod_auth_kerb 5.0
    allows remote attackers to cause a denial of service (crash) via a
    crafted Kerberos message that triggers a heap-based buffer overflow
    in the component array.

Later research revealed that this flaw also theoretically enables remote
code execution, though achieving the latter in real-world conditions is
currently deemed very difficult.

This vulnerability was responsibly reported as ZDI-CAN-12302 ("ISC BIND
TKEY Query Heap-based Buffer Overflow Remote Code Execution
Vulnerability") by Trend Micro Zero Day Initiative.
2021-02-17 22:46:14 +01:00
Petr Špaček 68dfe7bf57 Merge branch 'pspacek/ci-python-allthetime-v9_11' into 'v9_11'
[v9_11] Run Python linters in CI even outside of merge requests

See merge request isc-projects/bind9!4676
2021-02-15 09:33:56 +00:00
Petr Špaček 8228d78e03 Run Python linters in CI even outside of merge requests
Previously it did not get run on scheduled CI pipelines.

(cherry picked from commit 74d7cddc4c)
2021-02-15 10:26:56 +01:00
Michal Nowak fb46f5b205 Merge branch 'mnowak/check-for-unrecognized-options-v9_11' into 'v9_11'
[v9_11] Check for unrecognized configure options

See merge request isc-projects/bind9!4565
2021-02-12 15:02:10 +00:00
Michal Nowak 10d272bc35 Add --enable-option-checking=fatal to ./configure in CI
The --enable-option-checking=fatal option prevents ./configure from
proceeding when an unknown option is used in the ./configure step in CI.
This change will avoid adding unsupported ./configure options or options
with typo or typo in pairwise testing "# [pairwise: ...]" marker.

(cherry picked from commit 4295c82e45)
2021-02-12 14:27:21 +01:00
Michal Nowak 45ec9f37a7 Drop mutexatomics CI jobs
The --enable-mutex-atomics switch for ./configure is not available in
BIND 9.11.  Remove the jobs attempting to test it from GitLab CI
configuration.
2021-02-12 14:24:37 +01:00
Michal Nowak 196cdf12ca Replace --disable-geoip option with --with-geoip
--disable-geoip is not a valid switch for ./configure.  Use
--without-geoip2 instead in GitLab CI.
2021-02-12 14:22:49 +01:00
Michal Nowak 0a80a9b498 Drop unsupported configure options
The --enable-pthread-rwlock and --enable-mutex-atomics switches for
./configure are not available in BIND 9.11.  Do not attempt using them
in GitLab CI.
2021-02-12 14:22:49 +01:00
Michal Nowak c207a2e476 Merge branch '2312-lint-generated-manual-pages-v9_11' into 'v9_11'
[v9_11] Lint manual pages

See merge request isc-projects/bind9!4674
2021-02-12 12:41:06 +00:00
Michal Nowak 8ec37aaf91 Lint manual pages
As we generate manual pages from DocBook sources, we don't have absolute
control on manual page output and therefore 'mandoc -Tlint' may always
report warnings we can't eliminate. In light of this linting level was
set for mandoc to '-Werror' to ignore warnings and style issues, only
errors are reported.

(cherry picked from commit 22fdcb30db)
2021-02-12 13:04:55 +01:00
Michal Nowak 7cc88b385e Merge branch 'mnowak/check-asan-errors-in-configure-v9_11' into 'v9_11'
[v9_11] Check config.log for ASAN errors

See merge request isc-projects/bind9!4657
2021-02-09 11:44:27 +00:00
Michal Nowak f9da4b31ab Check config.log for ASAN errors
./configure checks might produce a false negative error due to ASAN
errors and thus disable some options.

(cherry picked from commit 0db934d401)
2021-02-09 12:08:13 +01:00
Michal Nowak 8740f2b97c Merge branch 'mnowak/free-openssl-keys-in-configure' into 'v9_11'
Free OpenSSL keys in ./configure

See merge request isc-projects/bind9!4656
2021-02-08 09:14:29 +00:00
Mark AndrewsandMichal Nowak edd6d5884a Free OpenSSL keys in ./configure
Failure to free OpenSSL keys in ./configure results in ASAN errors and
false negative errors.
2021-02-08 08:57:06 +01:00
Michal Nowak f082ed9d57 Merge branch 'mnowak/check-arm-pdf-validity-v9_11' into 'v9_11'
[v9_11] Check PDF file structure with QPDF

See merge request isc-projects/bind9!4652
2021-02-03 17:03:57 +00:00
Michal Nowak 3a5ccdb314 Check PDF file structure with QPDF
"qpdf --check" checks file structure of generated ARM PDF.

(cherry picked from commit 359708b9d6)
2021-02-03 17:59:16 +01:00
Mark Andrews f944568333 Merge branch '2093-tsan-files-are-not-being-captured-by-unit-tests-2-v9_11' into 'v9_11'
Look for tsan files in the top build directory

See merge request isc-projects/bind9!4639
2021-02-02 22:26:53 +00:00
Mark Andrews adbd30692a Look for tsan files in the top build directory
(cherry picked from commit 48715f6ad4)
2021-02-03 08:56:13 +11:00
Michal Nowak 09c3afb886 Merge branch 'mnowak/add-rsabigexponent-README-v9_11' into 'v9_11'
[v9_11] Add README.md file to rsabigexponent system test

See merge request isc-projects/bind9!4632
2021-01-29 15:03:07 +00:00
Michal Nowak aee29f7c17 Add README.md file to rsabigexponent system test
This README.md describes why is bigkey needed.

(cherry picked from commit a247f24dfa)
2021-01-29 15:48:39 +01:00
Mark Andrews 9db0c3606e Merge branch 'marka-changes-line-length-v9_11' into 'v9_11'
Detect overly long CHANGES lines

See merge request isc-projects/bind9!4616
2021-01-28 04:35:22 +00:00
Mark Andrews 925aba66fe Detect overly long CHANGES lines
(cherry picked from commit b1ecab6383)
2021-01-28 15:09:46 +11:00
Michal Nowak ad7d5cd4c0 Merge branch '2415-update-coverity-scan-ci-job-to-2020-09-v9_11' into 'v9_11'
[v9_11] Update Coverity Scan CI job to 2020.09

See merge request isc-projects/bind9!4595
2021-01-25 11:38:28 +00:00
Michal Nowak 8d325a59ae Update Coverity Scan CI job to 2020.09
(cherry picked from commit 7d428be79b)
2021-01-25 12:36:28 +01:00
Michał Kępień 3359bf5dd7 Merge branch 'michal/add-doc-arm-notes-9.11.28.xml-to-util-copyrights' into 'v9_11'
Add doc/arm/notes-9.11.28.xml to util/copyrights

See merge request isc-projects/bind9!4589
2021-01-21 09:31:27 +00:00
Michał Kępień 2c972164d7 Add doc/arm/notes-9.11.28.xml to util/copyrights
Commit d602219a8d did not update
util/copyrights as it should have.  Add the missing line to prevent the
"misc" GitLab CI job from failing.
2021-01-21 10:27:58 +01:00
Michał Kępień dfebcd1dfd Merge branch 'v9_11_27-release' into 'v9_11'
Merge 9.11.27 release branch

See merge request isc-projects/bind9!4588
2021-01-21 08:46:25 +00:00
Michał Kępień d602219a8d Set up release notes for BIND 9.11.28 2021-01-21 09:42:23 +01:00
Michał Kępień b0dbe91c70 Bump BIND_BASELINE_VERSION for ABI checks 2021-01-21 09:42:23 +01:00
Tinderbox UserandMichał Kępień 28b1355be8 Merge branch 'prep-release' into v9_11_27-release 2021-01-21 09:38:24 +01:00
Michał Kępień f895e8baac Merge branch 'michal/prepare-documentation-for-bind-9.11.27' into 'v9_11_27-release'
Prepare documentation for BIND 9.11.27

See merge request isc-private/bind9!232
2021-01-21 09:38:24 +01:00
Tinderbox UserandMichał Kępień 177d66e39f prep 9.11.27 2021-01-21 09:38:24 +01:00
Michał Kępień 545c4fe44e Prepare release notes for BIND 9.11.27 2021-01-21 09:38:24 +01:00
Michał Kępień f62cc34cd9 Tweak and reword release notes 2021-01-21 09:38:24 +01:00
Michał Kępień ad0d0b4d9c Tweak and reword recent CHANGES entries 2021-01-21 09:38:24 +01:00
Michal Nowak 0ea4f682f3 Merge branch 'mnowak/fsanitize-thread-hijacks-dlopen-and-dlclose-use-dlsym' into 'v9_11'
Use dlsym for -ldl detection

See merge request isc-projects/bind9!4575
2021-01-19 08:04:47 +00:00
Michal Nowak c857e63087 Use dlsym for -ldl detection
-fsanitize=thread hijacks dlopen() and dlclose(), therefore dlopen()
won't request -ldl to be used for linking during Autoconf test. Check
for dlsym() presence will fail and dlzexternal and dyndb system tests
won't run.

Retrieved from 2dd54fa62f.
2021-01-19 08:05:54 +01:00
Michał Kępień 1c44767d46 Merge branch 'michal/improve-danger-checks-v9_11' into 'v9_11'
[v9_11] Improve Danger checks

See merge request isc-projects/bind9!4578
2021-01-18 14:16:57 +00:00
Michał Kępień f0c79dbab1 Skip subject line length check for merge commits
Some merge requests (e.g. those created for release branches) include
merge commits.  Prevent Danger from warning about excessive subject line
length for merge commits.  (While the proper way to detect a merge
commit would be to check the 'parents' attribute of a commit object,
Danger Python does not seem to populate that attribute, so a simple
string search is performed on the commit subject instead.)

(cherry picked from commit bc42690c99)
2021-01-18 15:14:55 +01:00
Michał Kępień 029a873329 Skip length check for lines containing references
The Danger GitLab CI job currently flags excessively long lines in
commit log messages.  Exclude lines containing references (i.e. starting
with "[1]", "[2]", etc.) from this check.  This allows e.g. long URLs to
be included in commit log messages without triggering Danger warnings.

(cherry picked from commit 09964e8085)
2021-01-18 15:14:55 +01:00
Michał Kępień 7e6f583f41 Only warn about fixup commits once per run
The Danger GitLab CI job currently generates a separate error message
about fixup commits being present in a merge request for every such
commit found.  Prevent that by making it only log that error message
once per run.

(cherry picked from commit 801d13f62f)
2021-01-18 15:14:55 +01:00
Michał Kępień 584032ac38 Flag trailing dots in commit subject lines
Make the Danger GitLab CI job fail when the subject line for any commit
belonging to a merge request contains a trailing dot.

(cherry picked from commit 953c810f41)
2021-01-18 15:14:55 +01:00
Michał Kępień 1ca23a2f54 Flag missing pairwise testing markers
Make the Danger GitLab CI job fail when a merge request adds a new
./configure switch without also adding a "# [pairwise: ...]" marker that
the relevant GitLab CI job uses for preparing the pairwise testing
model.  This helps to ensure that any newly added ./configure switches
are tested by the pairwise testing GitLab CI job.

(cherry picked from commit ff58ec8cef)
2021-01-18 15:14:55 +01:00
Michał Kępień a32ba5692a Suggest adding release notes for customer issues
Make Danger suggest adding a release note to a merge request if the
latter is marked with the "Customer" label but not with the "Release
Notes" label.

(cherry picked from commit d81ad454cc)
2021-01-18 15:14:55 +01:00
Michał Kępień 2a6f00e34c Handle [placeholder] CHANGES entries
Make the Danger GitLab CI job fail when a merge request targeting a
branch different than "main" adds any [placeholder] entries to the
CHANGES file.  Prevent Danger from flagging missing GitLab identifiers
for [placeholder] CHANGES entries.

(cherry picked from commit 2f77c7680a)
2021-01-18 15:14:55 +01:00
Michał Kępień 40b12b0cb2 Flag missing CVE identifiers
Make Danger ensure that if a merge request fixes a security issue then
that merge request includes a CHANGES entry and a release note, both of
which contain a CVE identifier.

(cherry picked from commit 97364f5518)
2021-01-18 15:14:55 +01:00
Michal Nowak e56554052c Merge branch '2323-add-non-threaded-CI-jobs' into 'v9_11'
[v9_11] Add --disable-threads to noatomics build job in CI

See merge request isc-projects/bind9!4450
2021-01-13 17:25:15 +00:00
Michal Nowak b23215ed19 Add --disable-threads to noatomics build job in CI 2021-01-13 18:10:24 +01:00
Michał Kępień 876dda6398 Merge branch '2366-add-CHANGES-entry-v9_11' into 'v9_11'
[v9_11] Add CHANGES entry for GL #2366

See merge request isc-projects/bind9!4546
2021-01-08 11:54:11 +00:00