Commit Graph
3642 Commits
Author SHA1 Message Date
Brian Wellington dd4eb0b460 code review, including fixes to suspicious looking memcmp()s 2000-03-17 02:47:01 +00:00
Michael Graff 85418c6d45 remove unused locals 2000-03-17 02:19:55 +00:00
Michael Graff 4c53bc1e9a missed a ; in there 2000-03-17 02:17:39 +00:00
Michael Graff 62c1de9d94 review; UNUSED(); minor formatting 2000-03-17 02:11:36 +00:00
Brian Wellington d44826d99c code review changes 2000-03-17 01:48:29 +00:00
Michael Graff 8dd2e6e7c1 formatting, review 2000-03-17 01:22:17 +00:00
Brian Wellington a063ed5f51 code review 2000-03-17 00:50:14 +00:00
Brian Wellington 65debe7629 code review cleanup 2000-03-17 00:15:30 +00:00
Bob Halley d72c8b8c6a Do not detach 'db' in the NOTFOUND case if it is NULL. This should not
happen, but is a possible result if the resolver returned NOTFOUND.
2000-03-17 00:07:02 +00:00
Bob Halley 0ec4b862c9 checkpoint 2000-03-17 00:01:28 +00:00
James Brister cd30495b0c code review changes 2000-03-17 00:01:18 +00:00
Bob Halley 7457bbd82f secroots is now a keytable; add trustedkeys keytable 2000-03-17 00:00:18 +00:00
Bob Halley f187c911b8 use keytables 2000-03-16 23:59:33 +00:00
Bob Halley 79e06a7909 dns_keytable_issecuredomain did not set result correctly on success 2000-03-16 23:57:02 +00:00
James Brister a4ed9791ed code review changes. 2000-03-16 23:51:09 +00:00
Brian Wellington 8732b497cf formatting changes during code review 2000-03-16 23:40:50 +00:00
Brian Wellington 5766ea1011 Avoid calling dst_verify with an empty region 2000-03-16 23:13:25 +00:00
Andreas Gustafsson 691b60f24e return zero-length signature/other data as zero-sized
isc_mem_get() blocks, not NULL pointers
2000-03-16 23:13:02 +00:00
Michael Graff 8e06cea14c check for emacs-etags, and etags, and set @ETAGS@ as needed. 2000-03-16 23:04:37 +00:00
James Brister c559e42c7e Uninitialized variable fixed. 2000-03-16 22:53:37 +00:00
Bob Halley d4a4b9ffd6 add dst_key_iszonekey, KEYFLAG and KEYPROTO values 2000-03-16 22:43:54 +00:00
Bob Halley 9dcab19457 add dst_key_iszonekey 2000-03-16 22:43:33 +00:00
Bob Halley 1db2e6b81a rdata code review 2000-03-16 22:42:32 +00:00
Andreas Gustafsson 76e9eb5ba6 document relevant RFC number 2000-03-16 22:42:31 +00:00
Andreas Gustafsson 1c497c6e34 in fromwire_opt, the option field was used as both
option and length; stylistic changes from code review
2000-03-16 22:42:10 +00:00
Bob Halley 6a02971368 don't define ISC_MEMPOOL_NAMES 2000-03-16 22:40:48 +00:00
Bob Halley 2190526544 Allow zero length allocations/deallocations. 2000-03-16 22:39:46 +00:00
Michael Graff 940e4ef72b add reviewed, minor formatting changes 2000-03-16 22:07:28 +00:00
Michael Graff 325f2a0960 add reviewed by, and minor formatting nits 2000-03-16 21:58:58 +00:00
Andreas Gustafsson 954f31569c code review 2000-03-16 21:50:14 +00:00
Brian Wellington 763340ccb3 Rewrote handling of the NULL record to match RFC 1035 2000-03-16 21:49:42 +00:00
David Lawrence aaf2232697 dereference ns_g_omapimgr in listen_done 2000-03-16 20:04:47 +00:00
Mark Andrews acb0311b11 dns_message_renderreset should cause the message to forget the render
buffer.
2000-03-16 06:51:04 +00:00
David Lawrence 659c68b446 Reviewed.
use UNUSED() macros.
2000-03-16 02:31:14 +00:00
James Brister ecd3b66f8c code review changes 2000-03-16 02:23:17 +00:00
Michael Graff 923d996a97 no local, comment NONE or GLOBAL14 2000-03-16 02:20:19 +00:00
Michael Graff f4b24db598 mostly UNUSED() changes, minor formatting things 2000-03-16 02:18:16 +00:00
Brian Wellington 5fe1a9797c code review 2000-03-16 02:16:16 +00:00
David Lawrence 8cb85014a7 added Reviewed comment 2000-03-16 02:15:52 +00:00
Brian Wellington c363150ad5 more code review 2000-03-16 02:08:51 +00:00
James Brister 96805adfc9 code review changes 2000-03-16 02:07:06 +00:00
James Brister ce8b84ce64 more code review changes. 2000-03-16 02:00:37 +00:00
Brian Wellington c2bb855911 code review 2000-03-16 01:44:08 +00:00
David Lawrence 926234e867 In fromtext_cert:
.	removed strtol which was irrelevant (its results were not checked,
	and dns_cert_fromtext did the real parsing).
      . removed redundant range checking (uint16_tobuffer did the same
	checking.
Use UNUSED() macro.
draft-ietf-dnssec-certs-04.txt -> RFC 2538
2000-03-16 01:43:42 +00:00
James Brister 3b811bd920 code review changes 2000-03-16 01:40:27 +00:00
James Brister ee7cac1c6e code review changes. 2000-03-16 01:37:14 +00:00
James Brister 4f64d3ae93 code review changes 2000-03-16 01:31:03 +00:00
Brian Wellington d5c518af63 code review 2000-03-16 01:26:49 +00:00
James Brister ec04f989ea code review changes 2000-03-16 01:15:36 +00:00
Andreas Gustafsson 91ae8a0e72 annotated 2000-03-16 01:09:32 +00:00