Commit Graph
29258 Commits
Author SHA1 Message Date
Mark Andrews dc88bd641d Address unchecked returns leading to NULL pointer dereferences
on out of memory conditions.
2021-02-25 11:44:28 +11:00
Michal Nowak cfcd42f6a2 Merge branch '2446-query-c-5430-16-runtime-error-v9_11' into 'v9_11'
[v9_11] Initialize checknames field in dns_view_create()

See merge request isc-projects/bind9!4736
2021-02-23 16:48:54 +00:00
Michal Nowak b9ef330fbe Initialize checknames field in dns_view_create()
The 'checknames' field wasn't initialized in dns_view_create(), but it
should otherwise AddressSanitizer identifies the following runtime error
in query_test.c.

    runtime error: load of value 190, which is not a valid value for type '_Bool'

(cherry picked from commit 0c6fa16477)
2021-02-23 16:48:10 +01:00
Michal Nowak aa4d0ab62d Merge branch 'mnowak/alpine-3.13-v9_11' into 'v9_11'
[v9_11] Add Alpine Linux 3.13

See merge request isc-projects/bind9!4733
2021-02-23 15:05:17 +00:00
Michal Nowak 85f7448c37 Add Alpine Linux 3.13
(cherry picked from commit 909c85f7a9)
2021-02-23 15:48:52 +01:00
Michal Nowak d16cba2698 Merge branch 'mnowak/pairwise-pict-keep-stderr-v9_11' into 'v9_11'
[v9_11] Do not remove stderr from pict output

See merge request isc-projects/bind9!4731
2021-02-23 14:32:35 +00:00
Michal Nowak eb576888da Do not remove stderr from pict output
Removing stderr from the pict tool serves no purpose and drops valuable
information, we might use when debugging failed pairwise CI job, such
as:

    Input Error: A parameter names must be unique

(cherry picked from commit 079debaa10)
2021-02-23 15:27:59 +01:00
Mark Andrews e42577800b Merge branch '2499-a-loc-record-with-a-invalid-direction-field-triggers-an-insist-v9_11' into 'v9_11'
Resolve "A LOC record with a invalid direction field triggers an INSIST"

See merge request isc-projects/bind9!4712
2021-02-19 01:07:26 +00:00
Mark Andrews 894f25082e Add release note for [GL #2499]
(cherry picked from commit 3d340ecfd2)
2021-02-19 11:44:08 +11:00
Mark Andrews 5e2b287f63 Add CHANGES for [GL #2499]
(cherry picked from commit 6f47e0956c)
2021-02-19 11:41:02 +11:00
Mark Andrews 0ee76590d6 Correctly detect when get_direction failed
(cherry picked from commit 009358d77d)
2021-02-19 11:40:05 +11:00
Mark Andrews 4af7a5f1b1 Test a LOC record with an invalid direction field
(cherry picked from commit 07902d9f9d)
2021-02-19 11:40:04 +11:00
Michal Nowak 4e8f6962f0 Merge branch 'mnowak/make-kyua-report-html-less-verbose-v9_11' into 'v9_11'
[v9_11] Make "kyua report-html" less verbose on stdout

See merge request isc-projects/bind9!4708
2021-02-18 14:58:05 +00:00
Michal Nowak b3cc0b6128 Make "kyua report-html" less verbose on stdout
"kyua report-html" command in CI generates more than two pages of output
to stdout, which is nothing but which HTML pages Kyua generated, e.g.:

  Generating kyua_html/context.html
  Generating kyua_html/lib_dns_tests_acl_test_main.html
  ...
  Generating kyua_html/lib_ns_tests_query_test_main.html
  Generating kyua_html/report.css
  Generating kyua_html/index.html

This is seldomly useful and requires the user to scroll three pages
upwards to get to unit test results.

(cherry picked from commit 74fa196286)
2021-02-18 15:49:37 +01:00
Michal Nowak 5a179636b2 Merge branch 'mnowak/system-test-check-for-file-not-removed-v9_11' into 'v9_11'
[v9_11] Check for "file not removed" in system test output

See merge request isc-projects/bind9!4705
2021-02-18 10:14:08 +00:00
Michal Nowak 936f7a2da9 Prevent Git to expand $systest
CentOS 8 "git status" unexpectedly expands search directory "tsig" to
also search in the "tsiggss" directory, thus incorrectly identifying
files as "not removed" in the "tsig" directory:

$ git status -su --ignored tsig
$ touch tsiggss/ns1/{named.run,named.memstats}
$ git status -su --ignored tsig
!! tsiggss/ns1/named.memstats
!! tsiggss/ns1/named.run

(cherry picked from commit f310b75250)
2021-02-18 10:16:30 +01:00
Michal Nowak c6fcb29a27 Clean omitted files from system tests
Any CI job:
- I:dns64:file ns1/Ksigned.+005+*.key not removed
- I:dns64:file ns1/Ksigned.ns1/Ksigned.+005+*.private
- I:dns64:file ns1/Ksigned.ns1/Ksigned.+005+*.key
- I:dns64:file ns1/Ksigned.ns1/Ksigned.+005+*.private
- I:dns64:file ns1/Ksigned.ns1/dsset-signed.
- I:dns64:file ns1/Ksigned.ns1/named.conf
- I:dns64:file ns1/Ksigned.ns1/signed.db
- I:dns64:file ns1/Ksigned.ns1/signed.db.signed
- I:dns64:file ns1/Ksigned.ns2/named.conf
- I:ixfr:file ns5/named.run.prev not removed
- I:legacy:file ns1/named_dump.db.test20 not removed

(cherry picked from commit 14a104d121)
2021-02-18 10:05:18 +01:00
Michal Nowak 588084a930 Check for "file not removed" in system test output
Run this check only when in Git repository, because run.sh produces the
"file not removed" warnings only when in Git repository.

(cherry picked from commit 4a2778abdf)
2021-02-18 09:44:31 +01:00
Michal Nowak eb26769b45 Add system test name to "file not removed" info
(cherry picked from commit 10bf725ee2)
2021-02-18 09:42:12 +01:00
Michał Kępień 146f62140c Merge branch 'michal/add-doc-arm-notes-9.11.29.xml-to-util-copyrights' into 'v9_11'
Add doc/arm/notes-9.11.29.xml to util/copyrights

See merge request isc-projects/bind9!4702
2021-02-17 22:05:23 +00:00
Michał Kępień 4d96e4cee0 Add doc/arm/notes-9.11.29.xml to util/copyrights
Commit 81446d61c3 did not update
util/copyrights as it should have.  Add the missing line to prevent the
"misc" GitLab CI job from failing.
2021-02-17 23:01:29 +01:00
Michał Kępień ae703e371b Merge branch 'v9_11_28-release' into 'v9_11'
Merge 9.11.28 release branch

See merge request isc-projects/bind9!4701
2021-02-17 21:55:48 +00:00
Michał Kępień 81446d61c3 Set up release notes for BIND 9.11.29 2021-02-17 22:51:34 +01:00
Michał Kępień fdd5b1df80 Bump BIND_BASELINE_VERSION for ABI checks 2021-02-17 22:51:34 +01:00
Tinderbox UserandMichał Kępień d90c8a098f Merge branch 'prep-release' into security-v9_11 2021-02-17 22:46:14 +01:00
Michał Kępień 6f24003573 Merge branch 'michal/prepare-documentation-for-bind-9.11.28' into 'security-v9_11'
Prepare release notes for BIND 9.11.28

See merge request isc-private/bind9!241
2021-02-17 22:46:14 +01:00
Tinderbox UserandMichał Kępień 43ef3488bf prep 9.11.28 2021-02-17 22:46:14 +01:00
Michał Kępień dc5f0e77ec Merge branch '2354-security-off-by-one-error-in-spnego-v9_11' into 'security-v9_11'
[v9_11] [CVE-2020-8625] Fix off-by-one bug in ISC SPNEGO implementation

See merge request isc-private/bind9!238
2021-02-17 22:46:14 +01:00
Michał Kępień ae6fc963b6 Prepare release notes for BIND 9.11.28 2021-02-17 22:46:14 +01:00
Ondřej SurýandMichał Kępień e145c40c93 Add CHANGES and release note for GL #2354 2021-02-17 22:46:14 +01:00
Ondřej SurýandMichał Kępień abed9404d1 Fix off-by-one bug in ISC SPNEGO implementation
The ISC SPNEGO implementation is based on mod_auth_kerb code.  When
CVE-2006-5989 was disclosed, the relevant fix was not applied to the
BIND 9 codebase, making the latter vulnerable to the aforementioned flaw
when "tkey-gssapi-keytab" or "tkey-gssapi-credential" is set in
named.conf.

The original description of CVE-2006-5989 was:

    Off-by-one error in the der_get_oid function in mod_auth_kerb 5.0
    allows remote attackers to cause a denial of service (crash) via a
    crafted Kerberos message that triggers a heap-based buffer overflow
    in the component array.

Later research revealed that this flaw also theoretically enables remote
code execution, though achieving the latter in real-world conditions is
currently deemed very difficult.

This vulnerability was responsibly reported as ZDI-CAN-12302 ("ISC BIND
TKEY Query Heap-based Buffer Overflow Remote Code Execution
Vulnerability") by Trend Micro Zero Day Initiative.
2021-02-17 22:46:14 +01:00
Petr Špaček 68dfe7bf57 Merge branch 'pspacek/ci-python-allthetime-v9_11' into 'v9_11'
[v9_11] Run Python linters in CI even outside of merge requests

See merge request isc-projects/bind9!4676
2021-02-15 09:33:56 +00:00
Petr Špaček 8228d78e03 Run Python linters in CI even outside of merge requests
Previously it did not get run on scheduled CI pipelines.

(cherry picked from commit 74d7cddc4c)
2021-02-15 10:26:56 +01:00
Michal Nowak fb46f5b205 Merge branch 'mnowak/check-for-unrecognized-options-v9_11' into 'v9_11'
[v9_11] Check for unrecognized configure options

See merge request isc-projects/bind9!4565
2021-02-12 15:02:10 +00:00
Michal Nowak 10d272bc35 Add --enable-option-checking=fatal to ./configure in CI
The --enable-option-checking=fatal option prevents ./configure from
proceeding when an unknown option is used in the ./configure step in CI.
This change will avoid adding unsupported ./configure options or options
with typo or typo in pairwise testing "# [pairwise: ...]" marker.

(cherry picked from commit 4295c82e45)
2021-02-12 14:27:21 +01:00
Michal Nowak 45ec9f37a7 Drop mutexatomics CI jobs
The --enable-mutex-atomics switch for ./configure is not available in
BIND 9.11.  Remove the jobs attempting to test it from GitLab CI
configuration.
2021-02-12 14:24:37 +01:00
Michal Nowak 196cdf12ca Replace --disable-geoip option with --with-geoip
--disable-geoip is not a valid switch for ./configure.  Use
--without-geoip2 instead in GitLab CI.
2021-02-12 14:22:49 +01:00
Michal Nowak 0a80a9b498 Drop unsupported configure options
The --enable-pthread-rwlock and --enable-mutex-atomics switches for
./configure are not available in BIND 9.11.  Do not attempt using them
in GitLab CI.
2021-02-12 14:22:49 +01:00
Michal Nowak c207a2e476 Merge branch '2312-lint-generated-manual-pages-v9_11' into 'v9_11'
[v9_11] Lint manual pages

See merge request isc-projects/bind9!4674
2021-02-12 12:41:06 +00:00
Michal Nowak 8ec37aaf91 Lint manual pages
As we generate manual pages from DocBook sources, we don't have absolute
control on manual page output and therefore 'mandoc -Tlint' may always
report warnings we can't eliminate. In light of this linting level was
set for mandoc to '-Werror' to ignore warnings and style issues, only
errors are reported.

(cherry picked from commit 22fdcb30db)
2021-02-12 13:04:55 +01:00
Michal Nowak 7cc88b385e Merge branch 'mnowak/check-asan-errors-in-configure-v9_11' into 'v9_11'
[v9_11] Check config.log for ASAN errors

See merge request isc-projects/bind9!4657
2021-02-09 11:44:27 +00:00
Michal Nowak f9da4b31ab Check config.log for ASAN errors
./configure checks might produce a false negative error due to ASAN
errors and thus disable some options.

(cherry picked from commit 0db934d401)
2021-02-09 12:08:13 +01:00
Michal Nowak 8740f2b97c Merge branch 'mnowak/free-openssl-keys-in-configure' into 'v9_11'
Free OpenSSL keys in ./configure

See merge request isc-projects/bind9!4656
2021-02-08 09:14:29 +00:00
Mark AndrewsandMichal Nowak edd6d5884a Free OpenSSL keys in ./configure
Failure to free OpenSSL keys in ./configure results in ASAN errors and
false negative errors.
2021-02-08 08:57:06 +01:00
Michal Nowak f082ed9d57 Merge branch 'mnowak/check-arm-pdf-validity-v9_11' into 'v9_11'
[v9_11] Check PDF file structure with QPDF

See merge request isc-projects/bind9!4652
2021-02-03 17:03:57 +00:00
Michal Nowak 3a5ccdb314 Check PDF file structure with QPDF
"qpdf --check" checks file structure of generated ARM PDF.

(cherry picked from commit 359708b9d6)
2021-02-03 17:59:16 +01:00
Mark Andrews f944568333 Merge branch '2093-tsan-files-are-not-being-captured-by-unit-tests-2-v9_11' into 'v9_11'
Look for tsan files in the top build directory

See merge request isc-projects/bind9!4639
2021-02-02 22:26:53 +00:00
Mark Andrews adbd30692a Look for tsan files in the top build directory
(cherry picked from commit 48715f6ad4)
2021-02-03 08:56:13 +11:00
Michal Nowak 09c3afb886 Merge branch 'mnowak/add-rsabigexponent-README-v9_11' into 'v9_11'
[v9_11] Add README.md file to rsabigexponent system test

See merge request isc-projects/bind9!4632
2021-01-29 15:03:07 +00:00
Michal Nowak aee29f7c17 Add README.md file to rsabigexponent system test
This README.md describes why is bigkey needed.

(cherry picked from commit a247f24dfa)
2021-01-29 15:48:39 +01:00