Commit Graph

35150 Commits

Author SHA1 Message Date
Aram Sargsyan
d6568bea7c Add tests for CVE-2022-3924
Reproduce the assertion by configuring a 'named' resolver with
'recursive-clients 10;' configuration option and running 20
queries is parallel.

Also tweak the 'ans2/ans.pl' to simulate a 50ms network latency
when qname starts with "latency". This makes sure that queries
running in parallel don't get served immediately, thus allowing
the configured recursive clients quota limitation to be activated.

(cherry picked from commit 4b52b0b4a9)
2023-02-22 10:59:31 +01:00
Matthijs Mekking
84929d1cd7 Merge branch 'matthijs-fix-kasp-attach-detach-usage-v9_16' into 'v9_16'
[9.16] Fix dns_kasp_attach / dns_kasp_detach usage

See merge request isc-projects/bind9!7567
2023-02-22 07:26:35 +00:00
Mark Andrews
b49a3a56c9 Fix dns_kasp_attach / dns_kasp_detach usage
The kasp pointers in dns_zone_t should consistently be changed by
dns_kasp_attach and dns_kasp_detach so the usage is balanced.

(cherry picked from commit b41882cc75)
2023-02-21 16:58:42 +01:00
Tom Krizek
e920857601 Merge branch '3874-the-7530-broke-mkeys-test-on-windows' into 'v9_16'
Resolve "The !7530 broke mkeys test on Windows"

See merge request isc-projects/bind9!7550
2023-02-20 13:32:27 +00:00
Mark Andrews
552b5152a0 Source conf.sh the v9_16 way 2023-02-19 10:59:08 +00:00
Mark Andrews
7279c3826e Merge branch '3879-hmac_createctx-fails-to-free-context-on-isc_hmac_init-failure-v9_16' into 'v9_16'
[9.16] Resolve "hmac_createctx fails to free context on isc_hmac_init failure"

See merge request isc-projects/bind9!7557
2023-02-18 00:49:48 +00:00
Mark Andrews
d0c92a31a9 In hmac_createctx free ctx on isc_hmac_init failure
(cherry picked from commit d22257a370)
2023-02-18 10:27:11 +11:00
Michal Nowak
4b64ccf50e Merge branch 'mnowak/qa-tools-update-v9_16' into 'v9_16'
[9.16] Python formatting updates

See merge request isc-projects/bind9!7554
2023-02-17 17:59:14 +00:00
Michal Nowak
e0158ab2b5 Adapt to Python scripts to black 23.1.0
(cherry picked from commit 3cd2cc6254)
2023-02-17 16:55:47 +01:00
Michal Nowak
596918c57a Fix unnecessary "else" after "raise" with pylint 2.16.2
bin/tests/system/get_algorithms.py:225:4: R1720: Unnecessary "else" after "raise", remove the "else" and de-indent the code inside it (no-else-raise)

(cherry picked from commit 8064ac6bec)
2023-02-17 16:55:24 +01:00
Michal Nowak
17b954141b Merge branch 'mnowak/enable-windows-system-tests-in-merge-requests' into 'v9_16'
Run system:msvc:windows:amd64 for merge requests

See merge request isc-projects/bind9!7543
2023-02-16 19:37:52 +00:00
Michal Nowak
7221221fd7 Run system:msvc:windows:amd64 for merge requests
Historically, we avoided running system tests on Windows for merge
request-triggered pipelines because we have only one limited GitLab
Runner, which would be unable to reliably sustain the CI load of merge
requests for three maintained branches, and instead, we opted for
running Windows system tests in daily pipelines. CI load should no
longer be an issue since "v9_16" is the only (and last) maintained
branch with Windows support. We are only left with the downside of
failing to run system tests for merge requests on Windows: missing
Windows-specific quirks in the review process and finding out about them
only a day later in the daily pipeline (e.g., #3865 and #3874 from this
week).
2023-02-16 20:30:43 +01:00
Michal Nowak
fed8a373a3 Merge tag 'v9_16_38' into v9_16
BIND 9.16.38
2023-02-16 17:53:48 +01:00
Mark Andrews
f9a1e293d2 Merge branch 'feature/main/fips-tests-v9_16' into 'v9_16'
[9.16] FIPS tests changes for RHEL

See merge request isc-projects/bind9!7541
2023-02-15 22:11:54 +00:00
Mark Andrews
1b5848aebe Add CHANGES note for [GL !7417]
(cherry picked from commit 55a6b15087)
2023-02-16 08:49:06 +11:00
Petr Menšík
3f81fbed12 FIPS tests changes for RHEL
Include MD5 feature detection in featuretest tool and use it in some
places. When RHEL distribution or Fedora ELN is in FIPS mode, then MD5
algorithm is unavailable completely and even hmac-md5 algorithm usage
will always fail. Work that around by checking MD5 works and if not,
skipping its usage.

Those changes were dragged as downstream patch bind-9.11-fips-tests.patch
in Fedora and RHEL.

(cherry picked from commit 6ad794a8cd)
2023-02-16 08:48:39 +11:00
Ondřej Surý
77fb1a4dc8 Merge branch '3865-failing-windows-system-tests-due-to-libuv-version-check' into 'v9_16'
Resolve "Failing windows system tests due to libuv version check"

See merge request isc-projects/bind9!7536
2023-02-15 11:28:08 +00:00
Ondřej Surý
100c20b470 Don't check for maximal version on Windows
The Windows doesn't have support for recvmmsg(), so we don't need to
check for maximal version on Windows (only for a minimal version).

Remove the MAXIMAL_VERSION when compiling on Windows.
2023-02-15 11:02:57 +01:00
Mark Andrews
5ce64ea878 Merge branch '3662-extend-mkeys-system-test-to-handle-islands-of-trust-v9_16' into 'v9_16'
[9.16] Resolve "Extend mkeys system test to handle islands of trust"

See merge request isc-projects/bind9!7530
2023-02-14 22:34:09 +00:00
Mark Andrews
d0fd97f67c Add CHANGES note for [GL #3662]
(cherry picked from commit 2928f21733)
2023-02-14 22:09:52 +00:00
Mark Andrews
9109f38ece Add islands of trust to mkeys test
This adds an island of trust that is reachable from the root
where the trust anchors are added to island.conf.

This add an island of trust that is not reachable from the root
where the trust anchors are added to private.conf.

(cherry picked from commit 41bdb5b9fe)
2023-02-14 22:09:52 +00:00
Mark Andrews
4df6019c16 Report the key name that failed in retry_keyfetch
When there are multiple managed trust anchors we need to know the
name of the trust anchor that is failing.  Extend the error message
to include the trust anchor name.

(cherry picked from commit fb7b7ac495)
2023-02-14 22:09:52 +00:00
Evan Hunt
9507facb36 Merge branch '3673-delay-trust-anchor-management-v9_16' into 'v9_16'
[9.16] Merge branch '3673-delay-trust-anchor-management' into 'main'

See merge request isc-projects/bind9!7534
2023-02-14 19:07:10 +00:00
Evan Hunt
aca10608b6 delay trust anchor management until zones are loaded
it was possible for a managed trust anchor needing to send a key
refresh query to be unable to do so because an authoritative zone
was not yet loaded. this has been corrected by delaying the
synchronization of managed-keys zones until after all zones are
loaded.

(cherry picked from commit bafbbd2465)
2023-02-14 10:23:28 -08:00
Tom Krizek
89ed0724e2 Merge branch '3848-increase-wait-time-runtime-test-v9_16' into 'v9_16'
[9.16] Increase named startup wait time for runtime test

See merge request isc-projects/bind9!7525
2023-02-13 16:02:45 +00:00
Tom Krizek
208777b74e Increase named startup wait time for runtime test
Occasionally, the allotted 10 seconds for the "running" line to appear
in log after named is started proved insufficient in CI, especially
during increased load. Give named up to 60 seconds to start up to
mitigate this issue.

(cherry picked from commit b8bb4233e8)
2023-02-13 16:11:04 +01:00
Michal Nowak
12e323dd2e Merge branch '3846-nsupdate-test-fix-v9_16' into 'v9_16'
[9.16] increase simultaneous updates for quota test

See merge request isc-projects/bind9!7522
2023-02-13 15:03:01 +00:00
Evan Hunt
5d0a8996ce increase simultaneous updates for quota test
the nsupdate system test was intermittently failing due to the update
quota not being exceeded when it should have been.  this is most likely
a timing issue: the client is sending updates too slowly, or the server
is processing them too quickly, for the quota to fill. this commit
attempts to make that the failure less likely by increasing the number
of update transactions from 10 to 20.

(cherry picked from commit 06b1faf068)
2023-02-13 13:36:11 +01:00
Ondřej Surý
dd0ce8e218 Merge branch 'pspacek/make-manin-on-dist-v9_16-fix2' into 'v9_16'
Use placeholders in pre-generated manpages in the tarball

See merge request isc-projects/bind9!7520
2023-02-10 17:46:02 +00:00
Ondřej Surý
0c7bd27598 Use placeholders in pre-generated manpages in the tarball
When pre-generating the manpages in the tarball-create CI job, we need
to use placeholders, and not the final values.
2023-02-10 18:40:34 +01:00
Ondřej Surý
3ff297e9fe Merge branch 'pspacek/make-manin-on-dist-v9_16' into 'v9_16'
[9.16] Remove pregenerated manpages from the repo

See merge request isc-projects/bind9!7518
2023-02-10 12:41:04 +00:00
Ondřej Surý
18b7ba3ea3 Test the pre-generated man pages in GitLab CI
Add an extra job for a build from tarball, but without sphinx-build and
enable RUN_MAKE_INSTALL to check that man pages were generated and
installed.

Disable the RUN_MAKE_INSTALL on the systems without sphinx-build (sid).

(cherry picked from commit 8f2e1e15cc)
2023-02-10 13:13:34 +01:00
Petr Špaček
c07e8b4a65 Remove pregenerated manpages from the repo
We don't need them in the repo, it's sufficient if we pregenerate them
while preparing the tarball.  That way we don't have overhead while
modifying them but they are still available for installations without
Sphinx.

I assume that this will make rebases and cherry-picks across branches
easier, with less trial and error churn required in the CI.

It's implemented in the way that we build the manpages only when we
either have pregenerated pages available at the configure time or
sphinx-build is installed and working.

(cherry picked from commit 9110465194)
2023-02-10 13:02:24 +01:00
Michał Kępień
5e85e8e524 Merge branch '3840-avoid-libuv-with-broken-recvmmsg-v9_16' into 'v9_16'
[9.16] Avoid libuv 1.35 and 1.36 that have broken recvmmsg implementation

See merge request isc-projects/bind9!7483
2023-02-10 06:00:04 +00:00
Ondřej Surý
2709a3c962 Add CHANGES and release note for [GL #3840]
(cherry picked from commit 6fa48c963e)
2023-02-10 06:50:32 +01:00
Ondřej Surý
b163ca9f97 Enforce version drift limits for libuv
libuv support for receiving multiple UDP messages in a single system
call (recvmmsg()) has been tweaked several times between libuv versions
1.35.0 and 1.40.0.  Mixing and matching libuv versions within that span
may lead to assertion failures and is therefore considered harmful, so
try to limit potential damage be preventing users from mixing libuv
versions with distinct sets of recvmmsg()-related flags.

(cherry picked from commit 735d09bffe)
2023-02-10 06:50:32 +01:00
Ondřej Surý
9309589ad0 Avoid libuv 1.35 and 1.36 that have broken recvmmsg implementation
The implementation of UDP recvmmsg in libuv 1.35 and 1.36 is
incomplete and could cause assertion failure under certain
circumstances.

Modify the configure and runtime checks to report a fatal error when
trying to compile or run with the affected versions.

(cherry picked from commit 251f411fc3)
2023-02-10 06:50:32 +01:00
Mark Andrews
7a6233a816 Merge branch '3852-follow-up-from-9-18-merge-branch-3790-use-configured-udp-port-into-main-v9_16' into 'v9_16'
[9.16] Allow some time to the root trust anchor to appear

See merge request isc-projects/bind9!7499
2023-02-07 22:26:57 +00:00
Mark Andrews
539f29d412 Allow some time to the root trust anchor to appear
Following deleting the root trust anchor and reconfiguring the
server it takes some time to for trust anchor to appear in 'rndc
managed-keys status' output.  Retry several times.

(cherry picked from commit 71dbd09796)
2023-02-08 00:46:41 +11:00
Michal Nowak
061d4e2f8b Merge branch 'mnowak/set-up-version-and-release-notes-for-bind-9.16.39' into 'v9_16'
Set up release notes for BIND 9.16.39

See merge request isc-projects/bind9!7497
2023-02-07 11:03:42 +00:00
Michal Nowak
ae79bfe94d Set up release notes for BIND 9.16.39 2023-02-07 11:28:48 +01:00
Michal Nowak
1d21a46e34 Update BIND version to 9.16.39-dev 2023-02-07 11:27:17 +01:00
Michal Nowak
af0056a44e Merge branch 'prep-release' into v9_16_38-release v9.16.38 2023-02-03 18:17:35 +01:00
Michal Nowak
0f23774d87 prep 9.16.38 2023-02-03 18:13:37 +01:00
Michal Nowak
7fe7ed258a Merge branch 'michal/prepare-documentation-for-bind-9.16.38' into 'v9_16_38-release'
Prepare documentation for BIND 9.16.38

See merge request isc-private/bind9!497
2023-02-03 16:58:07 +00:00
Michał Kępień
0d63f06af7 Add release note for GL #3827 2023-02-03 13:21:19 +01:00
Michał Kępień
2abb185eca Tweak and reword release notes 2023-02-03 13:21:19 +01:00
Michał Kępień
de9c8ff27f Prepare release notes for BIND 9.16.38 2023-02-03 13:21:19 +01:00
Michał Kępień
c1e77063c0 Merge branch '3827-fix-dnsrps-builds-v9_16' into 'v9_16'
[9.16] Fix DNSRPS builds

See merge request isc-projects/bind9!7475
2023-02-01 11:47:27 +00:00
Michał Kępień
f933650204 Add CHANGES entry for GL #3827
(cherry picked from commit 493eadd1ae)
2023-02-01 12:07:11 +01:00