"journal.c", line 169: remark(1552): variable "zoneclass" was set but never
used
by removing zoneclass declaration and zoneclass = dns_db_class(db) from
dns_db_createsoatuple.
"adb.c", line 2042: remark(1552): variable "result" was set but never used
isc_result_t result;
^
"adb.c", line 3082: warning(1185): enumerated type mixed with another type
NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
^
"adb.c", line 3187: warning(1185): enumerated type mixed with another type
now, NAME_GLUEOK(adbname), NAME_HINTOK(adbname),
Note that the first is in timer_cleanup, a function returning void in a context
that can't do anything with something other than void (as an isc_taskaction_t).
It calls isc_timer_reset, which could conceivably return ISC_R_NOMEMORY or
ISC_R_UNEXPECTED. For now the call has been cast to void, but someone
who knows the code better should have a look and see whether something more
intelligent could be done with an error (and, if not, remove my XXX and
make sure the comment is clear as to why ignoring the return is the
best that can be done).
"confzone.c", line 445: remark(1552): variable "res" was set but never used
Made *_zone_init functions return void since they all always returned
ISC_R_SUCCESS.
"bsafe_link.c", line 116: remark(1692): prototyped function redeclared without
prototype
dst_s_bsafersa_init() {
and several variations of:
"bsafe_link.c", line 155: remark(1552): variable "status" was set but never
used
int status = 0;
along with style lint (notably bitwise operands used as truth values:
mode & DST_SIGMODE_INIT versus (mode & DST_SIGMODE_INIT) != 0.
170. [cleanup] Remove inter server consistancy checks from zone,
these should return as a seperate module in 9.1.
dns_zone_checkservers(), dns_zone_checkparents(),
dns_zone_checkchildren(), dns_zone_checkglue().
Remove dns_zone_setadb(), dns_zone_setresolver(),
dns_zone_setrequestmgr() these should now be found
via the view.
it overwrote old keys if new key key-id conflicted
It was generating non null-keys with id==0
It was not able to generate DSA null keys.
I changed size of maximum RSA key to 2048.
isc_file_fseek(), isc_file_fread(), isc_file_fwrite(),
isc_file_fflush(), isc_file_ffsync(), isc_file_remove()
to encapsulate nonportable usage of errno and fflush().
cc: "mem.c", line 173: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 180: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 188: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 194: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 205: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 212: warning 714: Function "malloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 222: warning 714: Function "realloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 228: warning 714: Function "realloc_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 236: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 242: warning 714: Function "free_debug_func" called with no prototype or definition in scope.
cc: "mem.c", line 258: warning 714: Function "set_debug_options_func" called with no prototype or definition in scope.
cc: "mem.c", line 264: warning 714: Function "get_debug_options_func" called with no prototype or definition in scope.
cc: "stack.c", line 231: warning 714: Function called with no prototype or definition in scope.
cc: "stack.c", line 275: warning 714: Function "func" called with no prototype or definition in scope.
cc: "lhash.c", line 294: warning 714: Function "func" called with no prototype or definition in scope.
cc: "lhash.c", line 401: warning 714: Function called with no prototype or definition in scope.
cc: "lhash.c", line 422: warning 714: Function called with no prototype or definition in scope.
David Lawrence
Mark Andrews
Michael Graff