ComputerSurge/bind9
3
0
Fork 0
Code Pull Requests 1 Activity

use isc_file_fopen() and isc_file_fclose();

Browse Source 
use the logging system, not UNEXPECTED_ERROR()
This commit is contained in:
Andreas Gustafsson
2000-05-09 23:32:13 +00:00
parent 84fcfe530b
commit 913bc4304d
1 changed files with 14 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
lib/dns/masterdump.c
View File

@@ -779,23 +779,26 @@ isc_result_t
dns_master_dump(isc_mem_t *mctx, dns_db_t *db, dns_dbversion_t *version,
const dns_master_style_t *style, const char *filename)
{
FILE *f;
FILE *f = NULL;
isc_result_t result;
f = fopen(filename, "w");
if (f == NULL) {
UNEXPECTED_ERROR(__FILE__, __LINE__,
"could not open %s",
filename);
result = isc_file_fopen(filename, "w", &f);
if (result != ISC_R_SUCCESS) {
isc_log_write(dns_lctx, ISC_LOGCATEOGORY_GENERAL,
DNS_LOGMODULE_MASTERDUMP, ISC_LOG_ERROR,
"dumping master file: %s: open: %s", filename,
isc_result_totext(result));
return (ISC_R_UNEXPECTED);
}
result = dns_master_dumptostream(mctx, db, version, style, f);
if (fclose(f) != 0) {
UNEXPECTED_ERROR(__FILE__, __LINE__,
"error closing %s",
filename);
result = isc_file_fclose(f);
if (result != ISC_R_SUCCESS) {
isc_log_write(dns_lctx, ISC_LOGCATEOGORY_GENERAL,
DNS_LOGMODULE_MASTERDUMP, ISC_LOG_ERROR,
"dumping master file: %s: close: %s", filename,
isc_result_totext(result));
return (ISC_R_UNEXPECTED);
}