Commit Graph
26582 Commits
Author SHA1 Message Date
Mark AndrewsandOndřej Surý ba238ab374 use %u instead of %d for unsigned int arguments
(cherry picked from commit 49f8e9571c)
2018-04-20 15:13:12 -07:00
Ondřej Surý 5e11b261f4 Merge branch '206-nslookup-accepts-any-bogus-option-interpret-it-as-vc-v9_12' into 'v9_12'
Resolve "nslookup accepts any -bogus -option, interpret it as -vc"

See merge request isc-projects/bind9!214
2018-04-20 18:01:02 -04:00
Mukund SivaramanandOndřej Surý a36f89341f Remove bogus comparison
(cherry picked from commit 89cf503880)
2018-04-20 14:51:26 -07:00
Ondřej Surý 7c830940b9 Merge branch '189-fix-win32-build-v9_12' into 'v9_12'
[v9_12] Fix runtime assertion on Windows due isc_file_template being out-of-sync

See merge request isc-projects/bind9!194
2018-04-12 03:00:44 -04:00
Ondřej Surý 6171037403 Sync isc_file_template functions between unix and win32, so they are same
(cherry picked from commit 8c99d104e3)
2018-04-12 08:47:11 +02:00
Ondřej Surý c4a7fbcc36 Merge branch '189-fix-tsig-dump-keyfile-name-generation-issues-v9_12' into 'v9_12'
[v9_12] Fix TSIG dump keyfile name generation issues

See merge request isc-projects/bind9!191
2018-04-11 08:45:17 -04:00
Mukund SivaramanandOndřej Surý c932fd2d49 Fix TSIG dump keyfile name buffer size issues
(cherry picked from commit 44b84cb5a6)
2018-04-11 14:37:46 +02:00
Ondřej Surý e052e7f427 Define PATH_MAX on Windows as _MAX_PATH, so we can use it everywhere
(cherry picked from commit 7467735258)
2018-04-11 14:37:46 +02:00
Evan Hunt 5ce20e4928 Merge branch '193-fix-variable-definitions-in-bin-tests-Makefile.in-v9_12' into 'v9_12'
Fix variable definitions in bin/tests/Makefile.in

Closes #193

See merge request isc-projects/bind9!183
2018-04-10 20:04:31 -07:00
Evan Hunt a6cbac45eb Alter distclean rule to prevent recursing into the same directory twice
Commit f87e0c03ee removed the "system" directory from the TESTDIRS
variable in bin/tests/Makefile.in in an attempt to fix "make distclean"
which was broken since commit 0d784de16a.  However, this change
prevented any system tests from being run when "make test" is invoked.

We now put it back into both SUBDIRS and TESTDIRS, but with a modified
rule to check for the existence of a Makefile in each subdirectory before
trying to run make there. This prevents "make distclean" from trying to
run again in a directory where it's already been run.

(cherry picked from commit 93ee6b8a22)
2018-04-10 20:04:31 -07:00
Michał KępieńandEvan Hunt a7f8268833 Fail CI pipeline when "make test" does not run any system tests
Apart from ensuring "make test" returns 0, also check whether any system
test output was generated as a result of running it.  This prevents the
CI job running system tests from succeeding unless it actually tests
something.

(cherry picked from commit 80ab2c0f22)
2018-04-10 20:04:31 -07:00
Evan Hunt b26a269b42 Merge branch '197-dnstap-sockaddr-v9_12' into 'v9_12'
Resolve "dnstap: log actual local IPv6 address, not :: listening address"

Closes #197

See merge request isc-projects/bind9!188
2018-04-10 17:21:08 -07:00
Evan Hunt fde64f3fe4 CHANGES note
(cherry picked from commit 330b26c9df)
2018-04-10 17:21:08 -07:00
Tony FinchandEvan Hunt 58aac41b7e dnstap: log actual local IPv6 address, not :: listening address
(cherry picked from commit ccff953c25)
2018-04-10 17:21:08 -07:00
Evan Hunt 011968a6d4 Merge branch '183-add-dns_fixedname_initname-v9_12' into 'v9_12'
Add and use dns_fixedname_initname()

Closes #183

See merge request isc-projects/bind9!161
2018-04-10 13:10:29 -07:00
Mukund SivaramanandEvan Hunt d7676d0fa8 Add CHANGES entry:
4921.   [cleanup]       Add dns_fixedname_initname() and refactor the caller
                        code to make usage of the new function, as a part of
                        refactoring dns_fixedname_*() macros were turned into
                        functions. [GL #183]

(cherry picked from commit d7faee2566)
2018-04-10 13:10:23 -07:00
Michał KępieńandEvan Hunt 706f865a20 Do not access dns_fixedname_t fields directly
Employ dns_fixedname_name() and dns_fixedname_initname() to no longer
directly access dns_fixedname_t fields.

(cherry picked from commit 39ddf9991f)
2018-04-10 13:09:37 -07:00
Michał KępieńandEvan Hunt 0041aeb751 Use dns_fixedname_initname() where possible
Replace dns_fixedname_init() calls followed by dns_fixedname_name()
calls with calls to dns_fixedname_initname() where it is possible
without affecting current behavior and/or performance.

This patch was mostly prepared using Coccinelle and the following
semantic patch:

    @@
    expression fixedname, name;
    @@
    -	dns_fixedname_init(&fixedname);
    	...
    -	name = dns_fixedname_name(&fixedname);
    +	name = dns_fixedname_initname(&fixedname);

The resulting set of changes was then manually reviewed to exclude false
positives and apply minor tweaks.

It is likely that more occurrences of this pattern can be refactored in
an identical way.  This commit only takes care of the low-hanging fruit.

(cherry picked from commit 4df4a8e731)
2018-04-10 13:09:24 -07:00
Mukund SivaramanandEvan Hunt cee4fef7c5 Add a dns_fixedname_initname() helper function
This also turns the dns_fixedname macros into functions.

(cherry picked from commit 0d2a03c290)
2018-04-10 13:06:43 -07:00
Mark Andrews 38d5e47881 Merge branch 'ssl-double-free-v9_12' into 'v9_12'
Fix double free after keygen error in dnssec-keygen

Closes #109

See merge request isc-projects/bind9!70
2018-04-06 14:23:01 +10:00
Ondřej SurýandMark Andrews 24ea156f9e Add CHANGES entry
(cherry picked from commit ef2b2a6c92)
2018-04-06 14:22:46 +10:00
Ondřej SurýandMark Andrews cd6d3fbf07 A couple of more cleanups after free in opensslrsa_generate()
(cherry picked from commit d2b3188c61)
2018-04-06 14:21:11 +10:00
Petr MensikandMark Andrews d27c7940d9 Do not assign NULL conditionally in OpenSSL < 1.1, make it always explicit.
(cherry picked from commit edaafacf36)
2018-04-06 14:21:11 +10:00
Petr MensikandMark Andrews 587452f830 Fix double free on RSA_generate_key_ex failure
(cherry picked from commit 01cc622e7b)
2018-04-06 14:21:11 +10:00
Mark Andrews 342e146fe3 system should only be in SUBDIRS 2018-04-06 13:04:15 +10:00
Ondřej SurýandMark Andrews 9cf1468b77 Update libtool files to 2.4.6
(cherry picked from commit fe06778be7)
2018-04-06 12:36:39 +10:00
Ondřej Surý c2f32eba34 Merge branch 'pemensik/bind9-no-idn2-export-v9_12' into 'v9_12'
Don't include -lidn2 in isc-config.sh output

See merge request isc-projects/bind9!179
2018-04-05 06:15:41 -04:00
Ondřej Surý 40e5ba9cc5 Print information about LIBIDN2 in Configuration summary (Closes: #163)
(cherry picked from commit 8da5e5290f)
2018-04-05 12:07:53 +02:00
Petr MenšíkandOndřej Surý 8e8c195f94 Remove -lidn2 from exported LIBS. Do not propagate it from isc-config.sh --libs isc.
(cherry picked from commit 21c2871667)
2018-04-05 12:07:51 +02:00
Ondřej Surý 2c1fdbbb36 Merge branch 'kchen/bind9-test-prereqs-v9_12' into 'v9_12'
Add a Net::DNS prereq for couple of tests

See merge request isc-projects/bind9!176
2018-04-04 17:07:36 -04:00
Kevin ChenandOndřej Surý a8d7b3a12b Add a Net::DNS prereq for digdelv, fetchlimit, rpzrecurse, and zero
tests to avoid failed tests when Net::DNS is not present.

(cherry picked from commit 8b1b809ab4)
2018-04-04 23:00:56 +02:00
Stephen Morris 5fafa7303c Merge branch '139-tests-for-idna2008-libidn2-merge-v9_12' into 'v9_12'
Resolve "Tests for IDNA2008 (libidn2)" - Merge into 9.12

See merge request isc-projects/bind9!174
2018-04-04 10:05:05 -04:00
Stephen Morris 7f6d484d76 Check libidn2 version before proceding with one of the tests.
A known issue in libidn2 causes one of the tests of a fake A-label
to fail.  The problem should be corrected in version 2.0.5 of
libidn2.
2018-04-04 09:47:53 -04:00
Ondřej SurýandStephen Morris 5b9975e38f Use C.UTF-8 if available, and en_US.UTF-8 is available, otherwise do nothing and let the test break 2018-04-04 09:47:53 -04:00
Stephen Morris 5633f8afda Set known locale prior to running tests. 2018-04-04 09:47:53 -04:00
Stephen Morris 38fe1ce60f Fix check for the presence of IDNA. 2018-04-04 09:47:53 -04:00
Stephen Morris 5f00b9dad7 Added additional tests for invalid punycode strings. 2018-04-04 09:47:53 -04:00
Stephen Morris 2df1a2ef20 Initial set of IDNA tests. 2018-04-04 09:47:53 -04:00
Michał Kępień 286cad891a Merge branch '188-remove-duplicate-named_g_conffile-init-v9_12' into 'v9_12'
Remove redundant named_g_conffile initialization

Closes #188

See merge request isc-projects/bind9!166
2018-04-04 12:33:09 +02:00
Ondřej SurýandMichał Kępień 2301f0562e Remove redundant named_g_conffile initialization from bin/named/win32/os.c
(cherry picked from commit c727f0797b)
2018-04-04 12:33:09 +02:00
Ondřej Surý 505b8a2931 Merge branch '26-fix-normalization-for-non-IDN-v9_12' into 'v9_12'
Don't use the IDN translated name if no conversion took a place

See merge request isc-projects/bind9!156
2018-03-22 10:03:50 -04:00
Ondřej Surý 722152db8b Don't use the IDN traslated name if no conversion took a place
(cherry picked from commit 08f66d8509)
2018-03-22 13:54:30 +00:00
Mark Andrews cf8787b6ac Merge branch '167-coverity-dereferencing-a-null-pointer-in-lib-dns-tests-rbt_test-c-v9_12' into 'v9_12'
Resolve "coverity: Dereferencing a null pointer in lib/dns/tests/rbt_test.c"

Closes #167

See merge request isc-projects/bind9!150
2018-03-20 09:54:08 +11:00
Mukund SivaramanandMark Andrews d2dea05356 Check return value of isc_mem_get()
(cherry picked from commit de3a4af1bf)
2018-03-20 09:54:08 +11:00
Mark Andrews da23698286 fix temporary file name to have subtest number
(cherry picked from commit e12453f43c88bac722fb511b62f12303735b788c)
2018-03-19 23:13:44 +11:00
Mark Andrews 10f04106fb Merge branch 'fixtypo-v9_12' into 'v9_12'
fix typo

See merge request isc-projects/bind9!148
2018-03-19 22:51:14 +11:00
Mark Andrews a296346e48 fix typo
(cherry picked from commit 6e4b5f2345)
2018-03-19 22:51:13 +11:00
Mark Andrews 987e31cc3e Merge branch '166-statistics-system-test-numbering-is-bad-v9_12' into 'v9_12'
Resolve "statistics system test numbering is bad"

Closes #166

See merge request isc-projects/bind9!146
2018-03-19 20:19:08 +11:00
Mark Andrews d4978012c2 fix numbering of tests and make consistent
(cherry picked from commit dd5dff3096)
2018-03-19 20:19:07 +11:00
Ondřej Surý 9a1cfc88a7 Merge branch '164-remove-openssl-warning-v9_12' into 'v9_12'
[v9_12] Remove useless OpenSSL warning from configure script

See merge request isc-projects/bind9!140
2018-03-17 10:50:24 -04:00